Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1626657 > unrolled thread
| Started by | Andi Kleen <andi@firstfloor.org> |
|---|---|
| First post | 2017-04-19 20:00 +0200 |
| Last post | 2017-04-19 21:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] perf, tools: Fix display of data source snoop indication Andi Kleen <andi@firstfloor.org> - 2017-04-19 20:00 +0200
Re: [PATCH] perf, tools: Fix display of data source snoop indication Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-04-19 20:50 +0200
Re: [PATCH] perf, tools: Fix display of data source snoop indication Andi Kleen <ak@linux.intel.com> - 2017-04-19 21:00 +0200
| From | Andi Kleen <andi@firstfloor.org> |
|---|---|
| Date | 2017-04-19 20:00 +0200 |
| Subject | [PATCH] perf, tools: Fix display of data source snoop indication |
| Message-ID | <ty23v-6o6-9@gated-at.bofh.it> |
From: Andi Kleen <ak@linux.intel.com>
perf mem report doesn't display the data source snoop indication correctly.
In the kernel API the definition is
but the table used by the perf tools exchanged Hit and Miss
"None",
"Miss",
"Hit",
Fix the table in perf.
Cc: eranian@google.com
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
tools/perf/util/mem-events.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
index 1d4ab53c60ca..865ba3c39284 100644
--- a/tools/perf/util/mem-events.c
+++ b/tools/perf/util/mem-events.c
@@ -205,8 +205,8 @@ int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info)
static const char * const snoop_access[] = {
"N/A",
"None",
- "Miss",
"Hit",
+ "Miss",
"HitM",
};
--
2.9.3
[toc] | [next] | [standalone]
| From | Arnaldo Carvalho de Melo <acme@kernel.org> |
|---|---|
| Date | 2017-04-19 20:50 +0200 |
| Message-ID | <ty2PT-6TL-15@gated-at.bofh.it> |
| In reply to | #1626657 |
Em Wed, Apr 19, 2017 at 10:49:40AM -0700, Andi Kleen escreveu:
> From: Andi Kleen <ak@linux.intel.com>
>
> perf mem report doesn't display the data source snoop indication correctly.
>
> In the kernel API the definition is
missing something?
> but the table used by the perf tools exchanged Hit and Miss
>
> "None",
> "Miss",
> "Hit",
>
> Fix the table in perf.
>
> Cc: eranian@google.com
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
> tools/perf/util/mem-events.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
> index 1d4ab53c60ca..865ba3c39284 100644
> --- a/tools/perf/util/mem-events.c
> +++ b/tools/perf/util/mem-events.c
> @@ -205,8 +205,8 @@ int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info)
> static const char * const snoop_access[] = {
> "N/A",
> "None",
> - "Miss",
> "Hit",
> + "Miss",
> "HitM",
> };
>
> --
> 2.9.3
[toc] | [prev] | [next] | [standalone]
| From | Andi Kleen <ak@linux.intel.com> |
|---|---|
| Date | 2017-04-19 21:00 +0200 |
| Message-ID | <ty2ZA-6X8-27@gated-at.bofh.it> |
| In reply to | #1626705 |
On Wed, Apr 19, 2017 at 03:46:13PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Apr 19, 2017 at 10:49:40AM -0700, Andi Kleen escreveu:
> > From: Andi Kleen <ak@linux.intel.com>
> >
> > perf mem report doesn't display the data source snoop indication correctly.
> >
> > In the kernel API the definition is
>
> missing something?
#define PERF_MEM_SNOOP_NONE 0x02 /* no snoop */
#define PERF_MEM_SNOOP_HIT 0x04 /* snoop hit */
#define PERF_MEM_SNOOP_MISS 0x08 /* snoop miss */
>
> > but the table used by the perf tools exchanged Hit and Miss
> >
> > "None",
> > "Miss",
> > "Hit",
> >
> > Fix the table in perf.
> >
> > Cc: eranian@google.com
> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
> > ---
> > tools/perf/util/mem-events.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
> > index 1d4ab53c60ca..865ba3c39284 100644
> > --- a/tools/perf/util/mem-events.c
> > +++ b/tools/perf/util/mem-events.c
> > @@ -205,8 +205,8 @@ int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info)
> > static const char * const snoop_access[] = {
> > "N/A",
> > "None",
> > - "Miss",
> > "Hit",
> > + "Miss",
> > "HitM",
> > };
> >
> > --
> > 2.9.3
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web