Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1626705

Re: [PATCH] perf, tools: Fix display of data source snoop indication

From Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] perf, tools: Fix display of data source snoop indication
Date 2017-04-19 20:50 +0200
Message-ID <ty2PT-6TL-15@gated-at.bofh.it> (permalink)
References <ty23v-6o6-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Em Wed, Apr 19, 2017 at 10:49:40AM -0700, Andi Kleen escreveu:
> From: Andi Kleen <ak@linux.intel.com>
> 
> perf mem report doesn't display the data source snoop indication correctly.
> 
> In the kernel API the definition is

missing something?
 
> but the table used by the perf tools exchanged Hit and Miss
> 
>         "None",
>         "Miss",
>         "Hit",
> 
> Fix the table in perf.
> 
> Cc: eranian@google.com
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
>  tools/perf/util/mem-events.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
> index 1d4ab53c60ca..865ba3c39284 100644
> --- a/tools/perf/util/mem-events.c
> +++ b/tools/perf/util/mem-events.c
> @@ -205,8 +205,8 @@ int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info)
>  static const char * const snoop_access[] = {
>  	"N/A",
>  	"None",
> -	"Miss",
>  	"Hit",
> +	"Miss",
>  	"HitM",
>  };
>  
> -- 
> 2.9.3

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] perf, tools: Fix display of data source snoop indication Andi Kleen <andi@firstfloor.org> - 2017-04-19 20:00 +0200
  Re: [PATCH] perf, tools: Fix display of data source snoop indication Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-04-19 20:50 +0200
    Re: [PATCH] perf, tools: Fix display of data source snoop indication Andi Kleen <ak@linux.intel.com> - 2017-04-19 21:00 +0200

csiph-web