Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1624128 > unrolled thread
| Started by | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| First post | 2017-04-15 22:00 +0200 |
| Last post | 2017-04-17 18:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
pinctrl: imx: Checking reuse of grouping functionality SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-15 22:00 +0200
Re: pinctrl: imx: Checking reuse of grouping functionality Gary Bisson <gary.bisson@boundarydevices.com> - 2017-04-17 10:30 +0200
Re: pinctrl: imx: Checking reuse of grouping functionality SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 18:10 +0200
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2017-04-15 22:00 +0200 |
| Subject | pinctrl: imx: Checking reuse of grouping functionality |
| Message-ID | <twC1r-2no-3@gated-at.bofh.it> |
Hello, A preprocessor symbol like “CONFIG_GENERIC_PINCTRL_GROUPS” was introduced by the commit c033a718f615b6b3ddc83ce3e0a217c30bd09cb5 (“pinctrl: stricten up generic group code”) on 2017-01-03. Some functions are only available then when this macro is defined. I have got the impression that the corresponding programming interface is used by the source file “drivers/pinctrl/freescale/pinctrl-imx.c” unconditionally. How do you think about to extend specifications for conditional compilation there? Regards, Markus
[toc] | [next] | [standalone]
| From | Gary Bisson <gary.bisson@boundarydevices.com> |
|---|---|
| Date | 2017-04-17 10:30 +0200 |
| Message-ID | <txacN-6R6-9@gated-at.bofh.it> |
| In reply to | #1624128 |
Hi Markus, All, On Sat, Apr 15, 2017 at 9:55 PM, SF Markus Elfring <elfring@users.sourceforge.net> wrote: > Hello, > > A preprocessor symbol like “CONFIG_GENERIC_PINCTRL_GROUPS” was introduced > by the commit c033a718f615b6b3ddc83ce3e0a217c30bd09cb5 (“pinctrl: stricten up > generic group code”) on 2017-01-03. Some functions are only available then > when this macro is defined. Yes because the pinctrl driver can be used without this configuration by some drivers. > I have got the impression that the corresponding programming interface is used > by the source file “drivers/pinctrl/freescale/pinctrl-imx.c” unconditionally. > How do you think about to extend specifications for conditional compilation there? However the imx pinctrl driver _absolutely_ needs this configuration to work. That is why it is selected automatically when the driver is enabled [1]. Therefore it isn't possible to build the driver without GENERIC_PINCTRL_GROUPS and so adding conditions is not necessary. Regards, Gary [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pinctrl/freescale/Kconfig#n3
[toc] | [prev] | [next] | [standalone]
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2017-04-17 18:10 +0200 |
| Message-ID | <txhnY-2LT-17@gated-at.bofh.it> |
| In reply to | #1624599 |
> However the imx pinctrl driver _absolutely_ needs this configuration to work. Thanks for your explanation that the file “drivers/pinctrl/freescale/Kconfig” will usually provide needed information for this software module. Would it make sense to document such a requirement also by a preprocessor error directive in the source file “drivers/pinctrl/freescale/pinctrl-imx.c” for the special case if the macro “CONFIG_GENERIC_PINCTRL_GROUPS” would accidentally not be defined? Regards, Markus
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web