Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1624599

Re: pinctrl: imx: Checking reuse of grouping functionality

Show all headers | View raw

Hi Markus, All,

On Sat, Apr 15, 2017 at 9:55 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> Hello,
>
> A preprocessor symbol like “CONFIG_GENERIC_PINCTRL_GROUPS” was introduced
> by the commit c033a718f615b6b3ddc83ce3e0a217c30bd09cb5 (“pinctrl: stricten up
> generic group code”) on 2017-01-03. Some functions are only available then
> when this macro is defined.

Yes because the pinctrl driver can be used without this configuration
by some drivers.

> I have got the impression that the corresponding programming interface is used
> by the source file “drivers/pinctrl/freescale/pinctrl-imx.c” unconditionally.
> How do you think about to extend specifications for conditional compilation there?

However the imx pinctrl driver _absolutely_ needs this configuration
to work. That is why it is selected automatically when the driver is
enabled [1].

Therefore it isn't possible to build the driver without
GENERIC_PINCTRL_GROUPS and so adding conditions is not necessary.

Regards,
Gary

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pinctrl/freescale/Kconfig#n3

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

pinctrl: imx: Checking reuse of grouping functionality SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-15 22:00 +0200
  Re: pinctrl: imx: Checking reuse of grouping functionality Gary Bisson <gary.bisson@boundarydevices.com> - 2017-04-17 10:30 +0200
    Re: pinctrl: imx: Checking reuse of grouping functionality SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 18:10 +0200

csiph-web