Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1625372 > unrolled thread
| Started by | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
|---|---|
| First post | 2017-04-18 16:50 +0200 |
| Last post | 2017-04-18 19:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] ACPI / APEI: use setup_deferrable_timer "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-04-18 16:50 +0200
Re: [PATCH] ACPI / APEI: use setup_deferrable_timer Borislav Petkov <bp@suse.de> - 2017-04-18 19:30 +0200
| From | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
|---|---|
| Date | 2017-04-18 16:50 +0200 |
| Subject | Re: [PATCH] ACPI / APEI: use setup_deferrable_timer |
| Message-ID | <txCC5-7kc-1@gated-at.bofh.it> |
On Saturday, March 11, 2017 08:46:55 AM Geliang Tang wrote:
> Use setup_deferrable_timer() instead of init_timer_deferrable() to
> simplify the code.
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
Boris, Tony, any concerns?
If not, do you want to route this through the RAS tree?
> ---
> drivers/acpi/apei/ghes.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index b192b42..33ca196 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -1005,9 +1005,8 @@ static int ghes_probe(struct platform_device *ghes_dev)
>
> switch (generic->notify.type) {
> case ACPI_HEST_NOTIFY_POLLED:
> - ghes->timer.function = ghes_poll_func;
> - ghes->timer.data = (unsigned long)ghes;
> - init_timer_deferrable(&ghes->timer);
> + setup_deferrable_timer(&ghes->timer, ghes_poll_func,
> + (unsigned long)ghes);
> ghes_add_timer(ghes);
> break;
> case ACPI_HEST_NOTIFY_EXTERNAL:
>
[toc] | [next] | [standalone]
| From | Borislav Petkov <bp@suse.de> |
|---|---|
| Date | 2017-04-18 19:30 +0200 |
| Message-ID | <txF6V-rr-5@gated-at.bofh.it> |
| In reply to | #1625372 |
On Tue, Apr 18, 2017 at 04:41:55PM +0200, Rafael J. Wysocki wrote:
> On Saturday, March 11, 2017 08:46:55 AM Geliang Tang wrote:
> > Use setup_deferrable_timer() instead of init_timer_deferrable() to
> > simplify the code.
> >
> > Signed-off-by: Geliang Tang <geliangtang@gmail.com>
>
> Boris, Tony, any concerns?
>
> If not, do you want to route this through the RAS tree?
Sure, applied, thanks.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web