Re: [PATCH] ACPI / APEI: use setup_deferrable_timer

From	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ACPI / APEI: use setup_deferrable_timer
Date	2017-04-18 16:50 +0200
Message-ID	<txCC5-7kc-1@gated-at.bofh.it> (permalink)
References	<tjDol-3gr-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Saturday, March 11, 2017 08:46:55 AM Geliang Tang wrote:
> Use setup_deferrable_timer() instead of init_timer_deferrable() to
> simplify the code.
> 
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>

Boris, Tony, any concerns?

If not, do you want to route this through the RAS tree?

> ---
>  drivers/acpi/apei/ghes.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index b192b42..33ca196 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -1005,9 +1005,8 @@ static int ghes_probe(struct platform_device *ghes_dev)
>  
>  	switch (generic->notify.type) {
>  	case ACPI_HEST_NOTIFY_POLLED:
> -		ghes->timer.function = ghes_poll_func;
> -		ghes->timer.data = (unsigned long)ghes;
> -		init_timer_deferrable(&ghes->timer);
> +		setup_deferrable_timer(&ghes->timer, ghes_poll_func,
> +				       (unsigned long)ghes);
>  		ghes_add_timer(ghes);
>  		break;
>  	case ACPI_HEST_NOTIFY_EXTERNAL:
>

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] ACPI / APEI: use setup_deferrable_timer "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-04-18 16:50 +0200
  Re: [PATCH] ACPI / APEI: use setup_deferrable_timer Borislav Petkov <bp@suse.de> - 2017-04-18 19:30 +0200

csiph-web