Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1624480 > unrolled thread
| Started by | Samuel Ortiz <sameo@linux.intel.com> |
|---|---|
| First post | 2017-04-17 00:50 +0200 |
| Last post | 2017-04-17 00:50 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] nfc: fix get_unaligned_...() misuses Samuel Ortiz <sameo@linux.intel.com> - 2017-04-17 00:50 +0200
| From | Samuel Ortiz <sameo@linux.intel.com> |
|---|---|
| Date | 2017-04-17 00:50 +0200 |
| Subject | Re: [PATCH] nfc: fix get_unaligned_...() misuses |
| Message-ID | <tx19v-Z9-1@gated-at.bofh.it> |
On Thu, Apr 06, 2017 at 05:58:59PM +0100, Al Viro wrote: > On Thu, Apr 06, 2017 at 05:48:47PM +0100, Al Viro wrote: > > * use unaligned.h, not unaligned/access_ok.h > > ... which got misspelled in that patch, sorry... Fixed variant follows: > > commit b3e79ba1708c9b74781079c9f8617448fce36b51 > Author: Al Viro <viro@zeniv.linux.org.uk> > Date: Thu Apr 6 12:42:14 2017 -0400 > > nfc: fix get_unaligned_...() misuses > > * use unaligned.h, not unaligned/access_ok.h > * if a local variable of type uint16_t is unaligned, your compiler is FUBAR > * the whole point of get_unaligned_... is to avoid memcpy + ..._to_cpu(). > Using it *after* memcpy() (into aligned object, no less) is pointless. > > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Partly applied to nfc-next. The unaligned/access_ok.h replacements were already applied. Cheers, Samuel.
Back to top | Article view | linux.kernel
csiph-web