Re: [PATCH] nfc: fix get_unaligned_...() misuses

From	Samuel Ortiz <sameo@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] nfc: fix get_unaligned_...() misuses
Date	2017-04-17 00:50 +0200
Message-ID	<tx19v-Z9-1@gated-at.bofh.it> (permalink)
References	<ttiLD-3md-19@gated-at.bofh.it> <ttiVj-3pQ-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Apr 06, 2017 at 05:58:59PM +0100, Al Viro wrote:
> On Thu, Apr 06, 2017 at 05:48:47PM +0100, Al Viro wrote:
> > * use unaligned.h, not unaligned/access_ok.h
> 
> ... which got misspelled in that patch, sorry...  Fixed variant follows:
> 
> commit b3e79ba1708c9b74781079c9f8617448fce36b51
> Author: Al Viro <viro@zeniv.linux.org.uk>
> Date:   Thu Apr 6 12:42:14 2017 -0400
> 
>     nfc: fix get_unaligned_...() misuses
>     
>     * use unaligned.h, not unaligned/access_ok.h
>     * if a local variable of type uint16_t is unaligned, your compiler is FUBAR
>     * the whole point of get_unaligned_... is to avoid memcpy + ..._to_cpu().
>       Using it *after* memcpy() (into aligned object, no less) is pointless.
>     
>     Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Partly applied to nfc-next. The unaligned/access_ok.h replacements were
already applied.

Cheers,
Samuel.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] nfc: fix get_unaligned_...() misuses Samuel Ortiz <sameo@linux.intel.com> - 2017-04-17 00:50 +0200

csiph-web