Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1624093 > unrolled thread
| Started by | Tony Lindgren <tony@atomide.com> |
|---|---|
| First post | 2017-04-15 19:10 +0200 |
| Last post | 2017-04-24 16:20 +0200 |
| Articles | 9 — 3 participants |
Back to article view | Back to linux.kernel
[PATCHv2 0/2] mfd: omap-usb-tll: Fixes for USB TLL mode Tony Lindgren <tony@atomide.com> - 2017-04-15 19:10 +0200
[PATCH 2/2] mfd: omap-usb-tll: Configure ULPIAUTOIDLE Tony Lindgren <tony@atomide.com> - 2017-04-15 19:10 +0200
Re: [PATCH 2/2] mfd: omap-usb-tll: Configure ULPIAUTOIDLE Roger Quadros <rogerq@ti.com> - 2017-04-18 10:40 +0200
Re: [PATCH 2/2] mfd: omap-usb-tll: Configure ULPIAUTOIDLE Lee Jones <lee.jones@linaro.org> - 2017-04-24 13:50 +0200
[PATCH 1/2] mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode Tony Lindgren <tony@atomide.com> - 2017-04-15 19:10 +0200
Re: [PATCH 1/2] mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode Roger Quadros <rogerq@ti.com> - 2017-04-18 10:40 +0200
Re: [PATCH 1/2] mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode Lee Jones <lee.jones@linaro.org> - 2017-04-24 13:50 +0200
Re: [PATCHv2 0/2] mfd: omap-usb-tll: Fixes for USB TLL mode Lee Jones <lee.jones@linaro.org> - 2017-04-24 13:50 +0200
Re: [PATCHv2 0/2] mfd: omap-usb-tll: Fixes for USB TLL mode Tony Lindgren <tony@atomide.com> - 2017-04-24 16:20 +0200
| From | Tony Lindgren <tony@atomide.com> |
|---|---|
| Date | 2017-04-15 19:10 +0200 |
| Subject | [PATCHv2 0/2] mfd: omap-usb-tll: Fixes for USB TLL mode |
| Message-ID | <twzmV-S2-5@gated-at.bofh.it> |
Hi Here's v2 of this that move the enabling of ULPIAUTOIDLE bit into a separate patch as suggested by Roger Quadros <rogerq@ti.com>. Both patches can wait for v4.12. Regards, Tony Tony Lindgren (2): mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode mfd: omap-usb-tll: Configure ULPIAUTOIDLE drivers/mfd/omap-usb-tll.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) -- 2.12.2
[toc] | [next] | [standalone]
| From | Tony Lindgren <tony@atomide.com> |
|---|---|
| Date | 2017-04-15 19:10 +0200 |
| Subject | [PATCH 2/2] mfd: omap-usb-tll: Configure ULPIAUTOIDLE |
| Message-ID | <twzmV-S2-9@gated-at.bofh.it> |
| In reply to | #1624093 |
The idle mode needs to be only disabled for UTMIAUTOIDLE while
ULPIAUTOIDLE can be enabled.
This matches the TLL_CHANNEL_CONF_i register configuration for ehci-tll
in the Motorola Linux kernel tree for Wrigley 3G LTE modem on droid 4
and the modem still stays responsive.
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: Keshava Munegowda <keshava_mgowda@ti.com>
Cc: Marcel Partap <mpartap@gmx.net>
Cc: Michael Scott <michael.scott@linaro.org>
Cc: Roger Quadros <rogerq@ti.com>
Cc: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
drivers/mfd/omap-usb-tll.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
--- a/drivers/mfd/omap-usb-tll.c
+++ b/drivers/mfd/omap-usb-tll.c
@@ -373,12 +373,13 @@ int omap_tll_init(struct usbhs_omap_platform_data *pdata)
} else if (pdata->port_mode[i] ==
OMAP_EHCI_PORT_MODE_TLL) {
/*
- * Disable AutoIdle, BitStuffing
- * and use SDR Mode
+ * Disable UTMI AutoIdle, BitStuffing
+ * and use SDR Mode. Enable ULPI AutoIdle.
*/
reg &= ~(OMAP_TLL_CHANNEL_CONF_UTMIAUTOIDLE
| OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE);
reg |= OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF;
+ reg |= OMAP_TLL_CHANNEL_CONF_ULPI_ULPIAUTOIDLE;
} else if (pdata->port_mode[i] ==
OMAP_EHCI_PORT_MODE_HSIC) {
/*
--
2.12.2
[toc] | [prev] | [next] | [standalone]
| From | Roger Quadros <rogerq@ti.com> |
|---|---|
| Date | 2017-04-18 10:40 +0200 |
| Subject | Re: [PATCH 2/2] mfd: omap-usb-tll: Configure ULPIAUTOIDLE |
| Message-ID | <txwQ1-3Wq-1@gated-at.bofh.it> |
| In reply to | #1624094 |
On 15/04/17 20:05, Tony Lindgren wrote:
> The idle mode needs to be only disabled for UTMIAUTOIDLE while
> ULPIAUTOIDLE can be enabled.
>
> This matches the TLL_CHANNEL_CONF_i register configuration for ehci-tll
> in the Motorola Linux kernel tree for Wrigley 3G LTE modem on droid 4
> and the modem still stays responsive.
>
> Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
> Cc: Keshava Munegowda <keshava_mgowda@ti.com>
> Cc: Marcel Partap <mpartap@gmx.net>
> Cc: Michael Scott <michael.scott@linaro.org>
> Cc: Roger Quadros <rogerq@ti.com>
> Cc: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Acked-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/mfd/omap-usb-tll.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
> --- a/drivers/mfd/omap-usb-tll.c
> +++ b/drivers/mfd/omap-usb-tll.c
> @@ -373,12 +373,13 @@ int omap_tll_init(struct usbhs_omap_platform_data *pdata)
> } else if (pdata->port_mode[i] ==
> OMAP_EHCI_PORT_MODE_TLL) {
> /*
> - * Disable AutoIdle, BitStuffing
> - * and use SDR Mode
> + * Disable UTMI AutoIdle, BitStuffing
> + * and use SDR Mode. Enable ULPI AutoIdle.
> */
> reg &= ~(OMAP_TLL_CHANNEL_CONF_UTMIAUTOIDLE
> | OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE);
> reg |= OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF;
> + reg |= OMAP_TLL_CHANNEL_CONF_ULPI_ULPIAUTOIDLE;
> } else if (pdata->port_mode[i] ==
> OMAP_EHCI_PORT_MODE_HSIC) {
> /*
>
cheers,
-roger
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2017-04-24 13:50 +0200 |
| Subject | Re: [PATCH 2/2] mfd: omap-usb-tll: Configure ULPIAUTOIDLE |
| Message-ID | <tzKFc-6uK-9@gated-at.bofh.it> |
| In reply to | #1624094 |
On Sat, 15 Apr 2017, Tony Lindgren wrote:
> The idle mode needs to be only disabled for UTMIAUTOIDLE while
> ULPIAUTOIDLE can be enabled.
>
> This matches the TLL_CHANNEL_CONF_i register configuration for ehci-tll
> in the Motorola Linux kernel tree for Wrigley 3G LTE modem on droid 4
> and the modem still stays responsive.
>
> Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
> Cc: Keshava Munegowda <keshava_mgowda@ti.com>
> Cc: Marcel Partap <mpartap@gmx.net>
> Cc: Michael Scott <michael.scott@linaro.org>
> Cc: Roger Quadros <rogerq@ti.com>
> Cc: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/mfd/omap-usb-tll.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
> --- a/drivers/mfd/omap-usb-tll.c
> +++ b/drivers/mfd/omap-usb-tll.c
> @@ -373,12 +373,13 @@ int omap_tll_init(struct usbhs_omap_platform_data *pdata)
> } else if (pdata->port_mode[i] ==
> OMAP_EHCI_PORT_MODE_TLL) {
> /*
> - * Disable AutoIdle, BitStuffing
> - * and use SDR Mode
> + * Disable UTMI AutoIdle, BitStuffing
> + * and use SDR Mode. Enable ULPI AutoIdle.
> */
> reg &= ~(OMAP_TLL_CHANNEL_CONF_UTMIAUTOIDLE
> | OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE);
> reg |= OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF;
> + reg |= OMAP_TLL_CHANNEL_CONF_ULPI_ULPIAUTOIDLE;
> } else if (pdata->port_mode[i] ==
> OMAP_EHCI_PORT_MODE_HSIC) {
> /*
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [next] | [standalone]
| From | Tony Lindgren <tony@atomide.com> |
|---|---|
| Date | 2017-04-15 19:10 +0200 |
| Subject | [PATCH 1/2] mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode |
| Message-ID | <twzmW-S2-11@gated-at.bofh.it> |
| In reply to | #1624093 |
Commit 16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")
added support for USB TLL, but uses OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF
bit the wrong way. The comments in the code are correct, but the inverted
use of OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF causes the register to be
enabled instead of disabled unlike what the comments say.
Without this change the Wrigley 3G LTE modem on droid 4 EHCI bus can
be only pinged few times before it stops responding.
Fixes: 16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: Keshava Munegowda <keshava_mgowda@ti.com>
Cc: Marcel Partap <mpartap@gmx.net>
Cc: Michael Scott <michael.scott@linaro.org>
Cc: Roger Quadros <rogerq@ti.com>
Cc: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
drivers/mfd/omap-usb-tll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
--- a/drivers/mfd/omap-usb-tll.c
+++ b/drivers/mfd/omap-usb-tll.c
@@ -377,8 +377,8 @@ int omap_tll_init(struct usbhs_omap_platform_data *pdata)
* and use SDR Mode
*/
reg &= ~(OMAP_TLL_CHANNEL_CONF_UTMIAUTOIDLE
- | OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF
| OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE);
+ reg |= OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF;
} else if (pdata->port_mode[i] ==
OMAP_EHCI_PORT_MODE_HSIC) {
/*
--
2.12.2
[toc] | [prev] | [next] | [standalone]
| From | Roger Quadros <rogerq@ti.com> |
|---|---|
| Date | 2017-04-18 10:40 +0200 |
| Subject | Re: [PATCH 1/2] mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode |
| Message-ID | <txwQ1-3Wq-9@gated-at.bofh.it> |
| In reply to | #1624096 |
On 15/04/17 20:05, Tony Lindgren wrote:
> Commit 16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")
> added support for USB TLL, but uses OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF
> bit the wrong way. The comments in the code are correct, but the inverted
> use of OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF causes the register to be
> enabled instead of disabled unlike what the comments say.
>
> Without this change the Wrigley 3G LTE modem on droid 4 EHCI bus can
> be only pinged few times before it stops responding.
>
> Fixes: 16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")
> Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
> Cc: Keshava Munegowda <keshava_mgowda@ti.com>
> Cc: Marcel Partap <mpartap@gmx.net>
> Cc: Michael Scott <michael.scott@linaro.org>
> Cc: Roger Quadros <rogerq@ti.com>
> Cc: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Acked-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/mfd/omap-usb-tll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
> --- a/drivers/mfd/omap-usb-tll.c
> +++ b/drivers/mfd/omap-usb-tll.c
> @@ -377,8 +377,8 @@ int omap_tll_init(struct usbhs_omap_platform_data *pdata)
> * and use SDR Mode
> */
> reg &= ~(OMAP_TLL_CHANNEL_CONF_UTMIAUTOIDLE
> - | OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF
> | OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE);
> + reg |= OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF;
> } else if (pdata->port_mode[i] ==
> OMAP_EHCI_PORT_MODE_HSIC) {
> /*
>
cheers,
-roger
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2017-04-24 13:50 +0200 |
| Subject | Re: [PATCH 1/2] mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode |
| Message-ID | <tzKFc-6uK-11@gated-at.bofh.it> |
| In reply to | #1624096 |
On Sat, 15 Apr 2017, Tony Lindgren wrote:
> Commit 16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")
> added support for USB TLL, but uses OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF
> bit the wrong way. The comments in the code are correct, but the inverted
> use of OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF causes the register to be
> enabled instead of disabled unlike what the comments say.
>
> Without this change the Wrigley 3G LTE modem on droid 4 EHCI bus can
> be only pinged few times before it stops responding.
>
> Fixes: 16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")
> Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
> Cc: Keshava Munegowda <keshava_mgowda@ti.com>
> Cc: Marcel Partap <mpartap@gmx.net>
> Cc: Michael Scott <michael.scott@linaro.org>
> Cc: Roger Quadros <rogerq@ti.com>
> Cc: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/mfd/omap-usb-tll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
> --- a/drivers/mfd/omap-usb-tll.c
> +++ b/drivers/mfd/omap-usb-tll.c
> @@ -377,8 +377,8 @@ int omap_tll_init(struct usbhs_omap_platform_data *pdata)
> * and use SDR Mode
> */
> reg &= ~(OMAP_TLL_CHANNEL_CONF_UTMIAUTOIDLE
> - | OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF
> | OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE);
> + reg |= OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF;
> } else if (pdata->port_mode[i] ==
> OMAP_EHCI_PORT_MODE_HSIC) {
> /*
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2017-04-24 13:50 +0200 |
| Message-ID | <tzKFc-6uK-15@gated-at.bofh.it> |
| In reply to | #1624093 |
On Sat, 15 Apr 2017, Tony Lindgren wrote: > Hi > > Here's v2 of this that move the enabling of ULPIAUTOIDLE bit into a > separate patch as suggested by Roger Quadros <rogerq@ti.com>. > > Both patches can wait for v4.12. > > Regards, > > Tony > > > Tony Lindgren (2): > mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode > mfd: omap-usb-tll: Configure ULPIAUTOIDLE > > drivers/mfd/omap-usb-tll.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) FYI: I don't know where you're getting Sam's email from, but I assume that after being MFD-free for several years now, I'm assuming he's lost interest in the subsystem. Might be about time to stop CC'ing him. :) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [next] | [standalone]
| From | Tony Lindgren <tony@atomide.com> |
|---|---|
| Date | 2017-04-24 16:20 +0200 |
| Message-ID | <tzN0m-83T-19@gated-at.bofh.it> |
| In reply to | #1629448 |
* Lee Jones <lee.jones@linaro.org> [170424 04:46]: > FYI: I don't know where you're getting Sam's email from, but I assume > that after being MFD-free for several years now, I'm assuming he's > lost interest in the subsystem. Might be about time to stop CC'ing > him. :) OK fine with me, I'll stop spamming him then next time. Tony
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web