Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1629449
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] mfd: omap-usb-tll: Configure ULPIAUTOIDLE |
| Date | 2017-04-24 13:50 +0200 |
| Message-ID | <tzKFc-6uK-9@gated-at.bofh.it> (permalink) |
| References | <twzmV-S2-5@gated-at.bofh.it> <twzmV-S2-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, 15 Apr 2017, Tony Lindgren wrote:
> The idle mode needs to be only disabled for UTMIAUTOIDLE while
> ULPIAUTOIDLE can be enabled.
>
> This matches the TLL_CHANNEL_CONF_i register configuration for ehci-tll
> in the Motorola Linux kernel tree for Wrigley 3G LTE modem on droid 4
> and the modem still stays responsive.
>
> Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
> Cc: Keshava Munegowda <keshava_mgowda@ti.com>
> Cc: Marcel Partap <mpartap@gmx.net>
> Cc: Michael Scott <michael.scott@linaro.org>
> Cc: Roger Quadros <rogerq@ti.com>
> Cc: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/mfd/omap-usb-tll.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
> --- a/drivers/mfd/omap-usb-tll.c
> +++ b/drivers/mfd/omap-usb-tll.c
> @@ -373,12 +373,13 @@ int omap_tll_init(struct usbhs_omap_platform_data *pdata)
> } else if (pdata->port_mode[i] ==
> OMAP_EHCI_PORT_MODE_TLL) {
> /*
> - * Disable AutoIdle, BitStuffing
> - * and use SDR Mode
> + * Disable UTMI AutoIdle, BitStuffing
> + * and use SDR Mode. Enable ULPI AutoIdle.
> */
> reg &= ~(OMAP_TLL_CHANNEL_CONF_UTMIAUTOIDLE
> | OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE);
> reg |= OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF;
> + reg |= OMAP_TLL_CHANNEL_CONF_ULPI_ULPIAUTOIDLE;
> } else if (pdata->port_mode[i] ==
> OMAP_EHCI_PORT_MODE_HSIC) {
> /*
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCHv2 0/2] mfd: omap-usb-tll: Fixes for USB TLL mode Tony Lindgren <tony@atomide.com> - 2017-04-15 19:10 +0200
[PATCH 2/2] mfd: omap-usb-tll: Configure ULPIAUTOIDLE Tony Lindgren <tony@atomide.com> - 2017-04-15 19:10 +0200
Re: [PATCH 2/2] mfd: omap-usb-tll: Configure ULPIAUTOIDLE Roger Quadros <rogerq@ti.com> - 2017-04-18 10:40 +0200
Re: [PATCH 2/2] mfd: omap-usb-tll: Configure ULPIAUTOIDLE Lee Jones <lee.jones@linaro.org> - 2017-04-24 13:50 +0200
[PATCH 1/2] mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode Tony Lindgren <tony@atomide.com> - 2017-04-15 19:10 +0200
Re: [PATCH 1/2] mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode Roger Quadros <rogerq@ti.com> - 2017-04-18 10:40 +0200
Re: [PATCH 1/2] mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode Lee Jones <lee.jones@linaro.org> - 2017-04-24 13:50 +0200
Re: [PATCHv2 0/2] mfd: omap-usb-tll: Fixes for USB TLL mode Lee Jones <lee.jones@linaro.org> - 2017-04-24 13:50 +0200
Re: [PATCHv2 0/2] mfd: omap-usb-tll: Fixes for USB TLL mode Tony Lindgren <tony@atomide.com> - 2017-04-24 16:20 +0200
csiph-web