Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1621939 > unrolled thread
| Started by | Carlo Caione <carlo@endlessm.com> |
|---|---|
| First post | 2017-04-12 11:00 +0200 |
| Last post | 2017-04-12 22:20 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v3] HID: asus: support backlight on USB keyboards Carlo Caione <carlo@endlessm.com> - 2017-04-12 11:00 +0200
Re: [PATCH v3] HID: asus: support backlight on USB keyboards Carlo Caione <carlo@endlessm.com> - 2017-04-12 22:20 +0200
Re: [PATCH v3] HID: asus: support backlight on USB keyboards Jiri Kosina <jikos@kernel.org> - 2017-04-12 22:40 +0200
Re: [PATCH v3] HID: asus: support backlight on USB keyboards Jiri Kosina <jikos@kernel.org> - 2017-04-12 22:20 +0200
| From | Carlo Caione <carlo@endlessm.com> |
|---|---|
| Date | 2017-04-12 11:00 +0200 |
| Subject | Re: [PATCH v3] HID: asus: support backlight on USB keyboards |
| Message-ID | <tvmi5-2l1-1@gated-at.bofh.it> |
On Mon, Apr 10, 2017 at 8:39 AM, Benjamin Tissoires
<benjamin.tissoires@redhat.com> wrote:
> On Apr 06 2017 or thereabouts, Carlo Caione wrote:
>> + ret = devm_led_classdev_register(&hdev->dev, &drvdata->kbd_backlight->cdev);
>> + if (ret < 0) {
>> + /* No need to have this still around */
>> + devm_kfree(&hdev->dev, drvdata->kbd_backlight);
>> + cancel_work_sync(&drvdata->kbd_backlight->work);
>
> Small nitpick, you don't need to call cancel_work_sync() here, nobody
> could have called a worker. But OTOH, it doesn't hurt.
>
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Thanks Benjamin. Who should pick this up?
--
Carlo Caione | +39.340.80.30.096 | Endless
[toc] | [next] | [standalone]
| From | Carlo Caione <carlo@endlessm.com> |
|---|---|
| Date | 2017-04-12 22:20 +0200 |
| Message-ID | <tvwU9-LT-1@gated-at.bofh.it> |
| In reply to | #1621939 |
On Wed, Apr 12, 2017 at 10:12 PM, Jiri Kosina <jikos@kernel.org> wrote:
> On Wed, 12 Apr 2017, Carlo Caione wrote:
>
>> >> + ret = devm_led_classdev_register(&hdev->dev, &drvdata->kbd_backlight->cdev);
>> >> + if (ret < 0) {
>> >> + /* No need to have this still around */
>> >> + devm_kfree(&hdev->dev, drvdata->kbd_backlight);
>> >> + cancel_work_sync(&drvdata->kbd_backlight->work);
>> >
>> > Small nitpick, you don't need to call cancel_work_sync() here, nobody
>> > could have called a worker. But OTOH, it doesn't hurt.
>> >
>> > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>>
>> Thanks Benjamin. Who should pick this up?
>
> I am going to.
>
> I'll drop the cancel_work_sync() call while doing it, ok?
Sure, go for it.
Thank you,
--
Carlo Caione | +39.340.80.30.096 | Endless
[toc] | [prev] | [next] | [standalone]
| From | Jiri Kosina <jikos@kernel.org> |
|---|---|
| Date | 2017-04-12 22:40 +0200 |
| Message-ID | <tvxdv-UY-1@gated-at.bofh.it> |
| In reply to | #1622511 |
On Wed, 12 Apr 2017, Carlo Caione wrote: > > I'll drop the cancel_work_sync() call while doing it, ok? > > Sure, go for it. Applied to hid.git#for-4.12/asus. Thanks, -- Jiri Kosina SUSE Labs
[toc] | [prev] | [next] | [standalone]
| From | Jiri Kosina <jikos@kernel.org> |
|---|---|
| Date | 2017-04-12 22:20 +0200 |
| Message-ID | <tvwU9-LT-3@gated-at.bofh.it> |
| In reply to | #1621939 |
On Wed, 12 Apr 2017, Carlo Caione wrote:
> >> + ret = devm_led_classdev_register(&hdev->dev, &drvdata->kbd_backlight->cdev);
> >> + if (ret < 0) {
> >> + /* No need to have this still around */
> >> + devm_kfree(&hdev->dev, drvdata->kbd_backlight);
> >> + cancel_work_sync(&drvdata->kbd_backlight->work);
> >
> > Small nitpick, you don't need to call cancel_work_sync() here, nobody
> > could have called a worker. But OTOH, it doesn't hurt.
> >
> > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>
> Thanks Benjamin. Who should pick this up?
I am going to.
I'll drop the cancel_work_sync() call while doing it, ok?
--
Jiri Kosina
SUSE Labs
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web