Re: [PATCH v3] HID: asus: support backlight on USB keyboards

From	Carlo Caione <carlo@endlessm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] HID: asus: support backlight on USB keyboards
Date	2017-04-12 22:20 +0200
Message-ID	<tvwU9-LT-1@gated-at.bofh.it> (permalink)
References	<ttcGe-7cD-15@gated-at.bofh.it> <tuB9w-5xS-17@gated-at.bofh.it> <tvmi5-2l1-1@gated-at.bofh.it> <tvwU9-LT-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Apr 12, 2017 at 10:12 PM, Jiri Kosina <jikos@kernel.org> wrote:
> On Wed, 12 Apr 2017, Carlo Caione wrote:
>
>> >> +     ret = devm_led_classdev_register(&hdev->dev, &drvdata->kbd_backlight->cdev);
>> >> +     if (ret < 0) {
>> >> +             /* No need to have this still around */
>> >> +             devm_kfree(&hdev->dev, drvdata->kbd_backlight);
>> >> +             cancel_work_sync(&drvdata->kbd_backlight->work);
>> >
>> > Small nitpick, you don't need to call cancel_work_sync() here, nobody
>> > could have called a worker. But OTOH, it doesn't hurt.
>> >
>> > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>>
>> Thanks Benjamin. Who should pick this up?
>
> I am going to.
>
> I'll drop the cancel_work_sync() call while doing it, ok?

Sure, go for it.

Thank you,

-- 
Carlo Caione  |  +39.340.80.30.096  |  Endless

Thread

Re: [PATCH v3] HID: asus: support backlight on USB keyboards Carlo Caione <carlo@endlessm.com> - 2017-04-12 11:00 +0200
  Re: [PATCH v3] HID: asus: support backlight on USB keyboards Carlo Caione <carlo@endlessm.com> - 2017-04-12 22:20 +0200
    Re: [PATCH v3] HID: asus: support backlight on USB keyboards Jiri Kosina <jikos@kernel.org> - 2017-04-12 22:40 +0200
  Re: [PATCH v3] HID: asus: support backlight on USB keyboards Jiri Kosina <jikos@kernel.org> - 2017-04-12 22:20 +0200

csiph-web