Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1621306 > unrolled thread
| Started by | Lee Jones <lee.jones@linaro.org> |
|---|---|
| First post | 2017-04-11 16:10 +0200 |
| Last post | 2017-04-12 15:40 +0200 |
| Articles | 5 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH V2] clk: hi6220: Add the hi655x's pmic clock Lee Jones <lee.jones@linaro.org> - 2017-04-11 16:10 +0200
Re: [PATCH V2] clk: hi6220: Add the hi655x's pmic clock Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-04-11 23:20 +0200
Re: [PATCH V2] clk: hi6220: Add the hi655x's pmic clock Lee Jones <lee.jones@linaro.org> - 2017-04-12 10:10 +0200
Re: [PATCH V2] clk: hi6220: Add the hi655x's pmic clock Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-04-12 14:20 +0200
Re: [PATCH V2] clk: hi6220: Add the hi655x's pmic clock Lee Jones <lee.jones@linaro.org> - 2017-04-12 15:40 +0200
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2017-04-11 16:10 +0200 |
| Subject | Re: [PATCH V2] clk: hi6220: Add the hi655x's pmic clock |
| Message-ID | <tv4Ey-823-3@gated-at.bofh.it> |
On Sat, 08 Apr 2017, Daniel Lezcano wrote: > The hi655x multi function device is a PMIC providing regulators. > > The PMIC also provides a clock for the WiFi and the Bluetooth, let's implement > this clock in order to add it in the hi655x MFD and allow proper wireless > initialization. > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > > Changelog: > > V2: > - Added COMPILE_TEST option, compiled on x86 > - Removed useless parenthesis > - Used of_clk_hw_simple_get() instead of deref dance > - Do bailout if the clock-names is not specified > - Rollback on error > - Folded mfd line change and binding Why did you do that? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
[toc] | [next] | [standalone]
| From | Daniel Lezcano <daniel.lezcano@linaro.org> |
|---|---|
| Date | 2017-04-11 23:20 +0200 |
| Message-ID | <tvbmF-3WD-9@gated-at.bofh.it> |
| In reply to | #1621306 |
On Tue, Apr 11, 2017 at 03:06:13PM +0100, Lee Jones wrote: > On Sat, 08 Apr 2017, Daniel Lezcano wrote: > > > The hi655x multi function device is a PMIC providing regulators. > > > > The PMIC also provides a clock for the WiFi and the Bluetooth, let's implement > > this clock in order to add it in the hi655x MFD and allow proper wireless > > initialization. > > > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > > --- > > > > Changelog: > > > > V2: > > - Added COMPILE_TEST option, compiled on x86 > > - Removed useless parenthesis > > - Used of_clk_hw_simple_get() instead of deref dance > > - Do bailout if the clock-names is not specified > > - Rollback on error > > - Folded mfd line change and binding > > Why did you do that? I thought as the V1 had comments you would have waited for the V2 and as it was trivial enough, it could be folded and picked up via the clk tree via with your acked-by. I realize it was not a good idea. Do you want to drop it from your tree or shall I resubmit a V3 without the mfd change? -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2017-04-12 10:10 +0200 |
| Message-ID | <tvlvI-24R-9@gated-at.bofh.it> |
| In reply to | #1621628 |
On Tue, 11 Apr 2017, Daniel Lezcano wrote: > On Tue, Apr 11, 2017 at 03:06:13PM +0100, Lee Jones wrote: > > On Sat, 08 Apr 2017, Daniel Lezcano wrote: > > > > > The hi655x multi function device is a PMIC providing regulators. > > > > > > The PMIC also provides a clock for the WiFi and the Bluetooth, let's implement > > > this clock in order to add it in the hi655x MFD and allow proper wireless > > > initialization. > > > > > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > > > --- > > > > > > Changelog: > > > > > > V2: > > > - Added COMPILE_TEST option, compiled on x86 > > > - Removed useless parenthesis > > > - Used of_clk_hw_simple_get() instead of deref dance > > > - Do bailout if the clock-names is not specified > > > - Rollback on error > > > - Folded mfd line change and binding > > > > Why did you do that? > > I thought as the V1 had comments you would have waited for the V2 and as it was > trivial enough, it could be folded and picked up via the clk tree via with your > acked-by. It's *always* a good idea to keep patches subsystem orthogonal if at all possible. > I realize it was not a good idea. > > Do you want to drop it from your tree or shall I resubmit a V3 without the mfd > change? The latter please. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [next] | [standalone]
| From | Daniel Lezcano <daniel.lezcano@linaro.org> |
|---|---|
| Date | 2017-04-12 14:20 +0200 |
| Message-ID | <tvppF-4l7-31@gated-at.bofh.it> |
| In reply to | #1621905 |
On 12/04/2017 10:00, Lee Jones wrote: > On Tue, 11 Apr 2017, Daniel Lezcano wrote: > >> On Tue, Apr 11, 2017 at 03:06:13PM +0100, Lee Jones wrote: >>> On Sat, 08 Apr 2017, Daniel Lezcano wrote: >>> >>>> The hi655x multi function device is a PMIC providing regulators. >>>> >>>> The PMIC also provides a clock for the WiFi and the Bluetooth, let's implement >>>> this clock in order to add it in the hi655x MFD and allow proper wireless >>>> initialization. >>>> >>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> [ ... ] >> Do you want to drop it from your tree or shall I resubmit a V3 without the mfd >> change? > > The latter please. Ok. What about the DT binding change? -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2017-04-12 15:40 +0200 |
| Message-ID | <tvqF3-51n-3@gated-at.bofh.it> |
| In reply to | #1622070 |
On Wed, 12 Apr 2017, Daniel Lezcano wrote: > On 12/04/2017 10:00, Lee Jones wrote: > > On Tue, 11 Apr 2017, Daniel Lezcano wrote: > > > >> On Tue, Apr 11, 2017 at 03:06:13PM +0100, Lee Jones wrote: > >>> On Sat, 08 Apr 2017, Daniel Lezcano wrote: > >>> > >>>> The hi655x multi function device is a PMIC providing regulators. > >>>> > >>>> The PMIC also provides a clock for the WiFi and the Bluetooth, let's implement > >>>> this clock in order to add it in the hi655x MFD and allow proper wireless > >>>> initialization. > >>>> > >>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > > [ ... ] > > >> Do you want to drop it from your tree or shall I resubmit a V3 without the mfd > >> change? > > > > The latter please. > > Ok. > > What about the DT binding change? If I haven't merged it already, you'll need to re-send that (separately) too. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web