Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1621905

Re: [PATCH V2] clk: hi6220: Add the hi655x's pmic clock

Show all headers | View raw

On Tue, 11 Apr 2017, Daniel Lezcano wrote:

> On Tue, Apr 11, 2017 at 03:06:13PM +0100, Lee Jones wrote:
> > On Sat, 08 Apr 2017, Daniel Lezcano wrote:
> > 
> > > The hi655x multi function device is a PMIC providing regulators.
> > > 
> > > The PMIC also provides a clock for the WiFi and the Bluetooth, let's implement
> > > this clock in order to add it in the hi655x MFD and allow proper wireless
> > > initialization.
> > > 
> > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> > > ---
> > > 
> > > Changelog:
> > > 
> > >  V2:
> > >     - Added COMPILE_TEST option, compiled on x86
> > >     - Removed useless parenthesis
> > >     - Used of_clk_hw_simple_get() instead of deref dance
> > >     - Do bailout if the clock-names is not specified
> > >     - Rollback on error
> > >     - Folded mfd line change and binding
> > 
> > Why did you do that?
> 
> I thought as the V1 had comments you would have waited for the V2 and as it was
> trivial enough, it could be folded and picked up via the clk tree via with your
> acked-by.

It's *always* a good idea to keep patches subsystem orthogonal if
at all possible.

> I realize it was not a good idea.
> 
> Do you want to drop it from your tree or shall I resubmit a V3 without the mfd
> change?

The latter please.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH V2] clk: hi6220: Add the hi655x's pmic clock Lee Jones <lee.jones@linaro.org> - 2017-04-11 16:10 +0200
  Re: [PATCH V2] clk: hi6220: Add the hi655x's pmic clock Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-04-11 23:20 +0200
    Re: [PATCH V2] clk: hi6220: Add the hi655x's pmic clock Lee Jones <lee.jones@linaro.org> - 2017-04-12 10:10 +0200
      Re: [PATCH V2] clk: hi6220: Add the hi655x's pmic clock Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-04-12 14:20 +0200
        Re: [PATCH V2] clk: hi6220: Add the hi655x's pmic clock Lee Jones <lee.jones@linaro.org> - 2017-04-12 15:40 +0200

csiph-web