Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1621706 > unrolled thread
| Started by | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| First post | 2017-04-12 02:10 +0200 |
| Last post | 2017-04-12 03:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] kbuild: Consolidate header generation from ASM offset information Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-12 02:10 +0200
Re: [PATCH] kbuild: Consolidate header generation from ASM offset information Matthias Kaehlcke <mka@chromium.org> - 2017-04-12 03:40 +0200
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2017-04-12 02:10 +0200 |
| Subject | Re: [PATCH] kbuild: Consolidate header generation from ASM offset information |
| Message-ID | <tve1b-5Fq-13@gated-at.bofh.it> |
Hi Matthias,
2017-04-04 4:37 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>:
> Largely redundant code is used in different places to generate C headers
> from offset information extracted from assembly language output.
> Consolidate the code in a Makefile include and use this instead.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Please move sed-y and filechk_offsets to scripts/Makefile.lib .
(You may need to rename sed-y
because arch/xtensa/kernel/Makefile uses this name.)
We see various helpers in scripts/Makefile.lib,
so I do not think we need to create a new file just for this one.
Then, please reuse it from arch/ia64/kernel/Makefile and scripts/mod/Makefile.
Like this:
include/generated/nr-irqs.h: arch/$(SRCARCH)/kernel/nr-irqs.s FORCE
$(call filechk,offsets,__ASM_NR_IRQS_H__)
$(obj)/$(devicetable-offsets-file): $(obj)/devicetable-offsets.s FORCE
$(call filechk,offsets,__DEVICETABLE_OFFSETS_H__)
--
Best Regards
Masahiro Yamada
[toc] | [next] | [standalone]
| From | Matthias Kaehlcke <mka@chromium.org> |
|---|---|
| Date | 2017-04-12 03:40 +0200 |
| Subject | Re: [PATCH] kbuild: Consolidate header generation from ASM offset information |
| Message-ID | <tvfqi-6rL-17@gated-at.bofh.it> |
| In reply to | #1621706 |
Hi Masahiro, El Wed, Apr 12, 2017 at 09:03:28AM +0900 Masahiro Yamada ha dit: > 2017-04-04 4:37 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>: > > Largely redundant code is used in different places to generate C headers > > from offset information extracted from assembly language output. > > Consolidate the code in a Makefile include and use this instead. > > > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > > > Please move sed-y and filechk_offsets to scripts/Makefile.lib . > (You may need to rename sed-y > because arch/xtensa/kernel/Makefile uses this name.) > > > We see various helpers in scripts/Makefile.lib, > so I do not think we need to create a new file just for this one. > > Then, please reuse it from arch/ia64/kernel/Makefile and scripts/mod/Makefile. > Like this: > > include/generated/nr-irqs.h: arch/$(SRCARCH)/kernel/nr-irqs.s FORCE > $(call filechk,offsets,__ASM_NR_IRQS_H__) > > $(obj)/$(devicetable-offsets-file): $(obj)/devicetable-offsets.s FORCE > $(call filechk,offsets,__DEVICETABLE_OFFSETS_H__) Thanks for your comments, I'll rework the patch accordingly. Cheers Matthias
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web