Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1621706

Re: [PATCH] kbuild: Consolidate header generation from ASM offset information

Show all headers | View raw

Hi Matthias,


2017-04-04 4:37 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>:
> Largely redundant code is used in different places to generate C headers
> from offset information extracted from assembly language output.
> Consolidate the code in a Makefile include and use this instead.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>


Please move sed-y and filechk_offsets to scripts/Makefile.lib .
(You may need to rename sed-y
because arch/xtensa/kernel/Makefile uses this name.)


We see various helpers in scripts/Makefile.lib,
so I do not think we need to create a new file just for this one.

Then, please reuse it from arch/ia64/kernel/Makefile and scripts/mod/Makefile.
Like this:

include/generated/nr-irqs.h: arch/$(SRCARCH)/kernel/nr-irqs.s FORCE
        $(call filechk,offsets,__ASM_NR_IRQS_H__)

$(obj)/$(devicetable-offsets-file): $(obj)/devicetable-offsets.s FORCE
        $(call filechk,offsets,__DEVICETABLE_OFFSETS_H__)






-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] kbuild: Consolidate header generation from ASM offset information Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-12 02:10 +0200
  Re: [PATCH] kbuild: Consolidate header generation from ASM offset  information Matthias Kaehlcke <mka@chromium.org> - 2017-04-12 03:40 +0200

csiph-web