Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1623141 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-04-13 18:00 +0200 |
| Last post | 2017-04-14 11:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] x86/boot/e820: remove a redundant self assignment Colin King <colin.king@canonical.com> - 2017-04-13 18:00 +0200
[tip:x86/mm] x86/boot/e820: Remove a redundant self assignment tip-bot for Colin King <tipbot@zytor.com> - 2017-04-14 11:50 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-04-13 18:00 +0200 |
| Subject | [PATCH] x86/boot/e820: remove a redundant self assignment |
| Message-ID | <tvPk6-514-27@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
Remove a redundant self assignment of table->nr_entries, it does
nothing and is an artifact of code simplification re-work.
Detected by CoverityScan, CID#1428450 ("Self assignment")
Fixes: 441ac2f33dd7 ("x86/boot/e820: Simplify e820__update_table()")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
arch/x86/kernel/e820.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
index 6e9b26fa6d05..d78a586ba8dc 100644
--- a/arch/x86/kernel/e820.c
+++ b/arch/x86/kernel/e820.c
@@ -270,7 +270,6 @@ int __init e820__update_table(struct e820_table *table)
if (table->nr_entries < 2)
return -1;
- table->nr_entries = table->nr_entries;
BUG_ON(table->nr_entries > max_nr_entries);
/* Bail out if we find any unreasonable addresses in the map: */
--
2.11.0
[toc] | [next] | [standalone]
| From | tip-bot for Colin King <tipbot@zytor.com> |
|---|---|
| Date | 2017-04-14 11:50 +0200 |
| Subject | [tip:x86/mm] x86/boot/e820: Remove a redundant self assignment |
| Message-ID | <tw61A-7Ud-21@gated-at.bofh.it> |
| In reply to | #1623141 |
Commit-ID: ace2fb5a8b65d6aba530068ea9331f18e10ef565
Gitweb: http://git.kernel.org/tip/ace2fb5a8b65d6aba530068ea9331f18e10ef565
Author: Colin King <colin.king@canonical.com>
AuthorDate: Thu, 13 Apr 2017 16:59:12 +0100
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 14 Apr 2017 11:43:21 +0200
x86/boot/e820: Remove a redundant self assignment
Remove a redundant self assignment of table->nr_entries, it does
nothing and is an artifact of code simplification re-work.
Detected by CoverityScan, CID#1428450 ("Self assignment")
Fixes: 441ac2f33dd7 ("x86/boot/e820: Simplify e820__update_table()")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: kernel-janitors@vger.kernel.org
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Link: http://lkml.kernel.org/r/20170413155912.12078-1-colin.king@canonical.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/kernel/e820.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
index 6e9b26f..d78a586 100644
--- a/arch/x86/kernel/e820.c
+++ b/arch/x86/kernel/e820.c
@@ -270,7 +270,6 @@ int __init e820__update_table(struct e820_table *table)
if (table->nr_entries < 2)
return -1;
- table->nr_entries = table->nr_entries;
BUG_ON(table->nr_entries > max_nr_entries);
/* Bail out if we find any unreasonable addresses in the map: */
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web