Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1623141

[PATCH] x86/boot/e820: remove a redundant self assignment

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

Remove a redundant self assignment of table->nr_entries, it does
nothing and is an artifact of code simplification re-work.

Detected by CoverityScan, CID#1428450 ("Self assignment")

Fixes: 441ac2f33dd7 ("x86/boot/e820: Simplify e820__update_table()")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 arch/x86/kernel/e820.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
index 6e9b26fa6d05..d78a586ba8dc 100644
--- a/arch/x86/kernel/e820.c
+++ b/arch/x86/kernel/e820.c
@@ -270,7 +270,6 @@ int __init e820__update_table(struct e820_table *table)
 	if (table->nr_entries < 2)
 		return -1;
 
-	table->nr_entries = table->nr_entries;
 	BUG_ON(table->nr_entries > max_nr_entries);
 
 	/* Bail out if we find any unreasonable addresses in the map: */
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86/boot/e820: remove a redundant self assignment Colin King <colin.king@canonical.com> - 2017-04-13 18:00 +0200
  [tip:x86/mm] x86/boot/e820: Remove a redundant self assignment tip-bot for Colin King <tipbot@zytor.com> - 2017-04-14 11:50 +0200

csiph-web