Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1620509 > unrolled thread

Re: [PATCH 06/16] regulator: madera-ldo1: LDO1 driver for Cirrus Logic Madera codecs

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 06/16] regulator: madera-ldo1: LDO1 driver for Cirrus  Logic Madera codecs Rob Herring <robh@kernel.org> - 2017-04-10 19:50 +0200
    Re: [PATCH 06/16] regulator: madera-ldo1: LDO1 driver for Cirrus  Logic Madera codecs Mark Brown <broonie@kernel.org> - 2017-04-10 20:20 +0200
      Re: [PATCH 06/16] regulator: madera-ldo1: LDO1 driver for Cirrus  Logic Madera codecs Rob Herring <robh@kernel.org> - 2017-04-11 21:30 +0200
        Re: [PATCH 06/16] regulator: madera-ldo1: LDO1 driver for Cirrus  Logic Madera codecs Mark Brown <broonie@kernel.org> - 2017-04-11 22:10 +0200

#1620509 — Re: [PATCH 06/16] regulator: madera-ldo1: LDO1 driver for Cirrus Logic Madera codecs

On Wed, Apr 05, 2017 at 11:07:54AM +0100, Richard Fitzgerald wrote:
> This patch adds a driver for the internal LDO1 regulator on
> some Cirrus Logic Madera class codecs.
> 
> Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
>  .../devicetree/bindings/regulator/madera-ldo1.txt  |  29 +++

cirrus-madera-ldo1.txt

Or perhaps a subdirectory. We should have done the same for arizona 
bindings.

Same question as Mark. Should this share bindings with arizona? The 
arizona one looks a bit strange, so not sure we'd want to just copy it.

>  MAINTAINERS                                        |   3 +
>  drivers/regulator/Kconfig                          |   8 +
>  drivers/regulator/Makefile                         |   1 +
>  drivers/regulator/madera-ldo1.c                    | 198 +++++++++++++++++++++
>  include/linux/regulator/madera-ldo1.h              |  24 +++
>  6 files changed, 263 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/madera-ldo1.txt
>  create mode 100644 drivers/regulator/madera-ldo1.c
>  create mode 100644 include/linux/regulator/madera-ldo1.h
> 
> diff --git a/Documentation/devicetree/bindings/regulator/madera-ldo1.txt b/Documentation/devicetree/bindings/regulator/madera-ldo1.txt
> new file mode 100644
> index 0000000..688f21d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/madera-ldo1.txt
> @@ -0,0 +1,29 @@
> +Cirrus Logic Madera class audio codecs LDO1 regulator driver
> +
> +Only required if you are using the codec internal LDO1 regulator.
> +This is a subnode of the parent mfd node.
> +
> +See also the core bindings for the parent MFD driver:
> +See Documentation/devicetree/bindings/mfd/madera.txt
> +
> +Required properties:
> +  - compatible :  must be "cirrus,madera-ldo1"
> +  - LDOVDD-supply : Power supply for the LDO1 regulator.
> +
> +  - enable-gpio	: GPIO to use to enable/disable the regulator.

enable-gpios

And define whether active high or low.

> +    As defined in bindings/gpio.txt.
> +
> +Optional subnodes:
> +  Standard regulator bindings as described in bindings/regulator/regulator.txt
> +
> +Example:
> +
> +codec: cs47l85@0 {
> +	compatible = "cirrus,cs47l85";
> +
> +	ldo1 {
> +		compatible = "cirrus,madera-ldo1";
> +		LDOVDD-supply = <&pmic_vdd1>;
> +		enable-gpio = <&gpio 0>;
> +	};
> +};

[toc] | [next] | [standalone]

#1620588

[Multipart message — attachments visible in raw view] — view raw

On Mon, Apr 10, 2017 at 12:49:17PM -0500, Rob Herring wrote:

> Same question as Mark. Should this share bindings with arizona? The 
> arizona one looks a bit strange, so not sure we'd want to just copy it.

In what way?  Other than the -gpios stuff (which would just be a trivial
thing if we wanted to change it)?

[toc] | [prev] | [next] | [standalone]

#1621579

On Mon, Apr 10, 2017 at 1:11 PM, Mark Brown <broonie@kernel.org> wrote:
> On Mon, Apr 10, 2017 at 12:49:17PM -0500, Rob Herring wrote:
>
>> Same question as Mark. Should this share bindings with arizona? The
>> arizona one looks a bit strange, so not sure we'd want to just copy it.
>
> In what way?  Other than the -gpios stuff (which would just be a trivial
> thing if we wanted to change it)?

That's mainly it. It's not clear which node wlf,ldoena goes in either.
In the parent? ldo1?

Rob

[toc] | [prev] | [next] | [standalone]

#1621594

[Multipart message — attachments visible in raw view] — view raw

On Tue, Apr 11, 2017 at 02:20:31PM -0500, Rob Herring wrote:
> On Mon, Apr 10, 2017 at 1:11 PM, Mark Brown <broonie@kernel.org> wrote:

> > In what way?  Other than the -gpios stuff (which would just be a trivial
> > thing if we wanted to change it)?

> That's mainly it.

I don't see that as meaningful or a good reason to duplicate the driver
or the binding, it'd be better to just add the new property and
deprecate the old.

>                   It's not clear which node wlf,ldoena goes in either.
> In the parent? ldo1?

Parent since it's looked up in device context, this is also something
that it seems better to fix in one binding rather than duplicate.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web