Re: [PATCH 06/16] regulator: madera-ldo1: LDO1 driver for Cirrus Logic Madera codecs

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 06/16] regulator: madera-ldo1: LDO1 driver for Cirrus Logic Madera codecs
Date	2017-04-11 22:10 +0200
Message-ID	<tvagV-3eF-11@gated-at.bofh.it> (permalink)
References	<tsQcF-1lq-3@gated-at.bofh.it> <tsQcH-1lq-55@gated-at.bofh.it> <tuLBU-3UP-19@gated-at.bofh.it> <tuM4X-4ll-25@gated-at.bofh.it> <tv9Ee-2L8-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Apr 11, 2017 at 02:20:31PM -0500, Rob Herring wrote:
> On Mon, Apr 10, 2017 at 1:11 PM, Mark Brown <broonie@kernel.org> wrote:

> > In what way?  Other than the -gpios stuff (which would just be a trivial
> > thing if we wanted to change it)?

> That's mainly it.

I don't see that as meaningful or a good reason to duplicate the driver
or the binding, it'd be better to just add the new property and
deprecate the old.

>                   It's not clear which node wlf,ldoena goes in either.
> In the parent? ldo1?

Parent since it's looked up in device context, this is also something
that it seems better to fix in one binding rather than duplicate.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 06/16] regulator: madera-ldo1: LDO1 driver for Cirrus  Logic Madera codecs Rob Herring <robh@kernel.org> - 2017-04-10 19:50 +0200
  Re: [PATCH 06/16] regulator: madera-ldo1: LDO1 driver for Cirrus  Logic Madera codecs Mark Brown <broonie@kernel.org> - 2017-04-10 20:20 +0200
    Re: [PATCH 06/16] regulator: madera-ldo1: LDO1 driver for Cirrus  Logic Madera codecs Rob Herring <robh@kernel.org> - 2017-04-11 21:30 +0200
      Re: [PATCH 06/16] regulator: madera-ldo1: LDO1 driver for Cirrus  Logic Madera codecs Mark Brown <broonie@kernel.org> - 2017-04-11 22:10 +0200

csiph-web