Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1618695 > unrolled thread

[PATCH 4/5] drivers: char: Replace printk with pr_err.

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 4/5] drivers: char: Replace printk with pr_err. Varsha Rao <rvarsha016@gmail.com> - 2017-04-07 13:40 +0200
    Re: [PATCH 4/5] drivers: char: Replace printk with pr_err. Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-07 17:50 +0200

#1618695 — [PATCH 4/5] drivers: char: Replace printk with pr_err.

Replace printk with pr_err to fix the checkpatch issue.

Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
---
 drivers/char/misc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/misc.c b/drivers/char/misc.c
index 1312e29..c9cd1ea 100644
--- a/drivers/char/misc.c
+++ b/drivers/char/misc.c
@@ -294,7 +294,7 @@ static int __init misc_init(void)
 	return 0;
 
 fail_printk:
-	printk("unable to get major %d for misc devices\n", MISC_MAJOR);
+	pr_err("unable to get major %d for misc devices\n", MISC_MAJOR);
 	class_destroy(misc_class);
 fail_remove:
 	if (ret)
-- 
2.9.3

[toc] | [next] | [standalone]

#1618915

On Fri, Apr 07, 2017 at 05:04:06PM +0530, Varsha Rao wrote:
> Replace printk with pr_err to fix the checkpatch issue.
> 
> Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
> ---
>  drivers/char/misc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/misc.c b/drivers/char/misc.c
> index 1312e29..c9cd1ea 100644
> --- a/drivers/char/misc.c
> +++ b/drivers/char/misc.c
> @@ -294,7 +294,7 @@ static int __init misc_init(void)
>  	return 0;
>  
>  fail_printk:
> -	printk("unable to get major %d for misc devices\n", MISC_MAJOR);
> +	pr_err("unable to get major %d for misc devices\n", MISC_MAJOR);

Is pr_fmt properly set to use this?

thanks,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web