Re: [PATCH 4/5] drivers: char: Replace printk with pr_err.

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/5] drivers: char: Replace printk with pr_err.
Date	2017-04-07 17:50 +0200
Message-ID	<ttEj7-G4-7@gated-at.bofh.it> (permalink)
References	<ttApb-6sd-5@gated-at.bofh.it> <ttApb-6sd-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Apr 07, 2017 at 05:04:06PM +0530, Varsha Rao wrote:
> Replace printk with pr_err to fix the checkpatch issue.
> 
> Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
> ---
>  drivers/char/misc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/misc.c b/drivers/char/misc.c
> index 1312e29..c9cd1ea 100644
> --- a/drivers/char/misc.c
> +++ b/drivers/char/misc.c
> @@ -294,7 +294,7 @@ static int __init misc_init(void)
>  	return 0;
>  
>  fail_printk:
> -	printk("unable to get major %d for misc devices\n", MISC_MAJOR);
> +	pr_err("unable to get major %d for misc devices\n", MISC_MAJOR);

Is pr_fmt properly set to use this?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/5] drivers: char: Replace printk with pr_err. Varsha Rao <rvarsha016@gmail.com> - 2017-04-07 13:40 +0200
  Re: [PATCH 4/5] drivers: char: Replace printk with pr_err. Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-07 17:50 +0200

csiph-web