Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1617306 > unrolled thread
| Started by | Valerio Genovese <valerio.click@gmail.com> |
|---|---|
| First post | 2017-04-05 21:30 +0200 |
| Last post | 2017-04-06 23:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] staging: rtl8192u: ieee80211: Fix space required after }. Valerio Genovese <valerio.click@gmail.com> - 2017-04-05 21:30 +0200
Re: [PATCH] staging: rtl8192u: ieee80211: Fix space required after }. Joe Perches <joe@perches.com> - 2017-04-06 02:00 +0200
Re: [PATCH] staging: rtl8192u: ieee80211: Fix space required after }. Valerio G <valerio.click@gmail.com> - 2017-04-06 23:30 +0200
| From | Valerio Genovese <valerio.click@gmail.com> |
|---|---|
| Date | 2017-04-05 21:30 +0200 |
| Subject | [PATCH] staging: rtl8192u: ieee80211: Fix space required after }. |
| Message-ID | <tsYMW-6Ky-19@gated-at.bofh.it> |
This was reported by checkpatch.pl:
ERROR: space required after that close brace '}'
Signed-off-by: Valerio Genovese <valerio.click@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
index 2c398ca..5218f27 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
@@ -31,7 +31,7 @@ typedef union _SEQUENCE_CONTROL{
struct {
u16 FragNum:4;
u16 SeqNum:12;
- }field;
+ } field;
}SEQUENCE_CONTROL, *PSEQUENCE_CONTROL;
typedef union _BA_PARAM_SET {
--
2.7.4
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-04-06 02:00 +0200 |
| Subject | Re: [PATCH] staging: rtl8192u: ieee80211: Fix space required after }. |
| Message-ID | <tt30d-NG-3@gated-at.bofh.it> |
| In reply to | #1617306 |
On Wed, 2017-04-05 at 21:23 +0200, Valerio Genovese wrote:
> This was reported by checkpatch.pl:
> ERROR: space required after that close brace '}'
>
> Signed-off-by: Valerio Genovese <valerio.click@gmail.com>
> ---
> drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
> index 2c398ca..5218f27 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
> @@ -31,7 +31,7 @@ typedef union _SEQUENCE_CONTROL{
> struct {
> u16 FragNum:4;
> u16 SeqNum:12;
> - }field;
> + } field;
> }SEQUENCE_CONTROL, *PSEQUENCE_CONTROL;
What about the one on the next line?
$ ./scripts/checkpatch.pl -f drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h --types=spacing --terse
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:29: WARNING: missing space after union definition
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:34: ERROR: space required after that close brace '}'
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:35: ERROR: space required after that close brace '}'
[toc] | [prev] | [next] | [standalone]
| From | Valerio G <valerio.click@gmail.com> |
|---|---|
| Date | 2017-04-06 23:30 +0200 |
| Message-ID | <ttn8B-6iF-7@gated-at.bofh.it> |
| In reply to | #1617426 |
Hi,
Thanks for the feedback. I re-submitted the patch as v2.
best
Valerio
Il 06/04/2017 01:57, Joe Perches ha scritto:
> On Wed, 2017-04-05 at 21:23 +0200, Valerio Genovese wrote:
>> This was reported by checkpatch.pl:
>> ERROR: space required after that close brace '}'
>>
>> Signed-off-by: Valerio Genovese <valerio.click@gmail.com>
>> ---
>> drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
>> index 2c398ca..5218f27 100644
>> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
>> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
>> @@ -31,7 +31,7 @@ typedef union _SEQUENCE_CONTROL{
>> struct {
>> u16 FragNum:4;
>> u16 SeqNum:12;
>> - }field;
>> + } field;
>> }SEQUENCE_CONTROL, *PSEQUENCE_CONTROL;
>
> What about the one on the next line?
>
> $ ./scripts/checkpatch.pl -f drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h --types=spacing --terse
> drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:29: WARNING: missing space after union definition
> drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:34: ERROR: space required after that close brace '}'
> drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:35: ERROR: space required after that close brace '}'
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web