Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1617426

Re: [PATCH] staging: rtl8192u: ieee80211: Fix space required after }.

Show all headers | View raw

On Wed, 2017-04-05 at 21:23 +0200, Valerio Genovese wrote:
> This was reported by checkpatch.pl:
> ERROR: space required after that close brace '}'
> 
> Signed-off-by: Valerio Genovese <valerio.click@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
> index 2c398ca..5218f27 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
> @@ -31,7 +31,7 @@ typedef union _SEQUENCE_CONTROL{
>  	struct {
>  		u16	FragNum:4;
>  		u16	SeqNum:12;
> -	}field;
> +	} field;
>  }SEQUENCE_CONTROL, *PSEQUENCE_CONTROL;

What about the one on the next line?

$ ./scripts/checkpatch.pl -f drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h --types=spacing --terse
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:29: WARNING: missing space after union definition
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:34: ERROR: space required after that close brace '}'
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:35: ERROR: space required after that close brace '}'

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: rtl8192u: ieee80211: Fix space required after }. Valerio Genovese <valerio.click@gmail.com> - 2017-04-05 21:30 +0200
  Re: [PATCH] staging: rtl8192u: ieee80211: Fix space required after  }. Joe Perches <joe@perches.com> - 2017-04-06 02:00 +0200
    Re: [PATCH] staging: rtl8192u: ieee80211: Fix space required after }. Valerio G <valerio.click@gmail.com> - 2017-04-06 23:30 +0200

csiph-web