Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1615074 > unrolled thread
| Started by | Lee Jones <lee.jones@linaro.org> |
|---|---|
| First post | 2017-04-03 12:30 +0200 |
| Last post | 2017-04-04 05:20 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 2/4] mfd: cpcap: Use handle_reread flag for interrupts Lee Jones <lee.jones@linaro.org> - 2017-04-03 12:30 +0200
Re: [PATCH 2/4] mfd: cpcap: Use handle_reread flag for interrupts Tony Lindgren <tony@atomide.com> - 2017-04-03 16:20 +0200
Re: [PATCH 2/4] mfd: cpcap: Use handle_reread flag for interrupts Lee Jones <lee.jones@linaro.org> - 2017-04-03 16:40 +0200
Re: [PATCH 2/4] mfd: cpcap: Use handle_reread flag for interrupts Tony Lindgren <tony@atomide.com> - 2017-04-04 05:20 +0200
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2017-04-03 12:30 +0200 |
| Subject | Re: [PATCH 2/4] mfd: cpcap: Use handle_reread flag for interrupts |
| Message-ID | <ts7pg-5zy-29@gated-at.bofh.it> |
On Wed, 22 Mar 2017, Tony Lindgren wrote:
> On CPCAP we need to keep reading interrupts until there are no
> more interrupts. Otherwise the PMIC interrupt to the SoC will at
> some point stop toggling. This seems to happen because new CPCAP
> device interrupts show up while we're handling.
>
> Cc: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Marcel Partap <mpartap@gmx.net>
> Cc: Michael Scott <michael.scott@linaro.org>
> Tested-by: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/mfd/motorola-cpcap.c | 3 +++
> 1 file changed, 3 insertions(+)
Applied, thanks.
> diff --git a/drivers/mfd/motorola-cpcap.c b/drivers/mfd/motorola-cpcap.c
> --- a/drivers/mfd/motorola-cpcap.c
> +++ b/drivers/mfd/motorola-cpcap.c
> @@ -71,6 +71,7 @@ static struct regmap_irq_chip cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = {
> .ack_base = CPCAP_REG_MI1,
> .mask_base = CPCAP_REG_MIM1,
> .use_ack = true,
> + .handle_reread = true,
> },
> {
> .name = "cpcap-m2",
> @@ -79,6 +80,7 @@ static struct regmap_irq_chip cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = {
> .ack_base = CPCAP_REG_MI2,
> .mask_base = CPCAP_REG_MIM2,
> .use_ack = true,
> + .handle_reread = true,
> },
> {
> .name = "cpcap1-4",
> @@ -88,6 +90,7 @@ static struct regmap_irq_chip cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = {
> .mask_base = CPCAP_REG_INTM1,
> .type_base = CPCAP_REG_INTS1,
> .use_ack = true,
> + .handle_reread = true,
> },
> };
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
[toc] | [next] | [standalone]
| From | Tony Lindgren <tony@atomide.com> |
|---|---|
| Date | 2017-04-03 16:20 +0200 |
| Message-ID | <tsaZR-7XD-53@gated-at.bofh.it> |
| In reply to | #1615074 |
Hi,
* Lee Jones <lee.jones@linaro.org> [170403 03:23]:
> On Wed, 22 Mar 2017, Tony Lindgren wrote:
>
> > On CPCAP we need to keep reading interrupts until there are no
> > more interrupts. Otherwise the PMIC interrupt to the SoC will at
> > some point stop toggling. This seems to happen because new CPCAP
> > device interrupts show up while we're handling.
> >
> > Cc: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Cc: Marcel Partap <mpartap@gmx.net>
> > Cc: Michael Scott <michael.scott@linaro.org>
> > Tested-by: Sebastian Reichel <sre@kernel.org>
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > ---
> > drivers/mfd/motorola-cpcap.c | 3 +++
> > 1 file changed, 3 insertions(+)
>
> Applied, thanks.
Sorry this one depends on patch 1/4 for .handle_reread. So this
one should be reverted or dropped. That will cause trivial merge
conflicts with patches 2 and 4.
Please let me know if you want me to resend just patches 2 and 4
as patches 1 and 2 need more work.
Regards,
Tony
> > diff --git a/drivers/mfd/motorola-cpcap.c b/drivers/mfd/motorola-cpcap.c
> > --- a/drivers/mfd/motorola-cpcap.c
> > +++ b/drivers/mfd/motorola-cpcap.c
> > @@ -71,6 +71,7 @@ static struct regmap_irq_chip cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = {
> > .ack_base = CPCAP_REG_MI1,
> > .mask_base = CPCAP_REG_MIM1,
> > .use_ack = true,
> > + .handle_reread = true,
> > },
> > {
> > .name = "cpcap-m2",
> > @@ -79,6 +80,7 @@ static struct regmap_irq_chip cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = {
> > .ack_base = CPCAP_REG_MI2,
> > .mask_base = CPCAP_REG_MIM2,
> > .use_ack = true,
> > + .handle_reread = true,
> > },
> > {
> > .name = "cpcap1-4",
> > @@ -88,6 +90,7 @@ static struct regmap_irq_chip cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = {
> > .mask_base = CPCAP_REG_INTM1,
> > .type_base = CPCAP_REG_INTS1,
> > .use_ack = true,
> > + .handle_reread = true,
> > },
> > };
> >
>
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2017-04-03 16:40 +0200 |
| Message-ID | <tsbjc-84l-33@gated-at.bofh.it> |
| In reply to | #1615240 |
On Mon, 03 Apr 2017, Tony Lindgren wrote:
> Hi,
>
> * Lee Jones <lee.jones@linaro.org> [170403 03:23]:
> > On Wed, 22 Mar 2017, Tony Lindgren wrote:
> >
> > > On CPCAP we need to keep reading interrupts until there are no
> > > more interrupts. Otherwise the PMIC interrupt to the SoC will at
> > > some point stop toggling. This seems to happen because new CPCAP
> > > device interrupts show up while we're handling.
> > >
> > > Cc: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> > > Cc: Lee Jones <lee.jones@linaro.org>
> > > Cc: Marcel Partap <mpartap@gmx.net>
> > > Cc: Michael Scott <michael.scott@linaro.org>
> > > Tested-by: Sebastian Reichel <sre@kernel.org>
> > > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > > ---
> > > drivers/mfd/motorola-cpcap.c | 3 +++
> > > 1 file changed, 3 insertions(+)
> >
> > Applied, thanks.
>
> Sorry this one depends on patch 1/4 for .handle_reread. So this
> one should be reverted or dropped. That will cause trivial merge
> conflicts with patches 2 and 4.
>
> Please let me know if you want me to resend just patches 2 and 4
> as patches 1 and 2 need more work.
Yes, I found that out (and replied to the regmap patch).
I'll revert them all for now.
Awaiting a subsequent revision.
> > > diff --git a/drivers/mfd/motorola-cpcap.c b/drivers/mfd/motorola-cpcap.c
> > > --- a/drivers/mfd/motorola-cpcap.c
> > > +++ b/drivers/mfd/motorola-cpcap.c
> > > @@ -71,6 +71,7 @@ static struct regmap_irq_chip cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = {
> > > .ack_base = CPCAP_REG_MI1,
> > > .mask_base = CPCAP_REG_MIM1,
> > > .use_ack = true,
> > > + .handle_reread = true,
> > > },
> > > {
> > > .name = "cpcap-m2",
> > > @@ -79,6 +80,7 @@ static struct regmap_irq_chip cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = {
> > > .ack_base = CPCAP_REG_MI2,
> > > .mask_base = CPCAP_REG_MIM2,
> > > .use_ack = true,
> > > + .handle_reread = true,
> > > },
> > > {
> > > .name = "cpcap1-4",
> > > @@ -88,6 +90,7 @@ static struct regmap_irq_chip cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = {
> > > .mask_base = CPCAP_REG_INTM1,
> > > .type_base = CPCAP_REG_INTS1,
> > > .use_ack = true,
> > > + .handle_reread = true,
> > > },
> > > };
> > >
> >
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [next] | [standalone]
| From | Tony Lindgren <tony@atomide.com> |
|---|---|
| Date | 2017-04-04 05:20 +0200 |
| Message-ID | <tsnaF-7AK-5@gated-at.bofh.it> |
| In reply to | #1615261 |
* Lee Jones <lee.jones@linaro.org> [170403 07:34]: > On Mon, 03 Apr 2017, Tony Lindgren wrote: > > > Hi, > > > > * Lee Jones <lee.jones@linaro.org> [170403 03:23]: > > > On Wed, 22 Mar 2017, Tony Lindgren wrote: > > > > > > > On CPCAP we need to keep reading interrupts until there are no > > > > more interrupts. Otherwise the PMIC interrupt to the SoC will at > > > > some point stop toggling. This seems to happen because new CPCAP > > > > device interrupts show up while we're handling. > > > > > > > > Cc: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> > > > > Cc: Lee Jones <lee.jones@linaro.org> > > > > Cc: Marcel Partap <mpartap@gmx.net> > > > > Cc: Michael Scott <michael.scott@linaro.org> > > > > Tested-by: Sebastian Reichel <sre@kernel.org> > > > > Signed-off-by: Tony Lindgren <tony@atomide.com> > > > > --- > > > > drivers/mfd/motorola-cpcap.c | 3 +++ > > > > 1 file changed, 3 insertions(+) > > > > > > Applied, thanks. > > > > Sorry this one depends on patch 1/4 for .handle_reread. So this > > one should be reverted or dropped. That will cause trivial merge > > conflicts with patches 2 and 4. > > > > Please let me know if you want me to resend just patches 2 and 4 > > as patches 1 and 2 need more work. > > Yes, I found that out (and replied to the regmap patch). > > I'll revert them all for now. OK thanks. > Awaiting a subsequent revision. Sent as "[PATCHv3 0/3] CPCAP PMIC IRQ fix and related changes" with regmap changes dropped as I figured out what the real issue with lost interrupts was :) Regards, Tony
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web