Re: [PATCH 2/4] mfd: cpcap: Use handle_reread flag for interrupts

From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/4] mfd: cpcap: Use handle_reread flag for interrupts
Date	2017-04-04 05:20 +0200
Message-ID	<tsnaF-7AK-5@gated-at.bofh.it> (permalink)
References	<tnS5s-5Vz-27@gated-at.bofh.it> <tnS5u-5Vz-63@gated-at.bofh.it> <ts7pg-5zy-29@gated-at.bofh.it> <tsaZR-7XD-53@gated-at.bofh.it> <tsbjc-84l-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Lee Jones <lee.jones@linaro.org> [170403 07:34]:
> On Mon, 03 Apr 2017, Tony Lindgren wrote:
> 
> > Hi,
> > 
> > * Lee Jones <lee.jones@linaro.org> [170403 03:23]:
> > > On Wed, 22 Mar 2017, Tony Lindgren wrote:
> > > 
> > > > On CPCAP we need to keep reading interrupts until there are no
> > > > more interrupts. Otherwise the PMIC interrupt to the SoC will at
> > > > some point stop toggling. This seems to happen because new CPCAP
> > > > device interrupts show up while we're handling.
> > > > 
> > > > Cc: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> > > > Cc: Lee Jones <lee.jones@linaro.org>
> > > > Cc: Marcel Partap <mpartap@gmx.net>
> > > > Cc: Michael Scott <michael.scott@linaro.org>
> > > > Tested-by: Sebastian Reichel <sre@kernel.org>
> > > > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > > > ---
> > > >  drivers/mfd/motorola-cpcap.c | 3 +++
> > > >  1 file changed, 3 insertions(+)
> > > 
> > > Applied, thanks.
> > 
> > Sorry this one depends on patch 1/4 for .handle_reread. So this
> > one should be reverted or dropped. That will cause trivial merge
> > conflicts with patches 2 and 4.
> > 
> > Please let me know if you want me to resend just patches 2 and 4
> > as patches 1 and 2 need more work.
> 
> Yes, I found that out (and replied to the regmap patch).
> 
> I'll revert them all for now.

OK thanks.

> Awaiting a subsequent revision.

Sent as "[PATCHv3 0/3] CPCAP PMIC IRQ fix and related changes"
with regmap changes dropped as I figured out what the real issue
with lost interrupts was :)

Regards,

Tony

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/4] mfd: cpcap: Use handle_reread flag for interrupts Lee Jones <lee.jones@linaro.org> - 2017-04-03 12:30 +0200
  Re: [PATCH 2/4] mfd: cpcap: Use handle_reread flag for interrupts Tony Lindgren <tony@atomide.com> - 2017-04-03 16:20 +0200
    Re: [PATCH 2/4] mfd: cpcap: Use handle_reread flag for interrupts Lee Jones <lee.jones@linaro.org> - 2017-04-03 16:40 +0200
      Re: [PATCH 2/4] mfd: cpcap: Use handle_reread flag for interrupts Tony Lindgren <tony@atomide.com> - 2017-04-04 05:20 +0200

csiph-web