Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1614796 > unrolled thread

Re: [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units

Started byAndy Shevchenko <andy.shevchenko@gmail.com>
First post2017-04-02 22:20 +0200
Last post2017-04-04 14:20 +0200
Articles 9 — 4 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-02 22:20 +0200
    Re: [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation  units Lee Jones <lee.jones@linaro.org> - 2017-04-03 11:30 +0200
      Re: [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-03 11:30 +0200
        Re: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with  compilation units Fengguang Wu <lkp@intel.com> - 2017-04-03 13:10 +0200
          Re: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with  compilation units Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-03 13:20 +0200
            Re: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with  compilation units Lee Jones <lee.jones@linaro.org> - 2017-04-03 16:40 +0200
              Re: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess  with compilation units Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-04-03 16:50 +0200
                Re: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with  compilation units Lee Jones <lee.jones@linaro.org> - 2017-04-04 10:50 +0200
                  Re: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess  with compilation units Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-04-04 14:20 +0200

#1614796 — Re: [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2017-04-02 22:20 +0200
SubjectRe: [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units
Message-ID<trU8F-5eX-3@gated-at.bofh.it>
On Sun, Apr 2, 2017 at 11:03 PM, kbuild test robot <lkp@intel.com> wrote:
> Hi Andy,
>
> [auto build test ERROR on ljones-mfd/for-mfd-next]
> [also build test ERROR on v4.11-rc4 next-20170331]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

Thank you for report, though...

>
> url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/mfd-intel_soc_pmic-Fix-a-mess-with-compilation-units/20170320-153539
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
> config: tile-allyesconfig (attached as .config)
> compiler: tilegx-linux-gcc (GCC) 4.6.2
> reproduce:
>         wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree

>         make.cross ARCH=tile

...I doubt how below is related to my patch. This is obvious x86 code
which was initially submitted without
depend on X86
line in corresponding Kconfig.

>
> All errors (new ones prefixed by >>):
>
>>> drivers/mfd/intel_soc_pmic_bxtwc.c:24:31: fatal error: asm/intel_pmc_ipc.h: No such file or directory
>    compilation terminated.
>
> vim +24 drivers/mfd/intel_soc_pmic_bxtwc.c
>
> 39d047c0 Qipeng Zha 2015-09-15   8   * version 2, as published by the Free Software Foundation.
> 39d047c0 Qipeng Zha 2015-09-15   9   *
> 39d047c0 Qipeng Zha 2015-09-15  10   * This program is distributed in the hope it will be useful, but WITHOUT
> 39d047c0 Qipeng Zha 2015-09-15  11   * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> 39d047c0 Qipeng Zha 2015-09-15  12   * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> 39d047c0 Qipeng Zha 2015-09-15  13   * more details.
> 39d047c0 Qipeng Zha 2015-09-15  14   */
> 39d047c0 Qipeng Zha 2015-09-15  15
> 39d047c0 Qipeng Zha 2015-09-15  16  #include <linux/module.h>
> 39d047c0 Qipeng Zha 2015-09-15  17  #include <linux/acpi.h>
> 39d047c0 Qipeng Zha 2015-09-15  18  #include <linux/err.h>
> 39d047c0 Qipeng Zha 2015-09-15  19  #include <linux/delay.h>
> 39d047c0 Qipeng Zha 2015-09-15  20  #include <linux/interrupt.h>
> 39d047c0 Qipeng Zha 2015-09-15  21  #include <linux/kernel.h>
> 39d047c0 Qipeng Zha 2015-09-15  22  #include <linux/mfd/core.h>
> 39d047c0 Qipeng Zha 2015-09-15  23  #include <linux/mfd/intel_bxtwc.h>
> 39d047c0 Qipeng Zha 2015-09-15 @24  #include <asm/intel_pmc_ipc.h>
> 39d047c0 Qipeng Zha 2015-09-15  25
> 39d047c0 Qipeng Zha 2015-09-15  26  /* PMIC device registers */
> 39d047c0 Qipeng Zha 2015-09-15  27  #define REG_ADDR_MASK               0xFF00
> 39d047c0 Qipeng Zha 2015-09-15  28  #define REG_ADDR_SHIFT              8
> 39d047c0 Qipeng Zha 2015-09-15  29  #define REG_OFFSET_MASK             0xFF
> 39d047c0 Qipeng Zha 2015-09-15  30
> 39d047c0 Qipeng Zha 2015-09-15  31  /* Interrupt Status Registers */
> 39d047c0 Qipeng Zha 2015-09-15  32  #define BXTWC_IRQLVL1               0x4E02
>
> :::::: The code at line 24 was first introduced by commit
> :::::: 39d047c0b1c812e9f0014e7100e372e61f2de3de mfd: add Intel Broxton Whiskey Cove PMIC driver
>
> :::::: TO: Qipeng Zha <qipeng.zha@intel.com>
> :::::: CC: Lee Jones <lee.jones@linaro.org>
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation



-- 
With Best Regards,
Andy Shevchenko

[toc] | [next] | [standalone]

#1615015 — Re: [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units

FromLee Jones <lee.jones@linaro.org>
Date2017-04-03 11:30 +0200
SubjectRe: [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units
Message-ID<ts6tb-4ZD-7@gated-at.bofh.it>
In reply to#1614796
On Sun, 02 Apr 2017, Andy Shevchenko wrote:

> On Sun, Apr 2, 2017 at 11:03 PM, kbuild test robot <lkp@intel.com> wrote:
> > Hi Andy,
> >
> > [auto build test ERROR on ljones-mfd/for-mfd-next]
> > [also build test ERROR on v4.11-rc4 next-20170331]
> > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> Thank you for report, though...
> 
> >
> > url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/mfd-intel_soc_pmic-Fix-a-mess-with-compilation-units/20170320-153539
> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
> > config: tile-allyesconfig (attached as .config)
> > compiler: tilegx-linux-gcc (GCC) 4.6.2
> > reproduce:
> >         wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # save the attached .config to linux build tree
> 
> >         make.cross ARCH=tile
> 
> ...I doubt how below is related to my patch. This is obvious x86 code
> which was initially submitted without
> depend on X86
> line in corresponding Kconfig.

I think you should probably specify the architecture in the Kconfig
entry, or else some `randconfig`s will fail.

> > All errors (new ones prefixed by >>):
> >
> >>> drivers/mfd/intel_soc_pmic_bxtwc.c:24:31: fatal error: asm/intel_pmc_ipc.h: No such file or directory
> >    compilation terminated.
> >
> > vim +24 drivers/mfd/intel_soc_pmic_bxtwc.c
> >
> > 39d047c0 Qipeng Zha 2015-09-15   8   * version 2, as published by the Free Software Foundation.
> > 39d047c0 Qipeng Zha 2015-09-15   9   *
> > 39d047c0 Qipeng Zha 2015-09-15  10   * This program is distributed in the hope it will be useful, but WITHOUT
> > 39d047c0 Qipeng Zha 2015-09-15  11   * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> > 39d047c0 Qipeng Zha 2015-09-15  12   * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> > 39d047c0 Qipeng Zha 2015-09-15  13   * more details.
> > 39d047c0 Qipeng Zha 2015-09-15  14   */
> > 39d047c0 Qipeng Zha 2015-09-15  15
> > 39d047c0 Qipeng Zha 2015-09-15  16  #include <linux/module.h>
> > 39d047c0 Qipeng Zha 2015-09-15  17  #include <linux/acpi.h>
> > 39d047c0 Qipeng Zha 2015-09-15  18  #include <linux/err.h>
> > 39d047c0 Qipeng Zha 2015-09-15  19  #include <linux/delay.h>
> > 39d047c0 Qipeng Zha 2015-09-15  20  #include <linux/interrupt.h>
> > 39d047c0 Qipeng Zha 2015-09-15  21  #include <linux/kernel.h>
> > 39d047c0 Qipeng Zha 2015-09-15  22  #include <linux/mfd/core.h>
> > 39d047c0 Qipeng Zha 2015-09-15  23  #include <linux/mfd/intel_bxtwc.h>
> > 39d047c0 Qipeng Zha 2015-09-15 @24  #include <asm/intel_pmc_ipc.h>
> > 39d047c0 Qipeng Zha 2015-09-15  25
> > 39d047c0 Qipeng Zha 2015-09-15  26  /* PMIC device registers */
> > 39d047c0 Qipeng Zha 2015-09-15  27  #define REG_ADDR_MASK               0xFF00
> > 39d047c0 Qipeng Zha 2015-09-15  28  #define REG_ADDR_SHIFT              8
> > 39d047c0 Qipeng Zha 2015-09-15  29  #define REG_OFFSET_MASK             0xFF
> > 39d047c0 Qipeng Zha 2015-09-15  30
> > 39d047c0 Qipeng Zha 2015-09-15  31  /* Interrupt Status Registers */
> > 39d047c0 Qipeng Zha 2015-09-15  32  #define BXTWC_IRQLVL1               0x4E02
> >
> > :::::: The code at line 24 was first introduced by commit
> > :::::: 39d047c0b1c812e9f0014e7100e372e61f2de3de mfd: add Intel Broxton Whiskey Cove PMIC driver
> >
> > :::::: TO: Qipeng Zha <qipeng.zha@intel.com>
> > :::::: CC: Lee Jones <lee.jones@linaro.org>
> >
> > ---
> > 0-DAY kernel test infrastructure                Open Source Technology Center
> > https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> 
> 
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [next] | [standalone]

#1615023

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2017-04-03 11:30 +0200
Message-ID<ts6tc-4ZD-25@gated-at.bofh.it>
In reply to#1615015
On Mon, Apr 3, 2017 at 12:20 PM, Lee Jones <lee.jones@linaro.org> wrote:
> On Sun, 02 Apr 2017, Andy Shevchenko wrote:
>
>> On Sun, Apr 2, 2017 at 11:03 PM, kbuild test robot <lkp@intel.com> wrote:
>> > Hi Andy,
>> >
>> > [auto build test ERROR on ljones-mfd/for-mfd-next]
>> > [also build test ERROR on v4.11-rc4 next-20170331]
>> > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>>
>> Thank you for report, though...
>>
>> >
>> > url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/mfd-intel_soc_pmic-Fix-a-mess-with-compilation-units/20170320-153539
>> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
>> > config: tile-allyesconfig (attached as .config)
>> > compiler: tilegx-linux-gcc (GCC) 4.6.2
>> > reproduce:
>> >         wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>> >         chmod +x ~/bin/make.cross
>> >         # save the attached .config to linux build tree
>>
>> >         make.cross ARCH=tile
>>
>> ...I doubt how below is related to my patch. This is obvious x86 code
>> which was initially submitted without
>> depend on X86
>> line in corresponding Kconfig.
>
> I think you should probably specify the architecture in the Kconfig
> entry, or else some `randconfig`s will fail.

Yes, I understand how to fix this, though it's not a problem of this
patch per se.

Fengguang, is there any possible way to determine the relation between
an error and a root cause change?

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1615101 — Re: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units

FromFengguang Wu <lkp@intel.com>
Date2017-04-03 13:10 +0200
SubjectRe: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units
Message-ID<ts81Z-63x-39@gated-at.bofh.it>
In reply to#1615023
On Mon, Apr 03, 2017 at 12:26:54PM +0300, Andy Shevchenko wrote:
>On Mon, Apr 3, 2017 at 12:20 PM, Lee Jones <lee.jones@linaro.org> wrote:
>> On Sun, 02 Apr 2017, Andy Shevchenko wrote:
>>
>>> On Sun, Apr 2, 2017 at 11:03 PM, kbuild test robot <lkp@intel.com> wrote:
>>> > Hi Andy,
>>> >
>>> > [auto build test ERROR on ljones-mfd/for-mfd-next]
>>> > [also build test ERROR on v4.11-rc4 next-20170331]
>>> > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>>>
>>> Thank you for report, though...
>>>
>>> >
>>> > url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/mfd-intel_soc_pmic-Fix-a-mess-with-compilation-units/20170320-153539
>>> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
>>> > config: tile-allyesconfig (attached as .config)
>>> > compiler: tilegx-linux-gcc (GCC) 4.6.2
>>> > reproduce:
>>> >         wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>> >         chmod +x ~/bin/make.cross
>>> >         # save the attached .config to linux build tree
>>>
>>> >         make.cross ARCH=tile
>>>
>>> ...I doubt how below is related to my patch. This is obvious x86 code
>>> which was initially submitted without
>>> depend on X86
>>> line in corresponding Kconfig.
>>
>> I think you should probably specify the architecture in the Kconfig
>> entry, or else some `randconfig`s will fail.
>
>Yes, I understand how to fix this, though it's not a problem of this
>patch per se.
>
>Fengguang, is there any possible way to determine the relation between
>an error and a root cause change?

Andy, our 0day build error reports are all bisected ones. It means the
error happens since the reported patch/commit, which is either
responsible for the root cause, or somehow triggers (or changes the
exact form of) an old bug.

I just manual confirmed the bisect is correct:

=============== commit 162c61d1a ===============
/home/wfg/linux
HEAD is now at 162c61d... mfd: intel_soc_pmic: Fix a mess with compilation units
/home/wfg/linux/obj-compiletest

make ARCH=tile allyesconfig
make ARCH=tile drivers/mfd/

!!! BUILD ERROR !!!
make ARCH=tile M=drivers/mfd/

!!! BUILD ERROR !!!
grep -a -F drivers/mfd/ /tmp/build-err-162c61d1a76aa5ccfb398225b3f6f2e896fb58b0-wfg --color
../drivers/mfd/intel_soc_pmic_bxtwc.c:24:31: fatal error: asm/intel_pmc_ipc.h: No such file or directory
compilation terminated.
make[2]: *** [drivers/mfd/intel_soc_pmic_bxtwc.o] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [drivers/mfd/] Error 2
make: *** [sub-make] Error 2
make[2]: *** No rule to make target 'drivers/mfd//intel_soc_pmic_bxtwc.o', needed by 'drivers/mfd//built-in.o'.
make[2]: Target '__build' not remade because of errors.
make[1]: *** [_module_drivers/mfd/] Error 2
make[1]: Target '_all' not remade because of errors.
make: *** [sub-make] Error 2

=============== PREV commit e93c10211d03c35271896b03a40d3eca4a674770 ===============
/home/wfg/linux
Previous HEAD position was 162c61d... mfd: intel_soc_pmic: Fix a mess with compilation units
HEAD is now at e93c102... mfd: lpc_ich: Enable watchdog on Intel Apollo Lake PCH
/home/wfg/linux/obj-compiletest

make ARCH=tile allyesconfig
make ARCH=tile drivers/mfd/

make ARCH=tile M=drivers/mfd/

grep -a -F drivers/mfd/ /tmp/build-err-e93c10211d03c35271896b03a40d3eca4a674770-wfg --color

Thanks,
Fengguang

[toc] | [prev] | [next] | [standalone]

#1615109 — Re: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2017-04-03 13:20 +0200
SubjectRe: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units
Message-ID<ts8bE-66S-13@gated-at.bofh.it>
In reply to#1615101
On Mon, Apr 3, 2017 at 2:06 PM, Fengguang Wu <lkp@intel.com> wrote:
> On Mon, Apr 03, 2017 at 12:26:54PM +0300, Andy Shevchenko wrote:
>> On Mon, Apr 3, 2017 at 12:20 PM, Lee Jones <lee.jones@linaro.org> wrote:
>>> On Sun, 02 Apr 2017, Andy Shevchenko wrote:
>>>> On Sun, Apr 2, 2017 at 11:03 PM, kbuild test robot <lkp@intel.com>
>>>> wrote:
>>>> > Hi Andy,
>>>> >
>>>> > [auto build test ERROR on ljones-mfd/for-mfd-next]
>>>> > [also build test ERROR on v4.11-rc4 next-20170331]
>>>> > [if your patch is applied to the wrong git tree, please drop us a note
>>>> > to help improve the system]
>>>>
>>>> Thank you for report, though...

>>>> ...I doubt how below is related to my patch. This is obvious x86 code
>>>> which was initially submitted without
>>>> depend on X86
>>>> line in corresponding Kconfig.
>>>
>>>
>>> I think you should probably specify the architecture in the Kconfig
>>> entry, or else some `randconfig`s will fail.
>>
>>
>> Yes, I understand how to fix this, though it's not a problem of this
>> patch per se.
>>
>> Fengguang, is there any possible way to determine the relation between
>> an error and a root cause change?
>
>
> Andy, our 0day build error reports are all bisected ones. It means the
> error happens since the reported patch/commit, which is either
> responsible for the root cause, or somehow triggers (or changes the
> exact form of) an old bug.

Thanks, like you said in this case it looks pretty much for triggering
an old bug.

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1615258 — Re: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units

FromLee Jones <lee.jones@linaro.org>
Date2017-04-03 16:40 +0200
SubjectRe: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units
Message-ID<tsbjc-84l-19@gated-at.bofh.it>
In reply to#1615109
On Mon, 03 Apr 2017, Andy Shevchenko wrote:

> On Mon, Apr 3, 2017 at 2:06 PM, Fengguang Wu <lkp@intel.com> wrote:
> > On Mon, Apr 03, 2017 at 12:26:54PM +0300, Andy Shevchenko wrote:
> >> On Mon, Apr 3, 2017 at 12:20 PM, Lee Jones <lee.jones@linaro.org> wrote:
> >>> On Sun, 02 Apr 2017, Andy Shevchenko wrote:
> >>>> On Sun, Apr 2, 2017 at 11:03 PM, kbuild test robot <lkp@intel.com>
> >>>> wrote:
> >>>> > Hi Andy,
> >>>> >
> >>>> > [auto build test ERROR on ljones-mfd/for-mfd-next]
> >>>> > [also build test ERROR on v4.11-rc4 next-20170331]
> >>>> > [if your patch is applied to the wrong git tree, please drop us a note
> >>>> > to help improve the system]
> >>>>
> >>>> Thank you for report, though...
> 
> >>>> ...I doubt how below is related to my patch. This is obvious x86 code
> >>>> which was initially submitted without
> >>>> depend on X86
> >>>> line in corresponding Kconfig.
> >>>
> >>>
> >>> I think you should probably specify the architecture in the Kconfig
> >>> entry, or else some `randconfig`s will fail.
> >>
> >>
> >> Yes, I understand how to fix this, though it's not a problem of this
> >> patch per se.
> >>
> >> Fengguang, is there any possible way to determine the relation between
> >> an error and a root cause change?
> >
> >
> > Andy, our 0day build error reports are all bisected ones. It means the
> > error happens since the reported patch/commit, which is either
> > responsible for the root cause, or somehow triggers (or changes the
> > exact form of) an old bug.
> 
> Thanks, like you said in this case it looks pretty much for triggering
> an old bug.

Quite.  But as a good open source citizen, you'll follow up with
patches too, right? :)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [next] | [standalone]

#1615276 — Re: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units

FromAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Date2017-04-03 16:50 +0200
SubjectRe: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units
Message-ID<tsbsS-89y-29@gated-at.bofh.it>
In reply to#1615258
On Mon, 2017-04-03 at 15:33 +0100, Lee Jones wrote:
> On Mon, 03 Apr 2017, Andy Shevchenko wrote:
> 
> > On Mon, Apr 3, 2017 at 2:06 PM, Fengguang Wu <lkp@intel.com> wrote:
> > > On Mon, Apr 03, 2017 at 12:26:54PM +0300, Andy Shevchenko wrote:
> > > > On Mon, Apr 3, 2017 at 12:20 PM, Lee Jones <lee.jones@linaro.org
> > > > > wrote:
> > > > > On Sun, 02 Apr 2017, Andy Shevchenko wrote:
> > > > > > On Sun, Apr 2, 2017 at 11:03 PM, kbuild test robot <lkp@inte
> > > > > > l.com>
> > > > > > wrote:

> > > > Yes, I understand how to fix this, though it's not a problem of
> > > > this
> > > > patch per se.
> > > > 
> > > > Fengguang, is there any possible way to determine the relation
> > > > between
> > > > an error and a root cause change?
> > > 
> > > 
> > > Andy, our 0day build error reports are all bisected ones. It means
> > > the
> > > error happens since the reported patch/commit, which is either
> > > responsible for the root cause, or somehow triggers (or changes
> > > the
> > > exact form of) an old bug.
> > 
> > Thanks, like you said in this case it looks pretty much for
> > triggering
> > an old bug.
> 
> Quite.  But as a good open source citizen, you'll follow up with
> patches too, right? :)

It looks like I have to submit fix for older bug first. Likely I can do
this without delays and give you a green light to apply via your tree.
Unfortunately I will continue on this tomorrow.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

[toc] | [prev] | [next] | [standalone]

#1615794 — Re: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units

FromLee Jones <lee.jones@linaro.org>
Date2017-04-04 10:50 +0200
SubjectRe: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units
Message-ID<tssk1-2s8-7@gated-at.bofh.it>
In reply to#1615276
On Mon, 03 Apr 2017, Andy Shevchenko wrote:

> On Mon, 2017-04-03 at 15:33 +0100, Lee Jones wrote:
> > On Mon, 03 Apr 2017, Andy Shevchenko wrote:
> > 
> > > On Mon, Apr 3, 2017 at 2:06 PM, Fengguang Wu <lkp@intel.com> wrote:
> > > > On Mon, Apr 03, 2017 at 12:26:54PM +0300, Andy Shevchenko wrote:
> > > > > On Mon, Apr 3, 2017 at 12:20 PM, Lee Jones <lee.jones@linaro.org
> > > > > > wrote:
> > > > > > On Sun, 02 Apr 2017, Andy Shevchenko wrote:
> > > > > > > On Sun, Apr 2, 2017 at 11:03 PM, kbuild test robot <lkp@inte
> > > > > > > l.com>
> > > > > > > wrote:
> 
> > > > > Yes, I understand how to fix this, though it's not a problem of
> > > > > this
> > > > > patch per se.
> > > > > 
> > > > > Fengguang, is there any possible way to determine the relation
> > > > > between
> > > > > an error and a root cause change?
> > > > 
> > > > 
> > > > Andy, our 0day build error reports are all bisected ones. It means
> > > > the
> > > > error happens since the reported patch/commit, which is either
> > > > responsible for the root cause, or somehow triggers (or changes
> > > > the
> > > > exact form of) an old bug.
> > > 
> > > Thanks, like you said in this case it looks pretty much for
> > > triggering
> > > an old bug.
> > 
> > Quite.  But as a good open source citizen, you'll follow up with
> > patches too, right? :)
> 
> It looks like I have to submit fix for older bug first. Likely I can do
> this without delays and give you a green light to apply via your tree.
> Unfortunately I will continue on this tomorrow.

Turns out that this is not an older bug.

You need to fix your patch.  I believe you lose the depend on
INTEL_PMC_IPC, which ensures it's only built on x86 systems.

NB: I discovered this after a 20 second scan, so it might not be the
correct fix.  Please investigate.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [next] | [standalone]

#1615951 — Re: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units

FromAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Date2017-04-04 14:20 +0200
SubjectRe: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units
Message-ID<tsvBg-4KM-17@gated-at.bofh.it>
In reply to#1615794
On Tue, 2017-04-04 at 09:41 +0100, Lee Jones wrote:
> On Mon, 03 Apr 2017, Andy Shevchenko wrote:
> 
> > On Mon, 2017-04-03 at 15:33 +0100, Lee Jones wrote:
> > > On Mon, 03 Apr 2017, Andy Shevchenko wrote:
> > > 
> > > > On Mon, Apr 3, 2017 at 2:06 PM, Fengguang Wu <lkp@intel.com>
> > > > wrote:
> > > > > On Mon, Apr 03, 2017 at 12:26:54PM +0300, Andy Shevchenko
> > > > > wrote:
> > > > > > On Mon, Apr 3, 2017 at 12:20 PM, Lee Jones <lee.jones@linaro
> > > > > > .org
> > > > > > > wrote:
> > > > > > > On Sun, 02 Apr 2017, Andy Shevchenko wrote:
> > > > > > > > On Sun, Apr 2, 2017 at 11:03 PM, kbuild test robot <lkp@
> > > > > > > > inte
> > > > > > > > l.com>
> > > > > > > > wrote:

> > > > > > It looks like I have to submit fix for older bug first.
> > > > > > Likely I can do
> > this without delays and give you a green light to apply via your
> > tree.
> > Unfortunately I will continue on this tomorrow.
> 
> Turns out that this is not an older bug.
> 
> You need to fix your patch.  I believe you lose the depend on
> INTEL_PMC_IPC, which ensures it's only built on x86 systems.
> 
> NB: I discovered this after a 20 second scan, so it might not be the
> correct fix.  Please investigate.

Oh my gosh, I was looking to older version of the patch which does a
select and thus I was quite sure that that triggers an old bug.

Thank you everyone who raised concern.

P.S. Certainly need a vacation...

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web