Re: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units

From	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units
Date	2017-04-04 14:20 +0200
Message-ID	<tsvBg-4KM-17@gated-at.bofh.it> (permalink)
References	(5 earlier) <ts81Z-63x-39@gated-at.bofh.it> <ts8bE-66S-13@gated-at.bofh.it> <tsbjc-84l-19@gated-at.bofh.it> <tsbsS-89y-29@gated-at.bofh.it> <tssk1-2s8-7@gated-at.bofh.it>
Organization	Intel Finland Oy

Show all headers | View raw

On Tue, 2017-04-04 at 09:41 +0100, Lee Jones wrote:
> On Mon, 03 Apr 2017, Andy Shevchenko wrote:
> 
> > On Mon, 2017-04-03 at 15:33 +0100, Lee Jones wrote:
> > > On Mon, 03 Apr 2017, Andy Shevchenko wrote:
> > > 
> > > > On Mon, Apr 3, 2017 at 2:06 PM, Fengguang Wu <lkp@intel.com>
> > > > wrote:
> > > > > On Mon, Apr 03, 2017 at 12:26:54PM +0300, Andy Shevchenko
> > > > > wrote:
> > > > > > On Mon, Apr 3, 2017 at 12:20 PM, Lee Jones <lee.jones@linaro
> > > > > > .org
> > > > > > > wrote:
> > > > > > > On Sun, 02 Apr 2017, Andy Shevchenko wrote:
> > > > > > > > On Sun, Apr 2, 2017 at 11:03 PM, kbuild test robot <lkp@
> > > > > > > > inte
> > > > > > > > l.com>
> > > > > > > > wrote:

> > > > > > It looks like I have to submit fix for older bug first.
> > > > > > Likely I can do
> > this without delays and give you a green light to apply via your
> > tree.
> > Unfortunately I will continue on this tomorrow.
> 
> Turns out that this is not an older bug.
> 
> You need to fix your patch.  I believe you lose the depend on
> INTEL_PMC_IPC, which ensures it's only built on x86 systems.
> 
> NB: I discovered this after a 20 second scan, so it might not be the
> correct fix.  Please investigate.

Oh my gosh, I was looking to older version of the patch which does a
select and thus I was quite sure that that triggers an old bug.

Thank you everyone who raised concern.

P.S. Certainly need a vacation...

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-02 22:20 +0200
  Re: [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation  units Lee Jones <lee.jones@linaro.org> - 2017-04-03 11:30 +0200
    Re: [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-03 11:30 +0200
      Re: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with  compilation units Fengguang Wu <lkp@intel.com> - 2017-04-03 13:10 +0200
        Re: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with  compilation units Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-03 13:20 +0200
          Re: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with  compilation units Lee Jones <lee.jones@linaro.org> - 2017-04-03 16:40 +0200
            Re: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess  with compilation units Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-04-03 16:50 +0200
              Re: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with  compilation units Lee Jones <lee.jones@linaro.org> - 2017-04-04 10:50 +0200
                Re: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess  with compilation units Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-04-04 14:20 +0200

csiph-web