Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1613829 > unrolled thread
| Started by | Chewie Lin <linsh@oregonstate.edu> |
|---|---|
| First post | 2017-03-31 12:10 +0200 |
| Last post | 2017-03-31 14:40 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] Eudyptula challenge Chewie Lin <linsh@oregonstate.edu> - 2017-03-31 12:10 +0200
[PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning Chewie Lin <linsh@oregonstate.edu> - 2017-03-31 12:10 +0200
Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning Kim Phillips <kim.phillips@arm.com> - 2017-03-31 12:40 +0200
Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning Greg KH <greg@kroah.com> - 2017-03-31 14:40 +0200
| From | Chewie Lin <linsh@oregonstate.edu> |
|---|---|
| Date | 2017-03-31 12:10 +0200 |
| Subject | [PATCH] Eudyptula challenge |
| Message-ID | <tr1Ff-3db-1@gated-at.bofh.it> |
Hi greg k-h and forest: Sorry about all the spam I've been sending earlier. One more try. I'm submitting this patch as part of Eudyptula challenge to fix a coding style problem. Thanks for taking time on this trivial patch. sl424 Chewie Lin (1): fixed a checkpatch warning drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.10.0
[toc] | [next] | [standalone]
| From | Chewie Lin <linsh@oregonstate.edu> |
|---|---|
| Date | 2017-03-31 12:10 +0200 |
| Subject | [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning |
| Message-ID | <tr1Fg-3db-11@gated-at.bofh.it> |
| In reply to | #1613829 |
fix a checkpatch warning: WARNING: Prefer using "%s", __func__ to embedded function names Signed-off-by: Chewie Lin <linsh@oregonstate.edu> --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index 9e074e9..2d9e7af 100644 --- a/drivers/staging/vt6656/main_usb.c +++ b/drivers/staging/vt6656/main_usb.c @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) status = usb_reset_device(priv->usb); if (status) dev_warn(&priv->usb->dev, - "usb_device_reset fail status=%d\n", status); + "%s=%d\n", "usb_device_reset fail status", status); } static void vnt_free_int_bufs(struct vnt_private *priv) -- 2.10.0
[toc] | [prev] | [next] | [standalone]
| From | Kim Phillips <kim.phillips@arm.com> |
|---|---|
| Date | 2017-03-31 12:40 +0200 |
| Subject | Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning |
| Message-ID | <tr28i-3pV-5@gated-at.bofh.it> |
| In reply to | #1613830 |
On Fri, 31 Mar 2017 03:01:12 -0700 Chewie Lin <linsh@oregonstate.edu> wrote: > fix a checkpatch warning: > WARNING: Prefer using "%s", __func__ to embedded function names __func__, so: > - "usb_device_reset fail status=%d\n", status); > + "%s=%d\n", "usb_device_reset fail status", status); "%s=%d\n", __func__ " fail status", status); ? Kim
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <greg@kroah.com> |
|---|---|
| Date | 2017-03-31 14:40 +0200 |
| Subject | Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning |
| Message-ID | <tr40p-4Bg-1@gated-at.bofh.it> |
| In reply to | #1613830 |
On Fri, Mar 31, 2017 at 03:01:12AM -0700, Chewie Lin wrote: > fix a checkpatch warning: > WARNING: Prefer using "%s", __func__ to embedded function names > > Signed-off-by: Chewie Lin <linsh@oregonstate.edu> > --- > drivers/staging/vt6656/main_usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c > index 9e074e9..2d9e7af 100644 > --- a/drivers/staging/vt6656/main_usb.c > +++ b/drivers/staging/vt6656/main_usb.c > @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) > status = usb_reset_device(priv->usb); > if (status) > dev_warn(&priv->usb->dev, > - "usb_device_reset fail status=%d\n", status); > + "%s=%d\n", "usb_device_reset fail status", status); Your patch does not match your description at all :(
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web