Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning

From	Greg KH <greg@kroah.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning
Date	2017-03-31 14:40 +0200
Message-ID	<tr40p-4Bg-1@gated-at.bofh.it> (permalink)
References	<tr1Ff-3db-1@gated-at.bofh.it> <tr1Fg-3db-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Mar 31, 2017 at 03:01:12AM -0700, Chewie Lin wrote:
> fix a checkpatch warning:
> WARNING: Prefer using "%s", __func__ to embedded function names
> 
> Signed-off-by: Chewie Lin <linsh@oregonstate.edu>
> ---
>  drivers/staging/vt6656/main_usb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
> index 9e074e9..2d9e7af 100644
> --- a/drivers/staging/vt6656/main_usb.c
> +++ b/drivers/staging/vt6656/main_usb.c
> @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv)
>  	status = usb_reset_device(priv->usb);
>  	if (status)
>  		dev_warn(&priv->usb->dev,
> -			 "usb_device_reset fail status=%d\n", status);
> +			 "%s=%d\n", "usb_device_reset fail status", status);

Your patch does not match your description at all :(

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Eudyptula challenge  Chewie Lin <linsh@oregonstate.edu> - 2017-03-31 12:10 +0200
  [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning  Chewie Lin <linsh@oregonstate.edu> - 2017-03-31 12:10 +0200
    Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch  warning Kim Phillips <kim.phillips@arm.com> - 2017-03-31 12:40 +0200
    Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning Greg KH <greg@kroah.com> - 2017-03-31 14:40 +0200

csiph-web