Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1610005 > unrolled thread

RE: [PATCH v3 4/7] arm: dts: r7s72100: Add pin controller node

Started byChris Brandt <Chris.Brandt@renesas.com>
First post2017-03-27 19:20 +0200
Last post2017-03-29 15:30 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  RE: [PATCH v3 4/7] arm: dts: r7s72100: Add pin controller node Chris Brandt <Chris.Brandt@renesas.com> - 2017-03-27 19:20 +0200
    Re: [PATCH v3 4/7] arm: dts: r7s72100: Add pin controller node jacopo <jacopo@jmondi.org> - 2017-03-29 15:30 +0200

#1610005 — RE: [PATCH v3 4/7] arm: dts: r7s72100: Add pin controller node

FromChris Brandt <Chris.Brandt@renesas.com>
Date2017-03-27 19:20 +0200
SubjectRE: [PATCH v3 4/7] arm: dts: r7s72100: Add pin controller node
Message-ID<tpGtc-34b-13@gated-at.bofh.it>
Hi Jacopo,


On Friday, March 24, 2017, Jacopo Mondi
> +	pinctrl: pinctrl@fcfe3000 {
> +		compatible = "renesas,r7s72100-ports";
> +
> +		#pinctrl-cells = <1>;
> +
> +		reg = <0xfcfe3000 0x42C0>;

Out of curiosity, why did you change this from 0x4248 to 0x42C0?

In your update for renesas,rza1-pinctrl.txt, for the 'Example', you changed it from 0x4248 to 0x4230 (which Geert pointed out makes more sense), but then in the actual DT file you changed it to 0x42C0. Typo?


Chris

[toc] | [next] | [standalone]


#1611938

Fromjacopo <jacopo@jmondi.org>
Date2017-03-29 15:30 +0200
Message-ID<tqlPI-7sg-21@gated-at.bofh.it>
In reply to#1610005
Hi Chris,

On Mon, Mar 27, 2017 at 05:12:04PM +0000, Chris Brandt wrote:
> Hi Jacopo,
> 
> 
> On Friday, March 24, 2017, Jacopo Mondi
> > +	pinctrl: pinctrl@fcfe3000 {
> > +		compatible = "renesas,r7s72100-ports";
> > +
> > +		#pinctrl-cells = <1>;
> > +
> > +		reg = <0xfcfe3000 0x42C0>;
> 
> Out of curiosity, why did you change this from 0x4248 to 0x42C0?
> 
> In your update for renesas,rza1-pinctrl.txt, for the 'Example', you changed it from 0x4248 to 0x4230 (which Geert pointed out makes more sense), but then in the actual DT file you changed it to 0x42C0. Typo?
>

Yes, type.
Or inability to perform basic mathematical operations.
Not sure yet.

Thanks for spotting this :)
   j


> 
> Chris
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web