Groups > linux.kernel > #1611938

Re: [PATCH v3 4/7] arm: dts: r7s72100: Add pin controller node

From	jacopo <jacopo@jmondi.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 4/7] arm: dts: r7s72100: Add pin controller node
Date	2017-03-29 15:30 +0200
Message-ID	<tqlPI-7sg-21@gated-at.bofh.it> (permalink)
References	<tozk5-3uM-17@gated-at.bofh.it> <tozk5-3uM-15@gated-at.bofh.it> <tpGtc-34b-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Chris,

On Mon, Mar 27, 2017 at 05:12:04PM +0000, Chris Brandt wrote:
> Hi Jacopo,
> 
> 
> On Friday, March 24, 2017, Jacopo Mondi
> > +	pinctrl: pinctrl@fcfe3000 {
> > +		compatible = "renesas,r7s72100-ports";
> > +
> > +		#pinctrl-cells = <1>;
> > +
> > +		reg = <0xfcfe3000 0x42C0>;
> 
> Out of curiosity, why did you change this from 0x4248 to 0x42C0?
> 
> In your update for renesas,rza1-pinctrl.txt, for the 'Example', you changed it from 0x4248 to 0x4230 (which Geert pointed out makes more sense), but then in the actual DT file you changed it to 0x42C0. Typo?
>

Yes, type.
Or inability to perform basic mathematical operations.
Not sure yet.

Thanks for spotting this :)
   j


> 
> Chris
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

RE: [PATCH v3 4/7] arm: dts: r7s72100: Add pin controller node Chris Brandt <Chris.Brandt@renesas.com> - 2017-03-27 19:20 +0200
  Re: [PATCH v3 4/7] arm: dts: r7s72100: Add pin controller node jacopo <jacopo@jmondi.org> - 2017-03-29 15:30 +0200

csiph-web