Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1611166 > unrolled thread

[PATCH linux-next v2 0/4] usb: gadget: udc: atmel: Endpoint allocation scheme fixes

Back to article view | Back to linux.kernel

Contents

  [PATCH linux-next v2 0/4] usb: gadget: udc: atmel: Endpoint allocation scheme fixes <cristian.birsan@microchip.com> - 2017-03-28 18:20 +0200
    [PATCH linux-next v2 3/4] usb: gadget: udc: atmel: Use dev_warn() to display EP configuration error <cristian.birsan@microchip.com> - 2017-03-28 18:20 +0200
      Re: [PATCH linux-next v2 3/4] usb: gadget: udc: atmel: Use dev_warn() to display EP configuration error Felipe Balbi <balbi@kernel.org> - 2017-03-30 12:50 +0200
    Re: [PATCH linux-next v2 0/4] usb: gadget: udc: atmel: Endpoint  allocation scheme fixes Nicolas Ferre <nicolas.ferre@atmel.com> - 2017-03-29 10:50 +0200

#1611166 — [PATCH linux-next v2 0/4] usb: gadget: udc: atmel: Endpoint allocation scheme fixes

From: Cristian Birsan <cristian.birsan@microchip.com>

This patch series provides fixes, based on the feedback received on the mailing list, for
the following:
	- fifo table parameters validation against device tree values
	- coding style
	- message display for EP configuration error
	- Kconfig comments for fifo_mode=0

Changes since v1:
	- Removed static for usba_config_fifo_table() function from "Check fifo
	configuration values against device tree" patch

Cristian Birsan (4):
  usb: gadget: udc: atmel: Check fifo configuration values against
    device tree
  usb: gadget: udc: atmel: Minor code cleanup
  usb: gadget: udc: atmel: Use dev_warn() to display EP configuration
    error
  usb: gadget: udc: atmel: Update Kconfig help for fifo_mode = 0

 drivers/usb/gadget/udc/Kconfig          |  5 ++--
 drivers/usb/gadget/udc/atmel_usba_udc.c | 47 ++++++++++++++++++++++-----------
 2 files changed, 35 insertions(+), 17 deletions(-)

-- 
2.7.4

[toc] | [next] | [standalone]

#1611168 — [PATCH linux-next v2 3/4] usb: gadget: udc: atmel: Use dev_warn() to display EP configuration error

From: Cristian Birsan <cristian.birsan@microchip.com>

Use dev_warn() to display EP configuration error to avoid silent failure.

Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
---
 drivers/usb/gadget/udc/atmel_usba_udc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
index 2bd8410..942c9c9 100644
--- a/drivers/usb/gadget/udc/atmel_usba_udc.c
+++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
@@ -1851,7 +1851,7 @@ static irqreturn_t usba_udc_irq(int irq, void *devid)
 		 * but it's clearly harmless...
 		 */
 		if (!(usba_ep_readl(ep0, CFG) & USBA_EPT_MAPPED))
-			dev_dbg(&udc->pdev->dev,
+			dev_warn(&udc->pdev->dev,
 				 "ODD: EP0 configuration is invalid!\n");
 
 		/* Preallocate other endpoints */
@@ -1860,8 +1860,8 @@ static irqreturn_t usba_udc_irq(int irq, void *devid)
 			ep = &udc->usba_ep[i];
 			usba_ep_writel(ep, CFG, ep->ept_cfg);
 			if (!(usba_ep_readl(ep, CFG) & USBA_EPT_MAPPED))
-				dev_dbg(&udc->pdev->dev,
-				 "ODD: EP%d configuration is invalid!\n", i);
+				dev_warn(&udc->pdev->dev,
+					 "ODD: EP%d configuration is invalid!\n", i);
 		}
 	}
 
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1612939 — Re: [PATCH linux-next v2 3/4] usb: gadget: udc: atmel: Use dev_warn() to display EP configuration error

[Multipart message — attachments visible in raw view] — view raw

Hi,

cristian.birsan@microchip.com writes:
> From: Cristian Birsan <cristian.birsan@microchip.com>
>
> Use dev_warn() to display EP configuration error to avoid silent failure.
>
> Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
> ---
>  drivers/usb/gadget/udc/atmel_usba_udc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index 2bd8410..942c9c9 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -1851,7 +1851,7 @@ static irqreturn_t usba_udc_irq(int irq, void *devid)
>  		 * but it's clearly harmless...
>  		 */
>  		if (!(usba_ep_readl(ep0, CFG) & USBA_EPT_MAPPED))
> -			dev_dbg(&udc->pdev->dev,
> +			dev_warn(&udc->pdev->dev,

seems like dev_err() would've been more fitting.

-- 
balbi

[toc] | [prev] | [next] | [standalone]

#1611696 — Re: [PATCH linux-next v2 0/4] usb: gadget: udc: atmel: Endpoint allocation scheme fixes

Le 28/03/2017 à 18:07, cristian.birsan@microchip.com a écrit :
> From: Cristian Birsan <cristian.birsan@microchip.com>
> 
> This patch series provides fixes, based on the feedback received on the mailing list, for
> the following:
> 	- fifo table parameters validation against device tree values
> 	- coding style
> 	- message display for EP configuration error
> 	- Kconfig comments for fifo_mode=0
> 
> Changes since v1:
> 	- Removed static for usba_config_fifo_table() function from "Check fifo
> 	configuration values against device tree" patch

As for previous revision, the whole series:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Regards,

> Cristian Birsan (4):
>   usb: gadget: udc: atmel: Check fifo configuration values against
>     device tree
>   usb: gadget: udc: atmel: Minor code cleanup
>   usb: gadget: udc: atmel: Use dev_warn() to display EP configuration
>     error
>   usb: gadget: udc: atmel: Update Kconfig help for fifo_mode = 0
> 
>  drivers/usb/gadget/udc/Kconfig          |  5 ++--
>  drivers/usb/gadget/udc/atmel_usba_udc.c | 47 ++++++++++++++++++++++-----------
>  2 files changed, 35 insertions(+), 17 deletions(-)
> 


-- 
Nicolas Ferre

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web