Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1612939
| From | Felipe Balbi <balbi@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH linux-next v2 3/4] usb: gadget: udc: atmel: Use dev_warn() to display EP configuration error |
| Date | 2017-03-30 12:50 +0200 |
| Message-ID | <tqFOq-55A-19@gated-at.bofh.it> (permalink) |
| References | <tq20G-1Mi-19@gated-at.bofh.it> <tq20H-1Mi-51@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
Hi, cristian.birsan@microchip.com writes: > From: Cristian Birsan <cristian.birsan@microchip.com> > > Use dev_warn() to display EP configuration error to avoid silent failure. > > Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com> > --- > drivers/usb/gadget/udc/atmel_usba_udc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c > index 2bd8410..942c9c9 100644 > --- a/drivers/usb/gadget/udc/atmel_usba_udc.c > +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c > @@ -1851,7 +1851,7 @@ static irqreturn_t usba_udc_irq(int irq, void *devid) > * but it's clearly harmless... > */ > if (!(usba_ep_readl(ep0, CFG) & USBA_EPT_MAPPED)) > - dev_dbg(&udc->pdev->dev, > + dev_warn(&udc->pdev->dev, seems like dev_err() would've been more fitting. -- balbi
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH linux-next v2 0/4] usb: gadget: udc: atmel: Endpoint allocation scheme fixes <cristian.birsan@microchip.com> - 2017-03-28 18:20 +0200
[PATCH linux-next v2 3/4] usb: gadget: udc: atmel: Use dev_warn() to display EP configuration error <cristian.birsan@microchip.com> - 2017-03-28 18:20 +0200
Re: [PATCH linux-next v2 3/4] usb: gadget: udc: atmel: Use dev_warn() to display EP configuration error Felipe Balbi <balbi@kernel.org> - 2017-03-30 12:50 +0200
Re: [PATCH linux-next v2 0/4] usb: gadget: udc: atmel: Endpoint allocation scheme fixes Nicolas Ferre <nicolas.ferre@atmel.com> - 2017-03-29 10:50 +0200
csiph-web