Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1611498 > unrolled thread

Re: [PATCH] input: matrix_keypad: add option to drive inactive columns

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] input: matrix_keypad: add option to drive inactive  columns Rob Herring <robh@kernel.org> - 2017-03-29 04:10 +0200
    Re: [PATCH] input: matrix_keypad: add option to drive inactive  columns Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-29 09:20 +0200

#1611498 — Re: [PATCH] input: matrix_keypad: add option to drive inactive columns

On Wed, Mar 22, 2017 at 04:16:50PM -0400, David Rivshin wrote:
> From: David Rivshin <DRivshin@allworx.com>
> 
> The gpio-matrix-keypad driver normally sets inactive columns as inputs
> while scanning. This does not work for all hardware, which may require
> the inactive columns to be actively driven in order to overcome any
> pull-ups/downs on the columns.
> 
> Signed-off-by: David Rivshin <drivshin@allworx.com>
> ---
>  .../devicetree/bindings/input/gpio-matrix-keypad.txt        |  2 ++
>  drivers/input/keyboard/matrix_keypad.c                      | 13 +++++++++----
>  include/linux/input/matrix_keypad.h                         |  3 +++
>  3 files changed, 14 insertions(+), 4 deletions(-)

Acked-by: Rob Herring <robh@kernel.org>

[toc] | [next] | [standalone]

#1611640

On Tue, Mar 28, 2017 at 09:02:29PM -0500, Rob Herring wrote:
> On Wed, Mar 22, 2017 at 04:16:50PM -0400, David Rivshin wrote:
> > From: David Rivshin <DRivshin@allworx.com>
> > 
> > The gpio-matrix-keypad driver normally sets inactive columns as inputs
> > while scanning. This does not work for all hardware, which may require
> > the inactive columns to be actively driven in order to overcome any
> > pull-ups/downs on the columns.
> > 
> > Signed-off-by: David Rivshin <drivshin@allworx.com>
> > ---
> >  .../devicetree/bindings/input/gpio-matrix-keypad.txt        |  2 ++
> >  drivers/input/keyboard/matrix_keypad.c                      | 13 +++++++++----
> >  include/linux/input/matrix_keypad.h                         |  3 +++
> >  3 files changed, 14 insertions(+), 4 deletions(-)
> 
> Acked-by: Rob Herring <robh@kernel.org>

Applied, thank you.

-- 
Dmitry

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web