Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1611498

Re: [PATCH] input: matrix_keypad: add option to drive inactive columns

Show all headers | View raw

On Wed, Mar 22, 2017 at 04:16:50PM -0400, David Rivshin wrote:
> From: David Rivshin <DRivshin@allworx.com>
> 
> The gpio-matrix-keypad driver normally sets inactive columns as inputs
> while scanning. This does not work for all hardware, which may require
> the inactive columns to be actively driven in order to overcome any
> pull-ups/downs on the columns.
> 
> Signed-off-by: David Rivshin <drivshin@allworx.com>
> ---
>  .../devicetree/bindings/input/gpio-matrix-keypad.txt        |  2 ++
>  drivers/input/keyboard/matrix_keypad.c                      | 13 +++++++++----
>  include/linux/input/matrix_keypad.h                         |  3 +++
>  3 files changed, 14 insertions(+), 4 deletions(-)

Acked-by: Rob Herring <robh@kernel.org>

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] input: matrix_keypad: add option to drive inactive  columns Rob Herring <robh@kernel.org> - 2017-03-29 04:10 +0200
  Re: [PATCH] input: matrix_keypad: add option to drive inactive  columns Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-29 09:20 +0200

csiph-web