Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1612289 > unrolled thread
| Started by | "Michael S. Tsirkin" <mst@redhat.com> |
|---|---|
| First post | 2017-03-29 22:20 +0200 |
| Last post | 2017-03-30 07:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH net-next] virtio_net: don't reset twice on XDP on/off "Michael S. Tsirkin" <mst@redhat.com> - 2017-03-29 22:20 +0200
Re: [PATCH net-next] virtio_net: don't reset twice on XDP on/off Jason Wang <jasowang@redhat.com> - 2017-03-30 07:50 +0200
| From | "Michael S. Tsirkin" <mst@redhat.com> |
|---|---|
| Date | 2017-03-29 22:20 +0200 |
| Subject | [PATCH net-next] virtio_net: don't reset twice on XDP on/off |
| Message-ID | <tqseu-3C5-23@gated-at.bofh.it> |
We already do a reset once in remove_vq_common - there appears to be no point in doing another one when we add/remove XDP. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- drivers/net/virtio_net.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index de42e9a..ed8f548 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -1810,7 +1810,6 @@ static int virtnet_reset(struct virtnet_info *vi, int curr_qp, int xdp_qp) virtnet_freeze_down(dev); _remove_vq_common(vi); - dev->config->reset(dev); virtio_add_status(dev, VIRTIO_CONFIG_S_ACKNOWLEDGE); virtio_add_status(dev, VIRTIO_CONFIG_S_DRIVER); -- MST
[toc] | [next] | [standalone]
| From | Jason Wang <jasowang@redhat.com> |
|---|---|
| Date | 2017-03-30 07:50 +0200 |
| Message-ID | <tqB85-1Bk-5@gated-at.bofh.it> |
| In reply to | #1612289 |
On 2017年03月30日 04:14, Michael S. Tsirkin wrote: > We already do a reset once in remove_vq_common - > there appears to be no point in doing another one > when we add/remove XDP. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > --- > drivers/net/virtio_net.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index de42e9a..ed8f548 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -1810,7 +1810,6 @@ static int virtnet_reset(struct virtnet_info *vi, int curr_qp, int xdp_qp) > virtnet_freeze_down(dev); > _remove_vq_common(vi); > > - dev->config->reset(dev); > virtio_add_status(dev, VIRTIO_CONFIG_S_ACKNOWLEDGE); > virtio_add_status(dev, VIRTIO_CONFIG_S_DRIVER); > Acked-by: Jason Wang <jasowang@redhat.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web