Re: [PATCH net-next] virtio_net: don't reset twice on XDP on/off

From	Jason Wang <jasowang@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next] virtio_net: don't reset twice on XDP on/off
Date	2017-03-30 07:50 +0200
Message-ID	<tqB85-1Bk-5@gated-at.bofh.it> (permalink)
References	<tqseu-3C5-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 2017年03月30日 04:14, Michael S. Tsirkin wrote:
> We already do a reset once in remove_vq_common -
> there appears to be no point in doing another one
> when we add/remove XDP.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>   drivers/net/virtio_net.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index de42e9a..ed8f548 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -1810,7 +1810,6 @@ static int virtnet_reset(struct virtnet_info *vi, int curr_qp, int xdp_qp)
>   	virtnet_freeze_down(dev);
>   	_remove_vq_common(vi);
>   
> -	dev->config->reset(dev);
>   	virtio_add_status(dev, VIRTIO_CONFIG_S_ACKNOWLEDGE);
>   	virtio_add_status(dev, VIRTIO_CONFIG_S_DRIVER);
>   

Acked-by: Jason Wang <jasowang@redhat.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next] virtio_net: don't reset twice on XDP on/off "Michael S. Tsirkin" <mst@redhat.com> - 2017-03-29 22:20 +0200
  Re: [PATCH net-next] virtio_net: don't reset twice on XDP on/off Jason Wang <jasowang@redhat.com> - 2017-03-30 07:50 +0200

csiph-web