Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1610633 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-03-28 14:20 +0200 |
| Last post | 2017-03-28 15:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] 6lowpan: fix assignment of peer_addr Colin King <colin.king@canonical.com> - 2017-03-28 14:20 +0200
Re: [PATCH] 6lowpan: fix assignment of peer_addr Luiz Augusto von Dentz <luiz.dentz@gmail.com> - 2017-03-28 15:40 +0200
Re: [PATCH] 6lowpan: fix assignment of peer_addr Marcel Holtmann <marcel@holtmann.org> - 2017-03-28 15:50 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-03-28 14:20 +0200 |
| Subject | [PATCH] 6lowpan: fix assignment of peer_addr |
| Message-ID | <tpYgq-7p2-25@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
The data from peer->chan->dst is not being copied to peer_addr, the
current code just updates the pointer and not the contents of what
it points to. Fix this with the intended assignment.
Detected by CoverityScan, CID#1422111 ("Parse warning
(PW.PARAM_SET_BUT_NOT_USED)")
Fixes: fb6f2f606ce8 ("6lowpan: Fix IID format for Bluetooth")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
net/bluetooth/6lowpan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
index 24348c8579dd..ba28c7b1557f 100644
--- a/net/bluetooth/6lowpan.c
+++ b/net/bluetooth/6lowpan.c
@@ -432,7 +432,7 @@ static int setup_header(struct sk_buff *skb, struct net_device *netdev,
}
daddr = peer->lladdr;
- peer_addr = &peer->chan->dst;
+ *peer_addr = peer->chan->dst;
*peer_addr_type = peer->chan->dst_type;
lowpan_cb(skb)->chan = peer->chan;
--
2.11.0
[toc] | [next] | [standalone]
| From | Luiz Augusto von Dentz <luiz.dentz@gmail.com> |
|---|---|
| Date | 2017-03-28 15:40 +0200 |
| Message-ID | <tpZvR-8gn-53@gated-at.bofh.it> |
| In reply to | #1610633 |
Hi Colin,
On Tue, Mar 28, 2017 at 3:11 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The data from peer->chan->dst is not being copied to peer_addr, the
> current code just updates the pointer and not the contents of what
> it points to. Fix this with the intended assignment.
>
> Detected by CoverityScan, CID#1422111 ("Parse warning
> (PW.PARAM_SET_BUT_NOT_USED)")
>
> Fixes: fb6f2f606ce8 ("6lowpan: Fix IID format for Bluetooth")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> net/bluetooth/6lowpan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
> index 24348c8579dd..ba28c7b1557f 100644
> --- a/net/bluetooth/6lowpan.c
> +++ b/net/bluetooth/6lowpan.c
> @@ -432,7 +432,7 @@ static int setup_header(struct sk_buff *skb, struct net_device *netdev,
> }
>
> daddr = peer->lladdr;
> - peer_addr = &peer->chan->dst;
> + *peer_addr = peer->chan->dst;
> *peer_addr_type = peer->chan->dst_type;
> lowpan_cb(skb)->chan = peer->chan;
>
> --
> 2.11.0
Reviewed-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
--
Luiz Augusto von Dentz
[toc] | [prev] | [next] | [standalone]
| From | Marcel Holtmann <marcel@holtmann.org> |
|---|---|
| Date | 2017-03-28 15:50 +0200 |
| Message-ID | <tpZFw-8kZ-15@gated-at.bofh.it> |
| In reply to | #1610633 |
Hi Colin,
> The data from peer->chan->dst is not being copied to peer_addr, the
> current code just updates the pointer and not the contents of what
> it points to. Fix this with the intended assignment.
>
> Detected by CoverityScan, CID#1422111 ("Parse warning
> (PW.PARAM_SET_BUT_NOT_USED)")
>
> Fixes: fb6f2f606ce8 ("6lowpan: Fix IID format for Bluetooth")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> net/bluetooth/6lowpan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web