Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1610909

Re: [PATCH] 6lowpan: fix assignment of peer_addr

Show all headers | View raw

Hi Colin,

On Tue, Mar 28, 2017 at 3:11 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The data from peer->chan->dst is not being copied to peer_addr, the
> current code just updates the pointer and not the contents of what
> it points to.  Fix this with the intended assignment.
>
> Detected by CoverityScan, CID#1422111 ("Parse warning
> (PW.PARAM_SET_BUT_NOT_USED)")
>
> Fixes: fb6f2f606ce8 ("6lowpan: Fix IID format for Bluetooth")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  net/bluetooth/6lowpan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
> index 24348c8579dd..ba28c7b1557f 100644
> --- a/net/bluetooth/6lowpan.c
> +++ b/net/bluetooth/6lowpan.c
> @@ -432,7 +432,7 @@ static int setup_header(struct sk_buff *skb, struct net_device *netdev,
>                 }
>
>                 daddr = peer->lladdr;
> -               peer_addr = &peer->chan->dst;
> +               *peer_addr = peer->chan->dst;
>                 *peer_addr_type = peer->chan->dst_type;
>                 lowpan_cb(skb)->chan = peer->chan;
>
> --
> 2.11.0

Reviewed-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

-- 
Luiz Augusto von Dentz

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] 6lowpan: fix assignment of peer_addr Colin King <colin.king@canonical.com> - 2017-03-28 14:20 +0200
  Re: [PATCH] 6lowpan: fix assignment of peer_addr Luiz Augusto von Dentz <luiz.dentz@gmail.com> - 2017-03-28 15:40 +0200
  Re: [PATCH] 6lowpan: fix assignment of peer_addr Marcel Holtmann <marcel@holtmann.org> - 2017-03-28 15:50 +0200

csiph-web