Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1610168 > unrolled thread
| Started by | Paul Gortmaker <paul.gortmaker@windriver.com> |
|---|---|
| First post | 2017-03-28 01:50 +0200 |
| Last post | 2017-03-28 10:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] serial: 8250_EXAR: fix duplicate Kconfig text and add missing help text Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-03-28 01:50 +0200
Re: [PATCH] serial: 8250_EXAR: fix duplicate Kconfig text and add missing help text Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-28 09:20 +0200
Re: [PATCH] serial: 8250_EXAR: fix duplicate Kconfig text and add missing help text Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2017-03-28 10:00 +0200
| From | Paul Gortmaker <paul.gortmaker@windriver.com> |
|---|---|
| Date | 2017-03-28 01:50 +0200 |
| Subject | [PATCH] serial: 8250_EXAR: fix duplicate Kconfig text and add missing help text |
| Message-ID | <tpMyC-7km-7@gated-at.bofh.it> |
In commit d0aeaa83f0b0f7a92615bbdd6b1f96812f7dcfd2 ("serial: exar:
split out the exar code from 8250_pci") the exar driver got its own
Kconfig. However the text for the new option was never changed from
the original 8250_PCI text, and hence it appears confusing when you
get asked the same question twice:
8250/16550 PCI device support (SERIAL_8250_PCI) [Y/n/m/?] (NEW)
8250/16550 PCI device support (SERIAL_8250_EXAR) [Y/n/m] (NEW)
Adding to the confusion, is that there is no help text for this new
option to indicate it is specific to a certain family of cards.
Fix both issues at the same time, as well as the space vs. tab issues
introduced in the same commit.
Fixes: d0aeaa83f0b0 ("serial: exar: split out the exar code from 8250_pci")
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>
Cc: linux-serial@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/tty/serial/8250/Kconfig | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
index a65fb8197aec..0e3f529d50e9 100644
--- a/drivers/tty/serial/8250/Kconfig
+++ b/drivers/tty/serial/8250/Kconfig
@@ -128,9 +128,13 @@ config SERIAL_8250_PCI
by the parport_serial driver, enabled with CONFIG_PARPORT_SERIAL.
config SERIAL_8250_EXAR
- tristate "8250/16550 PCI device support"
- depends on SERIAL_8250_PCI
+ tristate "8250/16550 Exar/Commtech PCI/PCIe device support"
+ depends on SERIAL_8250_PCI
default SERIAL_8250
+ help
+ This builds support for XR17C1xx, XR17V3xx and some Commtech
+ 422x PCIe serial cards that are not covered by the more generic
+ SERIAL_8250_PCI option.
config SERIAL_8250_HP300
tristate
--
2.11.0
[toc] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2017-03-28 09:20 +0200 |
| Subject | Re: [PATCH] serial: 8250_EXAR: fix duplicate Kconfig text and add missing help text |
| Message-ID | <tpTA5-45q-5@gated-at.bofh.it> |
| In reply to | #1610168 |
On Tue, Mar 28, 2017 at 2:39 AM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> In commit d0aeaa83f0b0f7a92615bbdd6b1f96812f7dcfd2 ("serial: exar:
> split out the exar code from 8250_pci") the exar driver got its own
> Kconfig. However the text for the new option was never changed from
> the original 8250_PCI text, and hence it appears confusing when you
> get asked the same question twice:
>
> 8250/16550 PCI device support (SERIAL_8250_PCI) [Y/n/m/?] (NEW)
> 8250/16550 PCI device support (SERIAL_8250_EXAR) [Y/n/m] (NEW)
>
> Adding to the confusion, is that there is no help text for this new
> option to indicate it is specific to a certain family of cards.
>
> Fix both issues at the same time, as well as the space vs. tab issues
> introduced in the same commit.
>
Good catch!
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Fixes: d0aeaa83f0b0 ("serial: exar: split out the exar code from 8250_pci")
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jslaby@suse.com>
> Cc: linux-serial@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
> drivers/tty/serial/8250/Kconfig | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
> index a65fb8197aec..0e3f529d50e9 100644
> --- a/drivers/tty/serial/8250/Kconfig
> +++ b/drivers/tty/serial/8250/Kconfig
> @@ -128,9 +128,13 @@ config SERIAL_8250_PCI
> by the parport_serial driver, enabled with CONFIG_PARPORT_SERIAL.
>
> config SERIAL_8250_EXAR
> - tristate "8250/16550 PCI device support"
> - depends on SERIAL_8250_PCI
> + tristate "8250/16550 Exar/Commtech PCI/PCIe device support"
> + depends on SERIAL_8250_PCI
> default SERIAL_8250
> + help
> + This builds support for XR17C1xx, XR17V3xx and some Commtech
> + 422x PCIe serial cards that are not covered by the more generic
> + SERIAL_8250_PCI option.
>
> config SERIAL_8250_HP300
> tristate
> --
> 2.11.0
>
--
With Best Regards,
Andy Shevchenko
[toc] | [prev] | [next] | [standalone]
| From | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
|---|---|
| Date | 2017-03-28 10:00 +0200 |
| Subject | Re: [PATCH] serial: 8250_EXAR: fix duplicate Kconfig text and add missing help text |
| Message-ID | <tpUcO-4ow-11@gated-at.bofh.it> |
| In reply to | #1610168 |
On Mon, Mar 27, 2017 at 07:39:10PM -0400, Paul Gortmaker wrote:
> In commit d0aeaa83f0b0f7a92615bbdd6b1f96812f7dcfd2 ("serial: exar:
> split out the exar code from 8250_pci") the exar driver got its own
> Kconfig. However the text for the new option was never changed from
> the original 8250_PCI text, and hence it appears confusing when you
> get asked the same question twice:
>
> 8250/16550 PCI device support (SERIAL_8250_PCI) [Y/n/m/?] (NEW)
> 8250/16550 PCI device support (SERIAL_8250_EXAR) [Y/n/m] (NEW)
>
> Adding to the confusion, is that there is no help text for this new
> option to indicate it is specific to a certain family of cards.
>
> Fix both issues at the same time, as well as the space vs. tab issues
> introduced in the same commit.
>
> Fixes: d0aeaa83f0b0 ("serial: exar: split out the exar code from 8250_pci")
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web