Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1610387

Re: [PATCH] serial: 8250_EXAR: fix duplicate Kconfig text and add missing help text

Show all headers | View raw

On Mon, Mar 27, 2017 at 07:39:10PM -0400, Paul Gortmaker wrote:
> In commit d0aeaa83f0b0f7a92615bbdd6b1f96812f7dcfd2 ("serial: exar:
> split out the exar code from 8250_pci") the exar driver got its own
> Kconfig.  However the text for the new option was never changed from
> the original 8250_PCI text, and hence it appears confusing when you
> get asked the same question twice:
> 
>   8250/16550 PCI device support (SERIAL_8250_PCI) [Y/n/m/?] (NEW)
>     8250/16550 PCI device support (SERIAL_8250_EXAR) [Y/n/m] (NEW)
> 
> Adding to the confusion, is that there is no help text for this new
> option to indicate it is specific to a certain family of cards.
> 
> Fix both issues at the same time, as well as the space vs. tab issues
> introduced in the same commit.
> 
> Fixes: d0aeaa83f0b0 ("serial: exar: split out the exar code from 8250_pci")
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>

Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] serial: 8250_EXAR: fix duplicate Kconfig text and add missing help text Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-03-28 01:50 +0200
  Re: [PATCH] serial: 8250_EXAR: fix duplicate Kconfig text and add  missing help text Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-28 09:20 +0200
  Re: [PATCH] serial: 8250_EXAR: fix duplicate Kconfig text and add  missing help text Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2017-03-28 10:00 +0200

csiph-web