Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1606859 > unrolled thread

[PATCH 00/12] ARM: dts: i.MX6: Add lcdif/sound nodes on Engicam SOMs

Started byJagan Teki <jagan@openedev.com>
First post2017-03-22 19:00 +0100
Last post2017-03-24 06:30 +0100
Articles 9 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH 00/12] ARM: dts: i.MX6: Add lcdif/sound nodes on Engicam SOMs Jagan Teki <jagan@openedev.com> - 2017-03-22 19:00 +0100
    [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node Jagan Teki <jagan@openedev.com> - 2017-03-22 19:00 +0100
      Re: [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node Shawn Guo <shawnguo@kernel.org> - 2017-03-24 06:20 +0100
        Re: [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node Jagan Teki <jagan@amarulasolutions.com> - 2017-03-24 08:10 +0100
          Re: [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node Shawn Guo <shawnguo@kernel.org> - 2017-03-24 08:30 +0100
            Re: [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node Jagan Teki <jagan@amarulasolutions.com> - 2017-03-24 08:40 +0100
              Re: [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node Shawn Guo <shawnguo@kernel.org> - 2017-03-24 08:40 +0100
    [PATCH 03/12] ARM: dts: imx6ul-isiot: Add imx6ul-isiot-common.dtsi Jagan Teki <jagan@openedev.com> - 2017-03-22 19:00 +0100
    Re: [PATCH 00/12] ARM: dts: i.MX6: Add lcdif/sound nodes on Engicam  SOMs Shawn Guo <shawnguo@kernel.org> - 2017-03-24 06:30 +0100

#1606859 — [PATCH 00/12] ARM: dts: i.MX6: Add lcdif/sound nodes on Engicam SOMs

FromJagan Teki <jagan@openedev.com>
Date2017-03-22 19:00 +0100
Subject[PATCH 00/12] ARM: dts: i.MX6: Add lcdif/sound nodes on Engicam SOMs
Message-ID<tnSI9-6gL-3@gated-at.bofh.it>
From: Jagan Teki <jagan@amarulasolutions.com>

This patchset, add support for backlight, lcdif, touchscreen,
sound card and related codec and can nodes all Engicam SOM's
which are supporting mainline as of now.

Jagan Teki (12):
  ARM: dts: imx6ul-geam: Add backlight support for lcdif
  ARM: dts: imx6ul-isiot: Add backlight support for lcdif
  ARM: dts: imx6ul-isiot: Add imx6ul-isiot-common.dtsi
  ARM: dts: imx6ul-isiot: Add i2c nodes
  ARM: dts: imx6ul-isiot-common: Add touchscreen node
  ARM: dts: imx6ul-[geam|isiot]: Add sai2 node
  ARM: dts: imx6ul-isiot: Add Sound card with codec node
  ARM: dts: imx6ul-geam: Add Sound card with codec node
  ARM: dts: imx6qdl-icore: Add Sound card with codec node
  ARM: dts: imx6dl-icore: Add LVDS support
  ARM: dts: imx6dl-icore: Add touchscreen node
  ARM: dts: imx6qdl-icore-rqs: Add CAN nodes

 arch/arm/boot/dts/imx6dl-icore-rqs.dts     |   8 ++
 arch/arm/boot/dts/imx6dl-icore.dts         |  45 +++++++++
 arch/arm/boot/dts/imx6q-icore-ofcap10.dts  |  11 +++
 arch/arm/boot/dts/imx6q-icore-ofcap12.dts  |  11 +++
 arch/arm/boot/dts/imx6q-icore-rqs.dts      |   8 ++
 arch/arm/boot/dts/imx6q-icore.dts          |  11 +++
 arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi   |  26 +++++
 arch/arm/boot/dts/imx6qdl-icore.dtsi       |  37 +++++++
 arch/arm/boot/dts/imx6ul-geam-kit.dts      |  13 +++
 arch/arm/boot/dts/imx6ul-geam.dtsi         |  57 +++++++++++
 arch/arm/boot/dts/imx6ul-isiot-common.dtsi | 152 +++++++++++++++++++++++++++++
 arch/arm/boot/dts/imx6ul-isiot-emmc.dts    |   1 +
 arch/arm/boot/dts/imx6ul-isiot-nand.dts    |   1 +
 arch/arm/boot/dts/imx6ul-isiot.dtsi        | 103 +++++++++++++++++++
 14 files changed, 484 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx6ul-isiot-common.dtsi

-- 
1.9.1

[toc] | [next] | [standalone]


#1606861 — [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node

FromJagan Teki <jagan@openedev.com>
Date2017-03-22 19:00 +0100
Subject[PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node
Message-ID<tnSIb-6gL-45@gated-at.bofh.it>
In reply to#1606859
From: Jagan Teki <jagan@amarulasolutions.com>

Add touchscreen node as i2c1 slave device on Engicam Is.IoT MX6UL
modules, the touchscreen controlled 'st,stmpe-ts' connected via
i2c with st,stmpe811 mfb interface.

Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Matteo Lisi <matteo.lisi@engicam.com>
Cc: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 arch/arm/boot/dts/imx6ul-isiot-common.dtsi | 34 ++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
index 9660e20..b149b5e 100644
--- a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
+++ b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
@@ -40,6 +40,34 @@
  *     OTHER DEALINGS IN THE SOFTWARE.
  */
 
+&i2c1 {
+	touch: stmpe811@44 {
+		compatible = "st,stmpe811";
+		reg = <0x44>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_stmpe_ts>;
+		interrupt-parent = <&gpio1>;
+		interrupts = <18 IRQ_TYPE_EDGE_FALLING>;
+		interrupt-controller;
+		#interrupt-cells = <2>;
+
+		stmpe_touchscreen {
+			compatible = "st,stmpe-ts";
+			st,sample-time = <4>;
+			st,mod-12b = <1>;
+			st,ref-sel = <0>;
+			st,adc-freq = <1>;
+			st,ave-ctrl = <1>;
+			st,touch-det-delay = <2>;
+			st,settling = <2>;
+			st,fraction-z = <7>;
+			st,i-drive = <1>;
+		};
+	};
+};
+
 &lcdif {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_lcdif_dat
@@ -104,4 +132,10 @@
 			MX6UL_PAD_LCD_DATA17__LCDIF_DATA17  0x79
 		>;
 	};
+
+	pinctrl_stmpe_ts:  stmpe-tsgrp  {
+		fsl,pins = <
+			MX6UL_PAD_UART1_CTS_B__GPIO1_IO18 0x1b0b0
+		>;
+	};
 };
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]


#1608128 — Re: [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node

FromShawn Guo <shawnguo@kernel.org>
Date2017-03-24 06:20 +0100
SubjectRe: [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node
Message-ID<topNL-51g-1@gated-at.bofh.it>
In reply to#1606861
On Wed, Mar 22, 2017 at 11:18:10PM +0530, Jagan Teki wrote:
> From: Jagan Teki <jagan@amarulasolutions.com>
> 
> Add touchscreen node as i2c1 slave device on Engicam Is.IoT MX6UL
> modules, the touchscreen controlled 'st,stmpe-ts' connected via
> i2c with st,stmpe811 mfb interface.

s/mfb/mfd?

> 
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Matteo Lisi <matteo.lisi@engicam.com>
> Cc: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
>  arch/arm/boot/dts/imx6ul-isiot-common.dtsi | 34 ++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
> index 9660e20..b149b5e 100644
> --- a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
> +++ b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
> @@ -40,6 +40,34 @@
>   *     OTHER DEALINGS IN THE SOFTWARE.
>   */
>  
> +&i2c1 {
> +	touch: stmpe811@44 {

Label a MFD device 'touch'?  Also, the node name should be generic.  Not
sure what should be used for MFD device though.

> +		compatible = "st,stmpe811";
> +		reg = <0x44>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_stmpe_ts>;

If this is for stmpe-ts, shouldn't be put into touchscreen child node?

> +		interrupt-parent = <&gpio1>;
> +		interrupts = <18 IRQ_TYPE_EDGE_FALLING>;
> +		interrupt-controller;
> +		#interrupt-cells = <2>;
> +
> +		stmpe_touchscreen {

'stmpe: touchscreen {' might be better.

Shawn

> +			compatible = "st,stmpe-ts";
> +			st,sample-time = <4>;
> +			st,mod-12b = <1>;
> +			st,ref-sel = <0>;
> +			st,adc-freq = <1>;
> +			st,ave-ctrl = <1>;
> +			st,touch-det-delay = <2>;
> +			st,settling = <2>;
> +			st,fraction-z = <7>;
> +			st,i-drive = <1>;
> +		};
> +	};
> +};
> +
>  &lcdif {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_lcdif_dat
> @@ -104,4 +132,10 @@
>  			MX6UL_PAD_LCD_DATA17__LCDIF_DATA17  0x79
>  		>;
>  	};
> +
> +	pinctrl_stmpe_ts:  stmpe-tsgrp  {
> +		fsl,pins = <
> +			MX6UL_PAD_UART1_CTS_B__GPIO1_IO18 0x1b0b0
> +		>;
> +	};
>  };
> -- 
> 1.9.1
> 

[toc] | [prev] | [next] | [standalone]


#1608168 — Re: [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node

FromJagan Teki <jagan@amarulasolutions.com>
Date2017-03-24 08:10 +0100
SubjectRe: [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node
Message-ID<torwe-6nm-7@gated-at.bofh.it>
In reply to#1608128
On Fri, Mar 24, 2017 at 10:46 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Wed, Mar 22, 2017 at 11:18:10PM +0530, Jagan Teki wrote:
>> From: Jagan Teki <jagan@amarulasolutions.com>
>>
>> Add touchscreen node as i2c1 slave device on Engicam Is.IoT MX6UL
>> modules, the touchscreen controlled 'st,stmpe-ts' connected via
>> i2c with st,stmpe811 mfb interface.
>
> s/mfb/mfd?
>
>>
>> Cc: Shawn Guo <shawnguo@kernel.org>
>> Cc: Matteo Lisi <matteo.lisi@engicam.com>
>> Cc: Michael Trimarchi <michael@amarulasolutions.com>
>> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>> ---
>>  arch/arm/boot/dts/imx6ul-isiot-common.dtsi | 34 ++++++++++++++++++++++++++++++
>>  1 file changed, 34 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
>> index 9660e20..b149b5e 100644
>> --- a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
>> +++ b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
>> @@ -40,6 +40,34 @@
>>   *     OTHER DEALINGS IN THE SOFTWARE.
>>   */
>>
>> +&i2c1 {
>> +     touch: stmpe811@44 {
>
> Label a MFD device 'touch'?  Also, the node name should be generic.  Not
> sure what should be used for MFD device though.

May be I can use stmpe811@41 the existing imx6qdl-apalis.dtsi using
the similar notation.

>
>> +             compatible = "st,stmpe811";
>> +             reg = <0x44>;
>> +             #address-cells = <1>;
>> +             #size-cells = <0>;
>> +             pinctrl-names = "default";
>> +             pinctrl-0 = <&pinctrl_stmpe_ts>;
>
> If this is for stmpe-ts, shouldn't be put into touchscreen child node?

Actually this is interrupt pad, for the touch controller via stmpe so
I can rename pinctrl_touch_int.

>
>> +             interrupt-parent = <&gpio1>;
>> +             interrupts = <18 IRQ_TYPE_EDGE_FALLING>;
>> +             interrupt-controller;
>> +             #interrupt-cells = <2>;
>> +
>> +             stmpe_touchscreen {
>
> 'stmpe: touchscreen {' might be better.

stmpe_touchscreen {

This is also compatible with existing dtsi files

thanks!
-- 
Jagan Teki
Senior Linux Kernel Engineer | Amarula Solutions
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.

[toc] | [prev] | [next] | [standalone]


#1608179 — Re: [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node

FromShawn Guo <shawnguo@kernel.org>
Date2017-03-24 08:30 +0100
SubjectRe: [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node
Message-ID<torPz-6yo-3@gated-at.bofh.it>
In reply to#1608168
On Fri, Mar 24, 2017 at 12:29:49PM +0530, Jagan Teki wrote:
> On Fri, Mar 24, 2017 at 10:46 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> > On Wed, Mar 22, 2017 at 11:18:10PM +0530, Jagan Teki wrote:
> >> From: Jagan Teki <jagan@amarulasolutions.com>
> >>
> >> Add touchscreen node as i2c1 slave device on Engicam Is.IoT MX6UL
> >> modules, the touchscreen controlled 'st,stmpe-ts' connected via
> >> i2c with st,stmpe811 mfb interface.
> >
> > s/mfb/mfd?
> >
> >>
> >> Cc: Shawn Guo <shawnguo@kernel.org>
> >> Cc: Matteo Lisi <matteo.lisi@engicam.com>
> >> Cc: Michael Trimarchi <michael@amarulasolutions.com>
> >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> >> ---
> >>  arch/arm/boot/dts/imx6ul-isiot-common.dtsi | 34 ++++++++++++++++++++++++++++++
> >>  1 file changed, 34 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
> >> index 9660e20..b149b5e 100644
> >> --- a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
> >> +++ b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
> >> @@ -40,6 +40,34 @@
> >>   *     OTHER DEALINGS IN THE SOFTWARE.
> >>   */
> >>
> >> +&i2c1 {
> >> +     touch: stmpe811@44 {
> >
> > Label a MFD device 'touch'?  Also, the node name should be generic.  Not
> > sure what should be used for MFD device though.
> 
> May be I can use stmpe811@41 the existing imx6qdl-apalis.dtsi using
> the similar notation.

Per application notes of stmpe811 below, I would suggest you name it
gpio-expander.

www.st.com/resource/zh/datasheet/CD00186725.pdf

> 
> >
> >> +             compatible = "st,stmpe811";
> >> +             reg = <0x44>;
> >> +             #address-cells = <1>;
> >> +             #size-cells = <0>;
> >> +             pinctrl-names = "default";
> >> +             pinctrl-0 = <&pinctrl_stmpe_ts>;
> >
> > If this is for stmpe-ts, shouldn't be put into touchscreen child node?
> 
> Actually this is interrupt pad, for the touch controller via stmpe so
> I can rename pinctrl_touch_int.

Or just pinctrl_stmpe.

> 
> >
> >> +             interrupt-parent = <&gpio1>;
> >> +             interrupts = <18 IRQ_TYPE_EDGE_FALLING>;
> >> +             interrupt-controller;
> >> +             #interrupt-cells = <2>;
> >> +
> >> +             stmpe_touchscreen {
> >
> > 'stmpe: touchscreen {' might be better.
> 
> stmpe_touchscreen {
> 
> This is also compatible with existing dtsi files

We do not need to keep compatibility with something not good.

Shawn

[toc] | [prev] | [next] | [standalone]


#1608182 — Re: [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node

FromJagan Teki <jagan@amarulasolutions.com>
Date2017-03-24 08:40 +0100
SubjectRe: [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node
Message-ID<torZg-6BK-19@gated-at.bofh.it>
In reply to#1608179
On Fri, Mar 24, 2017 at 12:55 PM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Fri, Mar 24, 2017 at 12:29:49PM +0530, Jagan Teki wrote:
>> On Fri, Mar 24, 2017 at 10:46 AM, Shawn Guo <shawnguo@kernel.org> wrote:
>> > On Wed, Mar 22, 2017 at 11:18:10PM +0530, Jagan Teki wrote:
>> >> From: Jagan Teki <jagan@amarulasolutions.com>
>> >>
>> >> Add touchscreen node as i2c1 slave device on Engicam Is.IoT MX6UL
>> >> modules, the touchscreen controlled 'st,stmpe-ts' connected via
>> >> i2c with st,stmpe811 mfb interface.
>> >
>> > s/mfb/mfd?
>> >
>> >>
>> >> Cc: Shawn Guo <shawnguo@kernel.org>
>> >> Cc: Matteo Lisi <matteo.lisi@engicam.com>
>> >> Cc: Michael Trimarchi <michael@amarulasolutions.com>
>> >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>> >> ---
>> >>  arch/arm/boot/dts/imx6ul-isiot-common.dtsi | 34 ++++++++++++++++++++++++++++++
>> >>  1 file changed, 34 insertions(+)
>> >>
>> >> diff --git a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
>> >> index 9660e20..b149b5e 100644
>> >> --- a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
>> >> +++ b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
>> >> @@ -40,6 +40,34 @@
>> >>   *     OTHER DEALINGS IN THE SOFTWARE.
>> >>   */
>> >>
>> >> +&i2c1 {
>> >> +     touch: stmpe811@44 {
>> >
>> > Label a MFD device 'touch'?  Also, the node name should be generic.  Not
>> > sure what should be used for MFD device though.
>>
>> May be I can use stmpe811@41 the existing imx6qdl-apalis.dtsi using
>> the similar notation.
>
> Per application notes of stmpe811 below, I would suggest you name it
> gpio-expander.
>
> www.st.com/resource/zh/datasheet/CD00186725.pdf

OK, will this be ok?

stmpe811: gpio-expander@44 {

>
>>
>> >
>> >> +             compatible = "st,stmpe811";
>> >> +             reg = <0x44>;
>> >> +             #address-cells = <1>;
>> >> +             #size-cells = <0>;
>> >> +             pinctrl-names = "default";
>> >> +             pinctrl-0 = <&pinctrl_stmpe_ts>;
>> >
>> > If this is for stmpe-ts, shouldn't be put into touchscreen child node?
>>
>> Actually this is interrupt pad, for the touch controller via stmpe so
>> I can rename pinctrl_touch_int.
>
> Or just pinctrl_stmpe.
>
>>
>> >
>> >> +             interrupt-parent = <&gpio1>;
>> >> +             interrupts = <18 IRQ_TYPE_EDGE_FALLING>;
>> >> +             interrupt-controller;
>> >> +             #interrupt-cells = <2>;
>> >> +
>> >> +             stmpe_touchscreen {
>> >
>> > 'stmpe: touchscreen {' might be better.
>>
>> stmpe_touchscreen {
>>
>> This is also compatible with existing dtsi files
>
> We do not need to keep compatibility with something not good.

thanks!
-- 
Jagan Teki
Senior Linux Kernel Engineer | Amarula Solutions
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.

[toc] | [prev] | [next] | [standalone]


#1608184 — Re: [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node

FromShawn Guo <shawnguo@kernel.org>
Date2017-03-24 08:40 +0100
SubjectRe: [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node
Message-ID<torZg-6BK-21@gated-at.bofh.it>
In reply to#1608182
On Fri, Mar 24, 2017 at 01:02:35PM +0530, Jagan Teki wrote:
> On Fri, Mar 24, 2017 at 12:55 PM, Shawn Guo <shawnguo@kernel.org> wrote:
> > On Fri, Mar 24, 2017 at 12:29:49PM +0530, Jagan Teki wrote:
> >> On Fri, Mar 24, 2017 at 10:46 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> >> > On Wed, Mar 22, 2017 at 11:18:10PM +0530, Jagan Teki wrote:
> >> >> From: Jagan Teki <jagan@amarulasolutions.com>
> >> >>
> >> >> Add touchscreen node as i2c1 slave device on Engicam Is.IoT MX6UL
> >> >> modules, the touchscreen controlled 'st,stmpe-ts' connected via
> >> >> i2c with st,stmpe811 mfb interface.
> >> >
> >> > s/mfb/mfd?
> >> >
> >> >>
> >> >> Cc: Shawn Guo <shawnguo@kernel.org>
> >> >> Cc: Matteo Lisi <matteo.lisi@engicam.com>
> >> >> Cc: Michael Trimarchi <michael@amarulasolutions.com>
> >> >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> >> >> ---
> >> >>  arch/arm/boot/dts/imx6ul-isiot-common.dtsi | 34 ++++++++++++++++++++++++++++++
> >> >>  1 file changed, 34 insertions(+)
> >> >>
> >> >> diff --git a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
> >> >> index 9660e20..b149b5e 100644
> >> >> --- a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
> >> >> +++ b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
> >> >> @@ -40,6 +40,34 @@
> >> >>   *     OTHER DEALINGS IN THE SOFTWARE.
> >> >>   */
> >> >>
> >> >> +&i2c1 {
> >> >> +     touch: stmpe811@44 {
> >> >
> >> > Label a MFD device 'touch'?  Also, the node name should be generic.  Not
> >> > sure what should be used for MFD device though.
> >>
> >> May be I can use stmpe811@41 the existing imx6qdl-apalis.dtsi using
> >> the similar notation.
> >
> > Per application notes of stmpe811 below, I would suggest you name it
> > gpio-expander.
> >
> > www.st.com/resource/zh/datasheet/CD00186725.pdf
> 
> OK, will this be ok?
> 
> stmpe811: gpio-expander@44 {

Yes.

Shawn

[toc] | [prev] | [next] | [standalone]


#1606863 — [PATCH 03/12] ARM: dts: imx6ul-isiot: Add imx6ul-isiot-common.dtsi

FromJagan Teki <jagan@openedev.com>
Date2017-03-22 19:00 +0100
Subject[PATCH 03/12] ARM: dts: imx6ul-isiot: Add imx6ul-isiot-common.dtsi
Message-ID<tnSIb-6gL-53@gated-at.bofh.it>
In reply to#1606859
From: Jagan Teki <jagan@amarulasolutions.com>

lcdif nodes are differ wrt specific LCD connected on Is.IoT MX6UL
module, so create separate file 'imx6ul-isiot-common.dtsi' for common
lcdif node structure and include the same on respective dts.

More common nodes will add in future patches.

Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Matteo Lisi <matteo.lisi@engicam.com>
Cc: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 arch/arm/boot/dts/imx6ul-isiot-common.dtsi | 107 +++++++++++++++++++++++++++++
 arch/arm/boot/dts/imx6ul-isiot-emmc.dts    |   1 +
 arch/arm/boot/dts/imx6ul-isiot-nand.dts    |   1 +
 3 files changed, 109 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx6ul-isiot-common.dtsi

diff --git a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
new file mode 100644
index 0000000..9660e20
--- /dev/null
+++ b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
@@ -0,0 +1,107 @@
+/*
+ * Copyright (C) 2016 Amarula Solutions B.V.
+ * Copyright (C) 2016 Engicam S.r.l.
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License
+ *     version 2 as published by the Free Software Foundation.
+ *
+ *     This file is distributed in the hope that it will be useful,
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use,
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+&lcdif {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_lcdif_dat
+		     &pinctrl_lcdif_ctrl>;
+	display = <&display0>;
+	status = "okay";
+
+	display0: display {
+		bits-per-pixel = <16>;
+		bus-width = <18>;
+
+		display-timings {
+			native-mode = <&timing0>;
+			timing0: timing0 {
+				clock-frequency = <28000000>;
+				hactive = <800>;
+				vactive = <480>;
+				hfront-porch = <30>;
+				hback-porch = <30>;
+				hsync-len = <64>;
+				vback-porch = <5>;
+				vfront-porch = <5>;
+				vsync-len = <20>;
+				hsync-active = <0>;
+				vsync-active = <0>;
+				de-active = <1>;
+				pixelclk-active = <0>;
+			};
+		};
+	};
+};
+
+&iomuxc {
+	pinctrl_lcdif_ctrl: lcdifctrlgrp {
+		fsl,pins = <
+			MX6UL_PAD_LCD_CLK__LCDIF_CLK	    0x79
+			MX6UL_PAD_LCD_ENABLE__LCDIF_ENABLE  0x79
+			MX6UL_PAD_LCD_HSYNC__LCDIF_HSYNC    0x79
+			MX6UL_PAD_LCD_VSYNC__LCDIF_VSYNC    0x79
+		>;
+	};
+
+	pinctrl_lcdif_dat: lcdifdatgrp {
+		fsl,pins = <
+			MX6UL_PAD_LCD_DATA00__LCDIF_DATA00  0x79
+			MX6UL_PAD_LCD_DATA01__LCDIF_DATA01  0x79
+			MX6UL_PAD_LCD_DATA02__LCDIF_DATA02  0x79
+			MX6UL_PAD_LCD_DATA03__LCDIF_DATA03  0x79
+			MX6UL_PAD_LCD_DATA04__LCDIF_DATA04  0x79
+			MX6UL_PAD_LCD_DATA05__LCDIF_DATA05  0x79
+			MX6UL_PAD_LCD_DATA06__LCDIF_DATA06  0x79
+			MX6UL_PAD_LCD_DATA07__LCDIF_DATA07  0x79
+			MX6UL_PAD_LCD_DATA08__LCDIF_DATA08  0x79
+			MX6UL_PAD_LCD_DATA09__LCDIF_DATA09  0x79
+			MX6UL_PAD_LCD_DATA10__LCDIF_DATA10  0x79
+			MX6UL_PAD_LCD_DATA11__LCDIF_DATA11  0x79
+			MX6UL_PAD_LCD_DATA12__LCDIF_DATA12  0x79
+			MX6UL_PAD_LCD_DATA13__LCDIF_DATA13  0x79
+			MX6UL_PAD_LCD_DATA14__LCDIF_DATA14  0x79
+			MX6UL_PAD_LCD_DATA15__LCDIF_DATA15  0x79
+			MX6UL_PAD_LCD_DATA16__LCDIF_DATA16  0x79
+			MX6UL_PAD_LCD_DATA17__LCDIF_DATA17  0x79
+		>;
+	};
+};
diff --git a/arch/arm/boot/dts/imx6ul-isiot-emmc.dts b/arch/arm/boot/dts/imx6ul-isiot-emmc.dts
index f5b4228..73a1d0f 100644
--- a/arch/arm/boot/dts/imx6ul-isiot-emmc.dts
+++ b/arch/arm/boot/dts/imx6ul-isiot-emmc.dts
@@ -43,6 +43,7 @@
 /dts-v1/;
 
 #include "imx6ul-isiot.dtsi"
+#include "imx6ul-isiot-common.dtsi"
 
 / {
 	model = "Engicam Is.IoT MX6UL eMMC Starter kit";
diff --git a/arch/arm/boot/dts/imx6ul-isiot-nand.dts b/arch/arm/boot/dts/imx6ul-isiot-nand.dts
index de15e1c..da29a86 100644
--- a/arch/arm/boot/dts/imx6ul-isiot-nand.dts
+++ b/arch/arm/boot/dts/imx6ul-isiot-nand.dts
@@ -43,6 +43,7 @@
 /dts-v1/;
 
 #include "imx6ul-isiot.dtsi"
+#include "imx6ul-isiot-common.dtsi"
 
 / {
 	model = "Engicam Is.IoT MX6UL NAND Starter kit";
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]


#1608130 — Re: [PATCH 00/12] ARM: dts: i.MX6: Add lcdif/sound nodes on Engicam SOMs

FromShawn Guo <shawnguo@kernel.org>
Date2017-03-24 06:30 +0100
SubjectRe: [PATCH 00/12] ARM: dts: i.MX6: Add lcdif/sound nodes on Engicam SOMs
Message-ID<topXr-59y-3@gated-at.bofh.it>
In reply to#1606859
On Wed, Mar 22, 2017 at 11:18:05PM +0530, Jagan Teki wrote:
> From: Jagan Teki <jagan@amarulasolutions.com>
> 
> This patchset, add support for backlight, lcdif, touchscreen,
> sound card and related codec and can nodes all Engicam SOM's
> which are supporting mainline as of now.

Per MAINTAINERS, you should copy Sascha Hauer <kernel@pengutronix.de>
and Fabio Estevam <fabio.estevam@nxp.com> as well.

Shawn

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web