Re: [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node

From	Shawn Guo <shawnguo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node
Date	2017-03-24 08:40 +0100
Message-ID	<torZg-6BK-21@gated-at.bofh.it> (permalink)
References	(1 earlier) <tnSIb-6gL-45@gated-at.bofh.it> <topNL-51g-1@gated-at.bofh.it> <torwe-6nm-7@gated-at.bofh.it> <torPz-6yo-3@gated-at.bofh.it> <torZg-6BK-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Mar 24, 2017 at 01:02:35PM +0530, Jagan Teki wrote:
> On Fri, Mar 24, 2017 at 12:55 PM, Shawn Guo <shawnguo@kernel.org> wrote:
> > On Fri, Mar 24, 2017 at 12:29:49PM +0530, Jagan Teki wrote:
> >> On Fri, Mar 24, 2017 at 10:46 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> >> > On Wed, Mar 22, 2017 at 11:18:10PM +0530, Jagan Teki wrote:
> >> >> From: Jagan Teki <jagan@amarulasolutions.com>
> >> >>
> >> >> Add touchscreen node as i2c1 slave device on Engicam Is.IoT MX6UL
> >> >> modules, the touchscreen controlled 'st,stmpe-ts' connected via
> >> >> i2c with st,stmpe811 mfb interface.
> >> >
> >> > s/mfb/mfd?
> >> >
> >> >>
> >> >> Cc: Shawn Guo <shawnguo@kernel.org>
> >> >> Cc: Matteo Lisi <matteo.lisi@engicam.com>
> >> >> Cc: Michael Trimarchi <michael@amarulasolutions.com>
> >> >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> >> >> ---
> >> >>  arch/arm/boot/dts/imx6ul-isiot-common.dtsi | 34 ++++++++++++++++++++++++++++++
> >> >>  1 file changed, 34 insertions(+)
> >> >>
> >> >> diff --git a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
> >> >> index 9660e20..b149b5e 100644
> >> >> --- a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
> >> >> +++ b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
> >> >> @@ -40,6 +40,34 @@
> >> >>   *     OTHER DEALINGS IN THE SOFTWARE.
> >> >>   */
> >> >>
> >> >> +&i2c1 {
> >> >> +     touch: stmpe811@44 {
> >> >
> >> > Label a MFD device 'touch'?  Also, the node name should be generic.  Not
> >> > sure what should be used for MFD device though.
> >>
> >> May be I can use stmpe811@41 the existing imx6qdl-apalis.dtsi using
> >> the similar notation.
> >
> > Per application notes of stmpe811 below, I would suggest you name it
> > gpio-expander.
> >
> > www.st.com/resource/zh/datasheet/CD00186725.pdf
> 
> OK, will this be ok?
> 
> stmpe811: gpio-expander@44 {

Yes.

Shawn

Thread

[PATCH 00/12] ARM: dts: i.MX6: Add lcdif/sound nodes on Engicam SOMs Jagan Teki <jagan@openedev.com> - 2017-03-22 19:00 +0100
  [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node Jagan Teki <jagan@openedev.com> - 2017-03-22 19:00 +0100
    Re: [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node Shawn Guo <shawnguo@kernel.org> - 2017-03-24 06:20 +0100
      Re: [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node Jagan Teki <jagan@amarulasolutions.com> - 2017-03-24 08:10 +0100
        Re: [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node Shawn Guo <shawnguo@kernel.org> - 2017-03-24 08:30 +0100
          Re: [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node Jagan Teki <jagan@amarulasolutions.com> - 2017-03-24 08:40 +0100
            Re: [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node Shawn Guo <shawnguo@kernel.org> - 2017-03-24 08:40 +0100
  [PATCH 03/12] ARM: dts: imx6ul-isiot: Add imx6ul-isiot-common.dtsi Jagan Teki <jagan@openedev.com> - 2017-03-22 19:00 +0100
  Re: [PATCH 00/12] ARM: dts: i.MX6: Add lcdif/sound nodes on Engicam  SOMs Shawn Guo <shawnguo@kernel.org> - 2017-03-24 06:30 +0100

csiph-web