Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1605643 > unrolled thread

Re: [PATCH v6 04/11] Documentation: perf: hisi: Documentation for HiP05/06/07 PMU event counting.

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v6 04/11] Documentation: perf: hisi: Documentation for  HiP05/06/07 PMU event counting. Mark Rutland <mark.rutland@arm.com> - 2017-03-21 15:20 +0100
    Re: [PATCH v6 04/11] Documentation: perf: hisi: Documentation for  HiP05/06/07 PMU event counting. Anurup M <anurupvasu@gmail.com> - 2017-03-24 07:40 +0100

#1605643 — Re: [PATCH v6 04/11] Documentation: perf: hisi: Documentation for HiP05/06/07 PMU event counting.

Hi,

On Fri, Mar 10, 2017 at 01:27:39AM -0500, Anurup M wrote:

> +HiP0x chips are encapsulated by multiple CPU and IO die's. The CPU die is

Nit: that apostrophe shouldn't be there.

[...]

> +The current driver doesnot support sampling. so "perf record" is unsupported.

Nit: spacing

Otherwise, this looked fine.

Thanks,
Mark.

[toc] | [next] | [standalone]

#1608154

Thanks for the review.

On Tuesday 21 March 2017 07:42 PM, Mark Rutland wrote:
> Hi,
>
> On Fri, Mar 10, 2017 at 01:27:39AM -0500, Anurup M wrote:
>
>> +HiP0x chips are encapsulated by multiple CPU and IO die's. The CPU die is
> Nit: that apostrophe shouldn't be there.

Ok. shall recheck and modify wherever applicable.

> [...]
>
>> +The current driver doesnot support sampling. so "perf record" is unsupported.
> Nit: spacing
>
> Otherwise, this looked fine.

Thanks. shall correct it.

> Thanks,
> Mark.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web