Re: [PATCH v6 04/11] Documentation: perf: hisi: Documentation for HiP05/06/07 PMU event counting.

From	Anurup M <anurupvasu@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 04/11] Documentation: perf: hisi: Documentation for HiP05/06/07 PMU event counting.
Date	2017-03-24 07:40 +0100
Message-ID	<tor3c-5V5-13@gated-at.bofh.it> (permalink)
References	<tjmdQ-87B-15@gated-at.bofh.it> <tnsNI-4r2-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Thanks for the review.

On Tuesday 21 March 2017 07:42 PM, Mark Rutland wrote:
> Hi,
>
> On Fri, Mar 10, 2017 at 01:27:39AM -0500, Anurup M wrote:
>
>> +HiP0x chips are encapsulated by multiple CPU and IO die's. The CPU die is
> Nit: that apostrophe shouldn't be there.

Ok. shall recheck and modify wherever applicable.

> [...]
>
>> +The current driver doesnot support sampling. so "perf record" is unsupported.
> Nit: spacing
>
> Otherwise, this looked fine.

Thanks. shall correct it.

> Thanks,
> Mark.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v6 04/11] Documentation: perf: hisi: Documentation for  HiP05/06/07 PMU event counting. Mark Rutland <mark.rutland@arm.com> - 2017-03-21 15:20 +0100
  Re: [PATCH v6 04/11] Documentation: perf: hisi: Documentation for  HiP05/06/07 PMU event counting. Anurup M <anurupvasu@gmail.com> - 2017-03-24 07:40 +0100

csiph-web