Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1607457 > unrolled thread
| Started by | Juergen Gross <jgross@suse.com> |
|---|---|
| First post | 2017-03-23 14:00 +0100 |
| Last post | 2017-03-23 15:20 +0100 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] xen, fbfront: fix connecting to backend Juergen Gross <jgross@suse.com> - 2017-03-23 14:00 +0100
Re: [Xen-devel] [PATCH] xen, fbfront: fix connecting to backend "Jan Beulich" <JBeulich@suse.com> - 2017-03-23 15:00 +0100
Re: [Xen-devel] [PATCH] xen, fbfront: fix connecting to backend Juergen Gross <jgross@suse.com> - 2017-03-23 15:00 +0100
Re: [Xen-devel] [PATCH] xen, fbfront: fix connecting to backend "Jan Beulich" <JBeulich@suse.com> - 2017-03-23 15:30 +0100
Re: [PATCH] xen, fbfront: fix connecting to backend Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-03-23 15:20 +0100
| From | Juergen Gross <jgross@suse.com> |
|---|---|
| Date | 2017-03-23 14:00 +0100 |
| Subject | [PATCH] xen, fbfront: fix connecting to backend |
| Message-ID | <toavp-2lS-35@gated-at.bofh.it> |
Connecting to the backend isn't working reliably in xen-fbfront: in case XenbusStateInitWait of the backend has been missed the backend transition to XenbusStateConnected will trigger the connected state only without doing the actions required when the backend has connected. Cc: stable@vger.kernel.org Signed-off-by: Juergen Gross <jgross@suse.com> --- drivers/video/fbdev/xen-fbfront.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c index d0115a7..3ee309c 100644 --- a/drivers/video/fbdev/xen-fbfront.c +++ b/drivers/video/fbdev/xen-fbfront.c @@ -643,7 +643,6 @@ static void xenfb_backend_changed(struct xenbus_device *dev, break; case XenbusStateInitWait: -InitWait: xenbus_switch_state(dev, XenbusStateConnected); break; @@ -654,7 +653,8 @@ static void xenfb_backend_changed(struct xenbus_device *dev, * get Connected twice here. */ if (dev->state != XenbusStateConnected) - goto InitWait; /* no InitWait seen yet, fudge it */ + /* no InitWait seen yet, fudge it */ + xenbus_switch_state(dev, XenbusStateConnected); if (xenbus_read_unsigned(info->xbdev->otherend, "request-update", 0)) -- 2.10.2
[toc] | [next] | [standalone]
| From | "Jan Beulich" <JBeulich@suse.com> |
|---|---|
| Date | 2017-03-23 15:00 +0100 |
| Subject | Re: [Xen-devel] [PATCH] xen, fbfront: fix connecting to backend |
| Message-ID | <tobrr-2VN-9@gated-at.bofh.it> |
| In reply to | #1607457 |
>>> On 23.03.17 at 13:52, <jgross@suse.com> wrote: > Connecting to the backend isn't working reliably in xen-fbfront: in > case XenbusStateInitWait of the backend has been missed the backend > transition to XenbusStateConnected will trigger the connected state > only without doing the actions required when the backend has > connected. Looks like xen-kbdfront does exactly the same - shouldn't it also be changed then? Jan
[toc] | [prev] | [next] | [standalone]
| From | Juergen Gross <jgross@suse.com> |
|---|---|
| Date | 2017-03-23 15:00 +0100 |
| Subject | Re: [Xen-devel] [PATCH] xen, fbfront: fix connecting to backend |
| Message-ID | <tobrs-2VN-27@gated-at.bofh.it> |
| In reply to | #1607457 |
On 23/03/17 14:37, Jan Beulich wrote: >>>> On 23.03.17 at 13:52, <jgross@suse.com> wrote: >> Connecting to the backend isn't working reliably in xen-fbfront: in >> case XenbusStateInitWait of the backend has been missed the backend >> transition to XenbusStateConnected will trigger the connected state >> only without doing the actions required when the backend has >> connected. > > Looks like xen-kbdfront does exactly the same - shouldn't it also be > changed then? I posted that patch 2 days ago. :-) Juergen
[toc] | [prev] | [next] | [standalone]
| From | "Jan Beulich" <JBeulich@suse.com> |
|---|---|
| Date | 2017-03-23 15:30 +0100 |
| Subject | Re: [Xen-devel] [PATCH] xen, fbfront: fix connecting to backend |
| Message-ID | <tobUt-3mq-1@gated-at.bofh.it> |
| In reply to | #1607519 |
>>> On 23.03.17 at 14:56, <jgross@suse.com> wrote: > On 23/03/17 14:37, Jan Beulich wrote: >>>>> On 23.03.17 at 13:52, <jgross@suse.com> wrote: >>> Connecting to the backend isn't working reliably in xen-fbfront: in >>> case XenbusStateInitWait of the backend has been missed the backend >>> transition to XenbusStateConnected will trigger the connected state >>> only without doing the actions required when the backend has >>> connected. >> >> Looks like xen-kbdfront does exactly the same - shouldn't it also be >> changed then? > > I posted that patch 2 days ago. :-) Oh, I'm sorry - the completely different title misguided me. Jan
[toc] | [prev] | [next] | [standalone]
| From | Boris Ostrovsky <boris.ostrovsky@oracle.com> |
|---|---|
| Date | 2017-03-23 15:20 +0100 |
| Message-ID | <tobKN-3j2-9@gated-at.bofh.it> |
| In reply to | #1607457 |
On 03/23/2017 08:52 AM, Juergen Gross wrote: > Connecting to the backend isn't working reliably in xen-fbfront: in > case XenbusStateInitWait of the backend has been missed the backend > transition to XenbusStateConnected will trigger the connected state > only without doing the actions required when the backend has > connected. > > Cc: stable@vger.kernel.org > Signed-off-by: Juergen Gross <jgross@suse.com> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web