Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1607457

[PATCH] xen, fbfront: fix connecting to backend

From Juergen Gross <jgross@suse.com>
Newsgroups linux.kernel
Subject [PATCH] xen, fbfront: fix connecting to backend
Date 2017-03-23 14:00 +0100
Message-ID <toavp-2lS-35@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


Connecting to the backend isn't working reliably in xen-fbfront: in
case XenbusStateInitWait of the backend has been missed the backend
transition to XenbusStateConnected will trigger the connected state
only without doing the actions required when the backend has
connected.

Cc: stable@vger.kernel.org
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/video/fbdev/xen-fbfront.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
index d0115a7..3ee309c 100644
--- a/drivers/video/fbdev/xen-fbfront.c
+++ b/drivers/video/fbdev/xen-fbfront.c
@@ -643,7 +643,6 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
 		break;
 
 	case XenbusStateInitWait:
-InitWait:
 		xenbus_switch_state(dev, XenbusStateConnected);
 		break;
 
@@ -654,7 +653,8 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
 		 * get Connected twice here.
 		 */
 		if (dev->state != XenbusStateConnected)
-			goto InitWait; /* no InitWait seen yet, fudge it */
+			/* no InitWait seen yet, fudge it */
+			xenbus_switch_state(dev, XenbusStateConnected);
 
 		if (xenbus_read_unsigned(info->xbdev->otherend,
 					 "request-update", 0))
-- 
2.10.2

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH] xen, fbfront: fix connecting to backend Juergen Gross <jgross@suse.com> - 2017-03-23 14:00 +0100
  Re: [Xen-devel] [PATCH] xen, fbfront: fix connecting to  backend "Jan Beulich" <JBeulich@suse.com> - 2017-03-23 15:00 +0100
  Re: [Xen-devel] [PATCH] xen, fbfront: fix connecting to backend Juergen Gross <jgross@suse.com> - 2017-03-23 15:00 +0100
    Re: [Xen-devel] [PATCH] xen, fbfront: fix connecting to  backend "Jan Beulich" <JBeulich@suse.com> - 2017-03-23 15:30 +0100
  Re: [PATCH] xen, fbfront: fix connecting to backend Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-03-23 15:20 +0100

csiph-web