Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1603453 > unrolled thread

[PATCH] ARM: nommu: access ID_PFR1 only if CPUID scheme

Back to article view | Back to linux.kernel

Contents

  [PATCH] ARM: nommu: access ID_PFR1 only if CPUID scheme afzal mohammed <afzal.mohd.ma@gmail.com> - 2017-03-17 17:50 +0100
    Re: [PATCH] ARM: nommu: access ID_PFR1 only if CPUID scheme afzal mohammed <afzal.mohd.ma@gmail.com> - 2017-03-23 11:50 +0100
      Re: [PATCH] ARM: nommu: access ID_PFR1 only if CPUID scheme Greg Ungerer <gerg@uclinux.org> - 2017-03-23 12:50 +0100
        Re: [PATCH] ARM: nommu: access ID_PFR1 only if CPUID scheme afzal mohammed <afzal.mohd.ma@gmail.com> - 2017-03-23 14:00 +0100

#1603453 — [PATCH] ARM: nommu: access ID_PFR1 only if CPUID scheme

Greg upon trying to boot no-MMU Kernel on ARM926EJ reported boot
failure. He root caused it to ID_PFR1 access introduced by the
commit mentioned in the fixes tag below.

All CP15 processors need not have processor feature registers, only
for architectures defined by CPUID scheme would have it. Hence check
for it before accessing processor feature register, ID_PFR1.

Fixes: f8300a0b5de0 ("ARM: 8647/2: nommu: dynamic exception base address setting")
Reported-by: Greg Ungerer <gerg@uclinux.org>
Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
---

Hi Russell,

It would be good to have the fix go in during -rc, as,

1. Culprit commit went in during the last merge window
2. Though nothing supported in mainline is known to be broken, the
    original change needs to be modified to be reliable

Vladimir, this is being posted as the issue is taken care run time.

Regards
afzal

---
 arch/arm/mm/nommu.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mm/nommu.c b/arch/arm/mm/nommu.c
index 3b5c7aaf9c76..33a45bd96860 100644
--- a/arch/arm/mm/nommu.c
+++ b/arch/arm/mm/nommu.c
@@ -303,7 +303,10 @@ static inline void set_vbar(unsigned long val)
  */
 static inline bool security_extensions_enabled(void)
 {
-	return !!cpuid_feature_extract(CPUID_EXT_PFR1, 4);
+	/* Check CPUID Identification Scheme before ID_PFR1 read */
+	if ((read_cpuid_id() & 0x000f0000) == 0x000f0000)
+		return !!cpuid_feature_extract(CPUID_EXT_PFR1, 4);
+	return 0;
 }
 
 static unsigned long __init setup_vectors_base(void)
-- 
2.12.0

[toc] | [next] | [standalone]

#1607348

Hi,

On Fri, Mar 17, 2017 at 10:10:34PM +0530, afzal mohammed wrote:
> Greg upon trying to boot no-MMU Kernel on ARM926EJ reported boot
> failure. He root caused it to ID_PFR1 access introduced by the
> commit mentioned in the fixes tag below.
> 
> All CP15 processors need not have processor feature registers, only
> for architectures defined by CPUID scheme would have it. Hence check
> for it before accessing processor feature register, ID_PFR1.
> 
> Fixes: f8300a0b5de0 ("ARM: 8647/2: nommu: dynamic exception base address setting")
> Reported-by: Greg Ungerer <gerg@uclinux.org>
> Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>

Greg, can i add your Tested-by ?

Regards
afzal

> ---
> 
> Hi Russell,
> 
> It would be good to have the fix go in during -rc, as,
> 
> 1. Culprit commit went in during the last merge window
> 2. Though nothing supported in mainline is known to be broken, the
>     original change needs to be modified to be reliable

[toc] | [prev] | [next] | [standalone]

#1607399

Hi Afzal,

On 23/03/17 20:43, afzal mohammed wrote:
> On Fri, Mar 17, 2017 at 10:10:34PM +0530, afzal mohammed wrote:
>> Greg upon trying to boot no-MMU Kernel on ARM926EJ reported boot
>> failure. He root caused it to ID_PFR1 access introduced by the
>> commit mentioned in the fixes tag below.
>>
>> All CP15 processors need not have processor feature registers, only
>> for architectures defined by CPUID scheme would have it. Hence check
>> for it before accessing processor feature register, ID_PFR1.
>>
>> Fixes: f8300a0b5de0 ("ARM: 8647/2: nommu: dynamic exception base address setting")
>> Reported-by: Greg Ungerer <gerg@uclinux.org>
>> Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
>
> Greg, can i add your Tested-by ?

Absolutely:

Tested-by: Greg Ungerer <gerg@uclinux.org>

Thanks for taking care of this.

Regards
Greg


>> ---
>>
>> Hi Russell,
>>
>> It would be good to have the fix go in during -rc, as,
>>
>> 1. Culprit commit went in during the last merge window
>> 2. Though nothing supported in mainline is known to be broken, the
>>     original change needs to be modified to be reliable
>

[toc] | [prev] | [next] | [standalone]

#1607452

Hi,

On Thu, Mar 23, 2017 at 09:37:48PM +1000, Greg Ungerer wrote:
> Tested-by: Greg Ungerer <gerg@uclinux.org>

Thanks Greg

Since there was no negative feedback yet, change has been deposited in
rmk's patch system as 8665/1

Regards
afzal 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web