Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1605995 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-03-21 22:00 +0100 |
| Last post | 2017-03-23 14:10 +0100 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ARM: gemini: don't select SERIAL_OF_PLATFORM Arnd Bergmann <arnd@arndb.de> - 2017-03-21 22:00 +0100
Re: [PATCH] ARM: gemini: don't select SERIAL_OF_PLATFORM Linus Walleij <linus.walleij@linaro.org> - 2017-03-23 11:30 +0100
Re: [PATCH] ARM: gemini: don't select SERIAL_OF_PLATFORM Arnd Bergmann <arnd@arndb.de> - 2017-03-23 13:20 +0100
Re: [PATCH] ARM: gemini: don't select SERIAL_OF_PLATFORM Linus Walleij <linus.walleij@linaro.org> - 2017-03-23 14:10 +0100
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-03-21 22:00 +0100 |
| Subject | [PATCH] ARM: gemini: don't select SERIAL_OF_PLATFORM |
| Message-ID | <tnz2O-8X-13@gated-at.bofh.it> |
We cannot select the option when SERIAL_8250 is not also set: warning: (ARCH_GEMINI) selects SERIAL_OF_PLATFORM which has unmet direct dependencies (TTY && HAS_IOMEM && SERIAL_8250 && OF) This removes the 'select' statement, requiring that users enable the option manually. Alternatively, we could make it a conditional 'select SERIAL_OF_PLATFORM if SERIAL_8250' or also select a handful of other symbols that it depends on. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/arm/mach-gemini/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-gemini/Kconfig b/arch/arm/mach-gemini/Kconfig index a5ee5fbab796..4162396af6de 100644 --- a/arch/arm/mach-gemini/Kconfig +++ b/arch/arm/mach-gemini/Kconfig @@ -8,6 +8,5 @@ menuconfig ARCH_GEMINI select GPIOLIB select POWER_RESET select POWER_RESET_SYSCON - select SERIAL_OF_PLATFORM help Support for the Cortina Systems Gemini family SoCs -- 2.9.0
[toc] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2017-03-23 11:30 +0100 |
| Message-ID | <to8ae-TC-33@gated-at.bofh.it> |
| In reply to | #1605995 |
On Tue, Mar 21, 2017 at 9:52 PM, Arnd Bergmann <arnd@arndb.de> wrote: > We cannot select the option when SERIAL_8250 is not also set: > > warning: (ARCH_GEMINI) selects SERIAL_OF_PLATFORM which has unmet direct dependencies (TTY && HAS_IOMEM && SERIAL_8250 && OF) > > This removes the 'select' statement, requiring that users enable the > option manually. Alternatively, we could make it a conditional > 'select SERIAL_OF_PLATFORM if SERIAL_8250' or also select a handful > of other symbols that it depends on. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Will you apply this directly to the interestingly misspelled "gemeni/multiplatform" branch in the ARM SoC tree directly? I will send pull requests on top of that branch later for more features. Yours, Linus Walleij
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-03-23 13:20 +0100 |
| Message-ID | <to9SF-25x-13@gated-at.bofh.it> |
| In reply to | #1607326 |
On Thu, Mar 23, 2017 at 11:22 AM, Linus Walleij
<linus.walleij@linaro.org> wrote:
> On Tue, Mar 21, 2017 at 9:52 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>
>> We cannot select the option when SERIAL_8250 is not also set:
>>
>> warning: (ARCH_GEMINI) selects SERIAL_OF_PLATFORM which has unmet direct dependencies (TTY && HAS_IOMEM && SERIAL_8250 && OF)
>>
>> This removes the 'select' statement, requiring that users enable the
>> option manually. Alternatively, we could make it a conditional
>> 'select SERIAL_OF_PLATFORM if SERIAL_8250' or also select a handful
>> of other symbols that it depends on.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Will you apply this directly to the interestingly misspelled
> "gemeni/multiplatform" branch in the ARM SoC tree
> directly?
>
> I will send pull requests on top of that branch later
> for more features.
If you are going to send more pull requests, just add the fixup there,
it's not urgent.
Arnd
[toc] | [prev] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2017-03-23 14:10 +0100 |
| Message-ID | <toaF4-2Eh-31@gated-at.bofh.it> |
| In reply to | #1607424 |
On Thu, Mar 23, 2017 at 1:13 PM, Arnd Bergmann <arnd@arndb.de> wrote: > On Thu, Mar 23, 2017 at 11:22 AM, Linus Walleij > <linus.walleij@linaro.org> wrote: >> On Tue, Mar 21, 2017 at 9:52 PM, Arnd Bergmann <arnd@arndb.de> wrote: >> >>> We cannot select the option when SERIAL_8250 is not also set: >>> >>> warning: (ARCH_GEMINI) selects SERIAL_OF_PLATFORM which has unmet direct dependencies (TTY && HAS_IOMEM && SERIAL_8250 && OF) >>> >>> This removes the 'select' statement, requiring that users enable the >>> option manually. Alternatively, we could make it a conditional >>> 'select SERIAL_OF_PLATFORM if SERIAL_8250' or also select a handful >>> of other symbols that it depends on. >>> >>> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> >> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> >> >> Will you apply this directly to the interestingly misspelled >> "gemeni/multiplatform" branch in the ARM SoC tree >> directly? >> >> I will send pull requests on top of that branch later >> for more features. > > If you are going to send more pull requests, just add the fixup there, > it's not urgent. OK thanks, I'll queue it. Yours, Linus Walleij
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web